)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1e0050535368c3c48702f09a240f94f67fa2df61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce9bc11c_94669338","updated":"2025-05-13 13:40:38.000000000","message":"I like this - so much code and special cases going out :-) - one comment, two questions remain","commit_id":"81d13ec912ce005211b0c58e1846cba5c91a50a4"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ec801f8bc1dfaf51c740dbfe9a501b235662311a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be39cae7_d81640f5","updated":"2025-05-13 14:49:57.000000000","message":"the rebasing broke the patch, because the intermediate driver autocreation patch snuck in another WINDOWS_DRIVER_WINTUN","commit_id":"dea09bcbb330e88591ed99fb3929b85d517887d2"}],"include/openvpn-msg.h":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1e0050535368c3c48702f09a240f94f67fa2df61","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    msg_del_wfp_block,"},{"line_number":45,"context_line":"    msg_register_dns,"},{"line_number":46,"context_line":"    msg_enable_dhcp,"},{"line_number":47,"context_line":"    msg_register_ring_buffers,"},{"line_number":48,"context_line":"    msg_set_mtu,"},{"line_number":49,"context_line":"    msg_add_wins_cfg,"},{"line_number":50,"context_line":"    msg_del_wins_cfg"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"6f74688f_234eb585","side":"PARENT","line":47,"updated":"2025-05-13 13:40:38.000000000","message":"I am a bit worried about taking out message number enums, leading to testing challenges when having openvpn.exe talking to an iservice that is from a different build version (this might not affect anyone but me, but I usually just build an openvpn.exe and use \"the rest\" from a regular .msi install)","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"94b624546a562043a99a273df33028c23e8c0835","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    msg_del_wfp_block,"},{"line_number":45,"context_line":"    msg_register_dns,"},{"line_number":46,"context_line":"    msg_enable_dhcp,"},{"line_number":47,"context_line":"    msg_register_ring_buffers,"},{"line_number":48,"context_line":"    msg_set_mtu,"},{"line_number":49,"context_line":"    msg_add_wins_cfg,"},{"line_number":50,"context_line":"    msg_del_wins_cfg"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"8f9f9442_c5569e1b","side":"PARENT","line":47,"in_reply_to":"6f74688f_234eb585","updated":"2025-05-13 14:25:13.000000000","message":"Done","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"}],"src/openvpn/forward.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1e0050535368c3c48702f09a240f94f67fa2df61","unresolved":true,"context_lines":[{"line_number":2227,"context_line":"             * by previous tun read"},{"line_number":2228,"context_line":"             */"},{"line_number":2229,"context_line":"            skip_iowait \u003d !(flags \u0026 IOW_TO_LINK);"},{"line_number":2230,"context_line":"        }"},{"line_number":2231,"context_line":"        if (tuntap_is_wintun(c-\u003ec1.tuntap) \u0026\u0026 skip_iowait)"},{"line_number":2232,"context_line":"        {"},{"line_number":2233,"context_line":"            unsigned int ret \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"bd5e03db_47c6ab5d","side":"PARENT","line":2230,"updated":"2025-05-13 13:40:38.000000000","message":"this is similar to the thing in `forward.h` - is this related to wintun particulars, or \"windows read/write\" in general?","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"94b624546a562043a99a273df33028c23e8c0835","unresolved":false,"context_lines":[{"line_number":2227,"context_line":"             * by previous tun read"},{"line_number":2228,"context_line":"             */"},{"line_number":2229,"context_line":"            skip_iowait \u003d !(flags \u0026 IOW_TO_LINK);"},{"line_number":2230,"context_line":"        }"},{"line_number":2231,"context_line":"        if (tuntap_is_wintun(c-\u003ec1.tuntap) \u0026\u0026 skip_iowait)"},{"line_number":2232,"context_line":"        {"},{"line_number":2233,"context_line":"            unsigned int ret \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"ab5875dc_3a7846ca","side":"PARENT","line":2230,"in_reply_to":"bd5e03db_47c6ab5d","updated":"2025-05-13 14:25:13.000000000","message":"This is from \"wintun: ring buffers based I/O\" patch\n\nhttps://github.com/OpenVPN/openvpn/commit/d5fc4bd41616ee01816df873cb6b6567872a29e2#diff-b955244e0fcf190f9a22548de16381cac34b6efaad20300d7a04c5691cd1017aL406","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"}],"src/openvpn/forward.h":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"1e0050535368c3c48702f09a240f94f67fa2df61","unresolved":true,"context_lines":[{"line_number":403,"context_line":"             * by previous tun read"},{"line_number":404,"context_line":"             */"},{"line_number":405,"context_line":"            skip_iowait \u003d !(flags \u0026 IOW_TO_LINK);"},{"line_number":406,"context_line":"        }"},{"line_number":407,"context_line":"        if (tuntap_is_wintun(c-\u003ec1.tuntap) \u0026\u0026 skip_iowait)"},{"line_number":408,"context_line":"        {"},{"line_number":409,"context_line":"            unsigned int ret \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"1d13e680_6724da03","side":"PARENT","line":406,"updated":"2025-05-13 13:40:38.000000000","message":"is that related to wintun? (\"it does not say so, and I\u0027m not aware of the origins of this code\")","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"94b624546a562043a99a273df33028c23e8c0835","unresolved":false,"context_lines":[{"line_number":403,"context_line":"             * by previous tun read"},{"line_number":404,"context_line":"             */"},{"line_number":405,"context_line":"            skip_iowait \u003d !(flags \u0026 IOW_TO_LINK);"},{"line_number":406,"context_line":"        }"},{"line_number":407,"context_line":"        if (tuntap_is_wintun(c-\u003ec1.tuntap) \u0026\u0026 skip_iowait)"},{"line_number":408,"context_line":"        {"},{"line_number":409,"context_line":"            unsigned int ret \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"0d807ff9_8c3bd023","side":"PARENT","line":406,"in_reply_to":"1d13e680_6724da03","updated":"2025-05-13 14:25:13.000000000","message":"Yes, this is from \"wintun: ring buffers based I/O\" patch \n\nhttps://github.com/OpenVPN/openvpn/commit/d5fc4bd41616ee01816df873cb6b6567872a29e2#diff-b955244e0fcf190f9a22548de16381cac34b6efaad20300d7a04c5691cd1017aR382-R412","commit_id":"b6af9b2841005cf139bf8d0c3ed40561903b59af"}],"src/openvpn/tun.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ec801f8bc1dfaf51c740dbfe9a501b235662311a","unresolved":true,"context_lines":[{"line_number":473,"context_line":"        case WINDOWS_DRIVER_WINTUN:"},{"line_number":474,"context_line":"            t \u003d ADAPTER_TYPE_WINTUN;"},{"line_number":475,"context_line":"            break;"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"        case DRIVER_DCO:"},{"line_number":478,"context_line":"            t \u003d ADAPTER_TYPE_DCO;"},{"line_number":479,"context_line":"            break;"}],"source_content_type":"text/x-csrc","patch_set":4,"id":"1bb89423_93d37006","line":476,"updated":"2025-05-13 14:49:57.000000000","message":"oops","commit_id":"dea09bcbb330e88591ed99fb3929b85d517887d2"}]}