)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"24c2edd0034d2122ecab8531d89e62e8518f6d12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c5c72e0_dee5edd4","updated":"2025-05-14 21:11:54.000000000","message":"I had a look and it makes sense to me. However, since I am biased on this patch, I am giving only a +1","commit_id":"262bfdf8e0bd1fcca617ee3a3dfcb39be22a30dc"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"66b86ac8ebba38a444a1bcb53b16c79d29b845aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"635f33ce_df3a3426","updated":"2025-05-15 09:57:00.000000000","message":"Running basic tests with \"openvpn --version\"\n\nTest #1 \"no ovpn.ko around\": `DCO version: N/A`\nTest #2 \"ovpn.ko around, but not exporting anything\" (older branch)\": `DCO version: \nN/A`\nTest #3 \"modprobe ovpn.ko\": `DCO version: 5.4.0-215-generic #235-Ubuntu SMP Fri Apr 11 21:55:32 UTC 2025`\nTest #4: actually running an OpenVPN client, hoping for module autoload -\u003e works.\n\nso this is generally good (will add test #5 when I have a backports with exported module version).  Interesting to keep in mind: `openvpn --version` will not(!) autoload the module.","commit_id":"9ae9f6b9a3ad0cb4aad1f2dc6a5516695c3a8030"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a2823f21eb2aa07046837515703139f7b6a8a5ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb66e838_3d61e1c7","updated":"2025-05-15 15:00:16.000000000","message":"test #5, with a current backport:\n\n```\n2025-05-15 16:59:43 DCO version: ovpn-net-next/development-sources-6.15.0-rc5-0f03aa5\n\n```","commit_id":"9ae9f6b9a3ad0cb4aad1f2dc6a5516695c3a8030"}],"src/openvpn/dco_linux.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"683ccc8c4b1b0c60bb174399a35d17778338ca4f","unresolved":true,"context_lines":[{"line_number":1148,"context_line":"dco_version_string_backports(FILE *fp, struct gc_arena *gc)"},{"line_number":1149,"context_line":"{"},{"line_number":1150,"context_line":"    struct buffer buf \u003d alloc_buf_gc(256, gc);"},{"line_number":1151,"context_line":"    char *str \u003d BSTR(\u0026buf);"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if (!fgets(str, BCAP(\u0026buf), fp))"},{"line_number":1154,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9828d2a3_64a0b942","line":1151,"updated":"2025-05-15 06:20:42.000000000","message":"this looks more fumbly than needed - why deal with a `buffer` here if all you want is a `*str`?  I\u0027d change this to\n\n```\nchar * str \u003d gc_malloc(PATH_MAX, false, gc);\n\n...fgets(str, PATH_MAX, fp)...\n```\n\n(PATH_MAX is just conveniently lying around and of about the right size, to avoid having magic numbers here)","commit_id":"262bfdf8e0bd1fcca617ee3a3dfcb39be22a30dc"},{"author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"395b2003831574a52fc245891db6dc17a301afaa","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"dco_version_string_backports(FILE *fp, struct gc_arena *gc)"},{"line_number":1149,"context_line":"{"},{"line_number":1150,"context_line":"    struct buffer buf \u003d alloc_buf_gc(256, gc);"},{"line_number":1151,"context_line":"    char *str \u003d BSTR(\u0026buf);"},{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"    if (!fgets(str, BCAP(\u0026buf), fp))"},{"line_number":1154,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9d21b9d5_2ef6dc69","line":1151,"in_reply_to":"9828d2a3_64a0b942","updated":"2025-05-15 08:28:40.000000000","message":"Done","commit_id":"262bfdf8e0bd1fcca617ee3a3dfcb39be22a30dc"}]}