)]}'
{"id":"openvpn~1026","triplet_id":"openvpn~master~I275bf939f43577427e14890e7093d63c5213ae5d","project":"openvpn","branch":"master","topic":"dns option","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-05-20 08:26:04.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-05-20 08:26:04.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"last_update":"2025-05-20 08:26:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I275bf939f43577427e14890e7093d63c5213ae5d","subject":"dns: fix potential NULL pointer dereference","status":"MERGED","created":"2025-05-19 09:19:32.000000000","updated":"2025-05-20 08:26:04.000000000","submitted":"2025-05-20 08:26:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1026-dns option","meta_rev_id":"1947143f16a8e2e87939a044a5e00223026751f0","_number":1026,"virtual_id_number":1026,"owner":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-05-19 09:19:33.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-05-19 09:19:33.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-05-19 09:19:33.000000000","updated_by":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-05-20 07:33:15.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"d89ed907feb9cdace490bcd5cee57f020513682b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-19 09:19:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0703d0737f29bdf30c05403393f8629c7f3eec9e","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-19 09:20:30.000000000","message":"Topic set to dns option","accounts_in_message":[],"_revision_number":1},{"id":"e8cd36f289a414a5846b71d50f25b9ac76d54585","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-19 09:22:19.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"aa5db4fe5ea2785455e72e50345081fa3b21d9e6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"date":"2025-05-20 07:14:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"582a55d05a13cd279f87874f5879266df06ea1f3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-20 07:33:15.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"1947143f16a8e2e87939a044a5e00223026751f0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-05-20 08:26:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d1045d19bf4ea1f717edac7c67f20e9d8eb3a261","revisions":{"67fd6cc718c4bd51d179649a955b28e530540bbb":{"kind":"REWORK","_number":1,"created":"2025-05-19 09:19:32.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/26/1026/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1026/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1 \u0026\u0026 git checkout -b change-1026 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ca8a4497f28dce3c59c5b721e7eaf8a85333985a","subject":"win: match search domains when creating exclude rules"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:13:38.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:19:29.000000000","tz":120},"subject":"dns: fix potential NULL pointer dereference","message":"dns: fix potential NULL pointer dereference\n\nFix issue reported by Coverity (CID 1646952): Dereferencing a pointer\nthat might be NULL dvf when calling env_set_write_file.\n\nIn addition to the fix, output a log line in case this happens, because\nit will influence to communication with the updown runner process, i.e.\nsetting up / tearing down DNS things will not work as expected.\n\nChange-Id: I275bf939f43577427e14890e7093d63c5213ae5d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"6e835a1ed065f41b6c75976ac2620631a0d0faed":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-05-19 09:22:19.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/26/1026/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1026/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2 \u0026\u0026 git checkout -b change-1026 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ca8a4497f28dce3c59c5b721e7eaf8a85333985a","subject":"win: match search domains when creating exclude rules"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:13:38.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:21:59.000000000","tz":120},"subject":"dns: fix potential NULL pointer dereference","message":"dns: fix potential NULL pointer dereference\n\nFix issue reported by Coverity (CID 1646952): Dereferencing a pointer\nthat might be NULL dvf when calling env_set_write_file.\n\nIn addition to the fix, output a log line in case this happens, because\nit will influence the communication with the updown runner process, i.e.\nsetting up / tearing down DNS things will not work as expected.\n\nChange-Id: I275bf939f43577427e14890e7093d63c5213ae5d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"6a006e8f55c71734db1d0ece45f0c0ee862a3435":{"kind":"REWORK","_number":3,"created":"2025-05-20 07:14:35.000000000","uploader":{"_account_id":1000006,"name":"d12fk","display_name":"Heiko Hund","email":"heiko@openvpn.net","username":"d12fk"},"ref":"refs/changes/26/1026/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1026/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3 \u0026\u0026 git checkout -b change-1026 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ca8a4497f28dce3c59c5b721e7eaf8a85333985a","subject":"win: match search domains when creating exclude rules"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-19 09:13:38.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-20 04:48:51.000000000","tz":120},"subject":"dns: fix potential NULL pointer dereference","message":"dns: fix potential NULL pointer dereference\n\nFix issue reported by Coverity (CID 1646952): Dereferencing a pointer\nthat might be NULL dvf when calling env_set_write_file.\n\nIn addition to the fix, inline the write_dns_vars_file() helper function.\nAlso output a log line in case this error happens, because when it\nhappens it will hinder communication with the updown runner process, i.e.\nsetting up / tearing down DNS things will not work as expected.\n\nChange-Id: I275bf939f43577427e14890e7093d63c5213ae5d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"d1045d19bf4ea1f717edac7c67f20e9d8eb3a261":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-05-20 08:26:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/26/1026/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/26/1026/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4 \u0026\u0026 git checkout -b change-1026 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/26/1026/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d2b59d6db2ee11f3875257b854e0b77265389f2c","subject":"Doxygen: Fix missing parameter warnings"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-05-20 07:33:48.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-05-20 07:36:15.000000000","tz":120},"subject":"dns: fix potential NULL pointer dereference","message":"dns: fix potential NULL pointer dereference\n\nFix issue reported by Coverity (CID 1646952): Dereferencing a pointer\nthat might be NULL dvf when calling env_set_write_file.\n\nIn addition to the fix, inline the write_dns_vars_file() helper function.\nAlso output a log line in case this error happens, because when it\nhappens it will hinder communication with the updown runner process, i.e.\nsetting up / tearing down DNS things will not work as expected.\n\nChange-Id: I275bf939f43577427e14890e7093d63c5213ae5d\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250520073354.17091-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31720.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}