)]}'
{"id":"openvpn~1036","triplet_id":"openvpn~master~I15c730c9eb3f1338019577e7c665c0ca5b1edcd4","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-06-02 16:05:21.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-06-02 16:05:21.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-06-02 15:38:47.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I15c730c9eb3f1338019577e7c665c0ca5b1edcd4","subject":"Delete old sample-windows file and obsolete Windows sample handling","status":"MERGED","created":"2025-06-02 10:38:54.000000000","updated":"2025-06-02 16:05:21.000000000","submitted":"2025-06-02 16:05:21.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1036","meta_rev_id":"5301dff5ca5c3347ddd479269bb159133e4be8a7","_number":1036,"virtual_id_number":1036,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-02 10:38:55.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-06-02 10:38:55.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-06-02 15:38:30.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"b98ddac1a771335116e5a35e55d0914db4dc924a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-06-02 10:38:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d10019bfcede2f545be651f8dd070b0007e382db","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-06-02 10:45:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1210b60f9bc86a87ec6bc40b6256c7ced69b3166","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-02 15:38:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"fd94449c87c17852e7ebd887d1f66d63cffb8a81","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-02 15:38:46.000000000","message":"Patch Set 3: Commit message was updated.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5301dff5ca5c3347ddd479269bb159133e4be8a7","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-02 16:05:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"1b6b1e33ed9646be97110f5cd1f31a8b2ba0dce8","revisions":{"a4236cda9b96f9218ce9c0b66b8688a200a097a1":{"kind":"REWORK","_number":1,"created":"2025-06-02 10:38:54.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/36/1036/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1036/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1 \u0026\u0026 git checkout -b change-1036 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c2776ee0ff03832bb2213ebd19e9a14d37445bed","subject":"Add missing header in unit tests Makefile.am"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 10:33:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 10:38:01.000000000","tz":120},"subject":"Delete old sample-windows file","message":"Delete old sample-windows file\n\nThis file is apparently over 20 years old and\nwas never updated besides fixing some obvious\nsyntax errors with new versions.\n\nSo let\u0027s just get rid of it. AFAICT the Windows\ninstaller does not use it. Only the\n{server,client}.ovpn.\n\nGithub: Closes #758\nChange-Id: I15c730c9eb3f1338019577e7c665c0ca5b1edcd4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d7d8b0ffa54a2eb2feac819a47ecd994a6524a8a":{"kind":"REWORK","_number":2,"created":"2025-06-02 10:45:57.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/36/1036/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1036/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2 \u0026\u0026 git checkout -b change-1036 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c2776ee0ff03832bb2213ebd19e9a14d37445bed","subject":"Add missing header in unit tests Makefile.am"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 10:33:46.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 10:44:31.000000000","tz":120},"subject":"Delete old sample-windows file and obsolete Windows sample handling","message":"Delete old sample-windows file and obsolete Windows sample handling\n\nThis file is apparently over 20 years old and\nwas never updated besides fixing some obvious\nsyntax errors with new versions.\n\nSo let\u0027s just get rid of it. AFAICT the Windows\ninstaller does not use it. Only the\n{server,client}.ovpn. And even there, it just uses\nthe files directly from the build directory and\ndoes not depend on us renaming them (which is\nobvious since we do not use the Makefile at all\nin the Windows build, only CMake).\n\nGithub: Closes #758\nChange-Id: I15c730c9eb3f1338019577e7c665c0ca5b1edcd4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"74718528d51ebe6794957df62a4c4d8f1de98da5":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-06-02 15:38:46.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/36/1036/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1036/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3 \u0026\u0026 git checkout -b change-1036 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c2776ee0ff03832bb2213ebd19e9a14d37445bed","subject":"Add missing header in unit tests Makefile.am"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 10:33:46.000000000","tz":120},"committer":{"name":"cron2","email":"gert@greenie.muc.de","date":"2025-06-02 15:38:46.000000000","tz":0},"subject":"Delete old sample-windows file and obsolete Windows sample handling","message":"Delete old sample-windows file and obsolete Windows sample handling\n\nThis file is apparently over 20 years old and\nwas never updated besides fixing some obvious\nsyntax errors with new versions.\n\nSo let\u0027s just get rid of it. AFAICT the Windows\ninstaller does not use it. Only the\n{server,client}.ovpn. And even there, it just uses\nthe files directly from the build directory and\ndoes not depend on us renaming them (which is\nobvious since we do not use the Makefile at all\nin the Windows build, only CMake).\n\nGithub: Closes OpenVPN/openvpn#758\nChange-Id: I15c730c9eb3f1338019577e7c665c0ca5b1edcd4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master","description":"Edit commit message"},"1b6b1e33ed9646be97110f5cd1f31a8b2ba0dce8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-06-02 16:05:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/36/1036/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/36/1036/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4 \u0026\u0026 git checkout -b change-1036 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/36/1036/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"92b9cb5e0363a1c19b76a5a6e5f36c9891406590","subject":"Do not segfault on missing --dh in server config"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-06-02 15:38:54.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-06-02 15:59:45.000000000","tz":120},"subject":"Delete old sample-windows file and obsolete Windows sample handling","message":"Delete old sample-windows file and obsolete Windows sample handling\n\nThis file is apparently over 20 years old and\nwas never updated besides fixing some obvious\nsyntax errors with new versions.\n\nSo let\u0027s just get rid of it. AFAICT the Windows\ninstaller does not use it. Only the\n{server,client}.ovpn. And even there, it just uses\nthe files directly from the build directory and\ndoes not depend on us renaming them (which is\nobvious since we do not use the Makefile at all\nin the Windows build, only CMake).\n\nGithub: Closes OpenVPN/openvpn#758\nChange-Id: I15c730c9eb3f1338019577e7c665c0ca5b1edcd4\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250602153900.29646-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31850.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}