)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"82de1c9e35ed1b4615fedb040ae4b6d63421ebbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b24cac1e_4860f31e","updated":"2025-06-18 09:12:08.000000000","message":"You don\u0027t need to close/reopen to update your patch, you can just push the change again. But here is the same comment that I had on the original version of the patch:\n\nI feel this is the wrong approach. We are trying to avoid the NID dance. And it seems that wolfSSL already has a function \n\nint wolfSSL_CTX_set1_groups_list(WOLFSSL_CTX *ctx, const char *list)\n\nthat has the same (better) functionality of its SSL_CTX_set1_groups_list OpenSSL equivalent. So rather than doing this NID dance, I would prefer that we use the proper function instead. \n\nMaybe wolfSSL upstream can also be convinced to map this to SSL_CTX_set1_groups_list as well.","commit_id":"ef6be02cf3a845152e2b8b70b7f2dc02b420c194"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f1f623cb3fdc97b66347e0c959a19a3019d38f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9059272f_299e7157","updated":"2025-06-23 11:53:11.000000000","message":"getting closer ;-)","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"280de4cba0726b6455ef0ebf93bca84653571b8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"56bb5c4a_5e811783","updated":"2025-06-25 22:23:31.000000000","message":"I tested the patch and it works and is also a lot cleaner than the first version.\n\nThere are some documentation updates I would like to see (see the other comments) to ensure users to don\u0027t get lost with the difference in OpenSSL vs wolfSSL names and defaults.\n\nAlso wolfSSL\u0027s ML-DSA-87 seems to be a bit wacky for now. It cannot read the private key generated by OpenSSL and when connecting to a server with ml-kem and fingerprints it seems not be able to read some of the fields with the current APIs that we use:\n\n[wolfSSL] Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: , signature: ML-DSA 87, peer signing digest/type: SHA512 ML-DSA 87\n\nvs\n\n[OpenSSL] Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 20736 bits ML-DSA-87, signature: id-ml-dsa-87, peer signing digest/type: mldsa87 id-ml-dsa-87, key agreement: X25519MLKEM768\n\nbut that should be probably adresses in a different patch.","commit_id":"bd98945cf68124460fd1e917e3c30c8e01d4f3ae"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"38d66bc8b93b15282ccfc32ab64e8aee7fe8c7af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a369c88_2f985438","updated":"2025-06-25 16:25:31.000000000","message":"I\u0027m generally fine with the change as it is now.\n\nNot being a crypto expert, I leave the final say to Arne (especially as there\u0027s open discussions)","commit_id":"bd98945cf68124460fd1e917e3c30c8e01d4f3ae"},{"author":{"_account_id":1000039,"name":"comododragon","email":"rein.vanbaaren@fox-it.com","username":"comododragon"},"change_message_id":"77b71b5b96d38f6ee090adbad8286806a6d779f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7dce9470_917dce2f","in_reply_to":"56bb5c4a_5e811783","updated":"2025-07-07 11:03:59.000000000","message":"Let me write this down so I can look at it later. Thanks!","commit_id":"bd98945cf68124460fd1e917e3c30c8e01d4f3ae"}],"README.wolfssl":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"5e7537b85cd4df32543f1693e08a7add95004676","unresolved":true,"context_lines":[{"line_number":36,"context_line":"./configure --enable-openvpn --enable-kyber --enable-mlkem --enable-curve25519"},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"WolfSSL supports the following Quantum Safe algorithms by specifying them using the `tls-groups` "},{"line_number":40,"context_line":"option in a config."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"```"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ab0e57c2_c22d8064","line":39,"updated":"2025-06-23 13:29:43.000000000","message":"you should also mention that wolfSSL uses different names for standard groups like secp384r1 vs P-384. Probably also good to add that as a remark in the man page for tls-groups","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"280de4cba0726b6455ef0ebf93bca84653571b8d","unresolved":true,"context_lines":[{"line_number":36,"context_line":"./configure --enable-openvpn --enable-kyber --enable-mlkem --enable-curve25519"},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"WolfSSL supports the following Quantum Safe algorithms by specifying them using the `tls-groups` "},{"line_number":40,"context_line":"option in a config."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"```"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"19a0ea53_119798bd","line":39,"in_reply_to":"9582318b_73069ab0","updated":"2025-06-25 22:23:31.000000000","message":"Okay you are right for the *plain* P384 curve but not for the hybrid ones (see below). But we NEED to mention is that the names of the new key agreements are different.\n\nIf you try to use the names that work with OpenSSL (https://community.openvpn.net/PQCryptoOpenVPN) you get only an error \n\nFailed to set allowed TLS group list: secp384r1:X25519MLKEM768\n\nwhile OpenSSL also does not like the wolfSSL names. It is probably good to least mention the difference in the naming, e.g. by adding the names of the OpenSSL (our TLS library) in brackes in the readme. \n\nAlso OpenSSL *only* accepts secp384r1MLKEM1024 and not P384MLKEM1024. So it is something more than just removing the _ from the names.\n\nSo I still it would be good document this fact at least in the man page for tls-groups by adding a paragraph like:\n\n Please note that when OpenVPN is compiled with wolfSSL, the names of the groups might be called different, especially the PQ groups (e.g. X25519_ML_KEM_512 instead of X25519MLKEM768 or P384_MLKEM_1024 instead of secp384r1MLKEM1024)","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"},{"author":{"_account_id":1000039,"name":"comododragon","email":"rein.vanbaaren@fox-it.com","username":"comododragon"},"change_message_id":"955798ae5cb060cd358eaa76a42325a8050a99d9","unresolved":true,"context_lines":[{"line_number":36,"context_line":"./configure --enable-openvpn --enable-kyber --enable-mlkem --enable-curve25519"},{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"WolfSSL supports the following Quantum Safe algorithms by specifying them using the `tls-groups` "},{"line_number":40,"context_line":"option in a config."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"```"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9582318b_73069ab0","line":39,"in_reply_to":"ab0e57c2_c22d8064","updated":"2025-06-25 12:48:47.000000000","message":"What do you mean? WolfSSL allows the definition of secp384r1 and P-384 respectively interchangeably.","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f1f623cb3fdc97b66347e0c959a19a3019d38f4a","unresolved":true,"context_lines":[{"line_number":37,"context_line":"```"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"WolfSSL supports the following Quantum Safe algorithms by specifying them using the `tls-groups` "},{"line_number":40,"context_line":"option in a config."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"```"},{"line_number":43,"context_line":"ML_KEM_512"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7ec159a7_61317087","line":40,"updated":"2025-06-23 11:53:11.000000000","message":"the textual logic is weird here - \"to build with these PQE...\", while \"these PQE\" are only defined in the next paragraph...?","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"280de4cba0726b6455ef0ebf93bca84653571b8d","unresolved":true,"context_lines":[{"line_number":35,"context_line":"./configure --enable-openvpn --enable-kyber\u003dall --enable-curve25519"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"WolfSSL supports the following post-quantum KEMs or post-quantum hybrid KEMs by specifying them using the `tls-groups` "},{"line_number":38,"context_line":"option in an OpenVPN config."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"ML_KEM_512"},{"line_number":41,"context_line":"ML_KEM_768"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"41367317_be158cd2","line":38,"updated":"2025-06-25 22:23:31.000000000","message":"Add a paragraph here like:\n\nIn contrast to OpenSSL that includes X25519MLKEM768 in the default configuration, wolfSSL will need to explicitly have tls-groups configured to include (at least one) PQ KEM.","commit_id":"bd98945cf68124460fd1e917e3c30c8e01d4f3ae"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"8ba1dc7fc0244cb6fd38e4032ec52cf8eb58e8b1","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"The naming conventions of algorithms differ between WolfSSL and OpenSSL. An example is that"},{"line_number":58,"context_line":"OpenSSL omits underscores for their naming notation whereas WolfSSL expects them. Additionally, "},{"line_number":59,"context_line":"OpenSSL does not accept the P curve notation and instead uses the equivalent secp notation. "},{"line_number":60,"context_line":"A specific example is that WolfSSL expects P384_ML_KEM_1024, while OpenSSL expects secp384r1MLKEM1024."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"590f267a_2d630a04","line":59,"updated":"2025-07-07 12:06:39.000000000","message":"Still white space errors. Maybe we can fix them on merge.","commit_id":"163b0cfb9074029307fb997d04b8323f861a5618"}],"src/openvpn/ssl_openssl.c":[{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f1f623cb3fdc97b66347e0c959a19a3019d38f4a","unresolved":true,"context_lines":[{"line_number":561,"context_line":"{"},{"line_number":562,"context_line":"    ASSERT(ctx);"},{"line_number":563,"context_line":"#if defined(ENABLE_CRYPTO_WOLFSSL) || OPENSSL_VERSION_NUMBER \u003e\u003d 0x30000000L"},{"line_number":564,"context_line":"    if (!SSL_CTX_set1_groups_list(ctx-\u003ectx, groups))"},{"line_number":565,"context_line":"    {"},{"line_number":566,"context_line":"        crypto_msg(M_FATAL, \"Failed to set allowed TLS group list: %s\","},{"line_number":567,"context_line":"                groups);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"e1a1e35c_b06c65eb","line":564,"updated":"2025-06-23 11:53:11.000000000","message":"please do not do that - that is, move code blocks around, just to have an easier time in the #ifdef\n\nAs far as I can see all the patch really does is \"change the #ifdef\", but with a larger diff due to swapping the if/else parts this is harder to see, and will also mess up \"git blame\"","commit_id":"159af710b502f667482522fd11ca4ec800b33c65"}]}
