)]}'
{"id":"openvpn~1066","triplet_id":"openvpn~master~I7b413578a8fc0c65fca26f72b901a9f7bc34b137","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2025-06-26 09:26:37.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-06-26 09:17:52.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-06-26 09:26:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7b413578a8fc0c65fca26f72b901a9f7bc34b137","subject":"fix macOS dns-updown handling of parallel full redirects","status":"MERGED","created":"2025-06-25 10:45:07.000000000","updated":"2025-06-26 09:26:37.000000000","submitted":"2025-06-26 09:26:37.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1066","meta_rev_id":"9c5fcf9f5d86195510e4cf8f6ea62e093c472110","_number":1066,"virtual_id_number":1066,"owner":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-25 10:45:07.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-06-25 10:45:07.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-06-25 10:45:07.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"5442ca3218e73bc1ab3cb3971cdf90a7ef34cd1d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-06-25 10:45:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a7c54b31742a4b1392bb03104048394bccc70841","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-06-26 09:10:37.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"69d305fed93683c0fd58e4810f63b1082d9763e3","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-06-26 09:17:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"01e7be434ae06068a85385dcf15473ed5fba23eb","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-06-26 09:18:07.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9c5fcf9f5d86195510e4cf8f6ea62e093c472110","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-26 09:26:37.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7a2b814fee06ab1edeb5f9ad104880f0fef5b0ba","revisions":{"275e3c02f6329b8e4b463fdbdabb41d86ca3f623":{"kind":"REWORK","_number":1,"created":"2025-06-25 10:45:07.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/66/1066/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1066/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1 \u0026\u0026 git checkout -b change-1066 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9562d9ed0d8b153608196c0ad4f34b45d76c926d","subject":"run forced --dns-updown without --script-security"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-25 09:56:56.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-25 10:44:45.000000000","tz":120},"subject":"fix macOS dns-updown handling of parallel full redirects","message":"fix macOS dns-updown handling of parallel full redirects\n\nThe script didn\u0027t handle scenarios well where two or more parallel VPN\nconnections want to replace the default DNS server. The DNS configuration\nhas a chance to get broken by the connections going down in a different\norder than they came up in.\n\nDisallowing all but the first connection to modify the default DNS server\nwill effectively prevent this issue. While it may break DNS for the\nlatter connections, it is the best we can do without knowing specifics\nabout the configurations.\n\nChange-Id: I7b413578a8fc0c65fca26f72b901a9f7bc34b137\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"5a36c6be4f4c031ed262fb6ad030a877a9c35b9a":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-06-26 09:10:37.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/66/1066/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1066/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2 \u0026\u0026 git checkout -b change-1066 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9c0110ee672df7555ea79b685bacd8e591aaa2c0","subject":"run forced --dns-updown without --script-security"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-25 09:56:56.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-26 09:10:17.000000000","tz":120},"subject":"fix macOS dns-updown handling of parallel full redirects","message":"fix macOS dns-updown handling of parallel full redirects\n\nThe script didn\u0027t handle scenarios well where two or more parallel VPN\nconnections want to replace the default DNS server. The DNS configuration\nhas a chance to get broken by the connections going down in a different\norder than they came up in.\n\nDisallowing all but the first connection to modify the default DNS server\nwill effectively prevent this issue. While it may break DNS for the\nlatter connections, it is the best we can do without knowing specifics\nabout the configurations.\n\nChange-Id: I7b413578a8fc0c65fca26f72b901a9f7bc34b137\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"7a2b814fee06ab1edeb5f9ad104880f0fef5b0ba":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-06-26 09:26:37.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/66/1066/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1066/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3 \u0026\u0026 git checkout -b change-1066 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/66/1066/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6c2bd6be4f8ac4f0b25aa05e2d5eb9bf6b736cd1","subject":"dco linux: avoid sending local port to ovpn"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-26 09:19:52.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-06-26 09:24:23.000000000","tz":120},"subject":"fix macOS dns-updown handling of parallel full redirects","message":"fix macOS dns-updown handling of parallel full redirects\n\nThe script didn\u0027t handle scenarios well where two or more parallel VPN\nconnections want to replace the default DNS server. The DNS configuration\nhas a chance to get broken by the connections going down in a different\norder than they came up in.\n\nDisallowing all but the first connection to modify the default DNS server\nwill effectively prevent this issue. While it may break DNS for the\nlatter connections, it is the best we can do without knowing specifics\nabout the configurations.\n\nChange-Id: I7b413578a8fc0c65fca26f72b901a9f7bc34b137\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20250626091959.23505-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31988.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
