)]}'
{"id":"openvpn~1068","triplet_id":"openvpn~master~I5d9535d46e5a5488f4a2b637a6fcb99aad668fee","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000041":{"account":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-06-25 16:49:48.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-06-25 16:49:48.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-06-25 16:49:48.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5d9535d46e5a5488f4a2b637a6fcb99aad668fee","subject":"dco linux: avoid sending local port to ovpn","status":"MERGED","created":"2025-06-25 12:43:23.000000000","updated":"2025-06-25 16:49:48.000000000","submitted":"2025-06-25 16:49:48.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1068","meta_rev_id":"f7c3a0bff97a6517a9484efd75f5be5c1c40b2d9","_number":1068,"virtual_id_number":1068,"owner":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-06-25 12:43:24.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-06-25 12:43:24.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-06-25 12:43:24.000000000","updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"real_updated_by":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-06-25 12:57:59.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"81c2c08a23e1e57732df7a296da96382f86df77b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-06-25 12:43:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a48ea36372fda0c27f127ae6894071ba19f3875","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-06-25 12:57:59.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f7c3a0bff97a6517a9484efd75f5be5c1c40b2d9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-06-25 16:49:48.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6c2bd6be4f8ac4f0b25aa05e2d5eb9bf6b736cd1","revisions":{"c8d287f343894b58419fc89df3caf7efe235c9ee":{"kind":"REWORK","_number":1,"created":"2025-06-25 12:43:23.000000000","uploader":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/68/1068/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1068/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1 \u0026\u0026 git checkout -b change-1068 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d3c2b67a73a0aa011c13e62f876d24e49d41df0","subject":"dco linux: avoid redefining ovpn enums"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-06-25 12:15:11.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-06-25 12:15:11.000000000","tz":120},"subject":"dco linux: avoid sending local port to ovpn","message":"dco linux: avoid sending local port to ovpn\n\nWhen sending an OVPN_CMD_NEW_PEER netlink message to ovpn, we currently\nattempt to include the local port along with the local address. However,\n`dco_multi_get_localaddr()` does not record the port, so we end up\nsending a zero value. This zero is rejected by ovpn\u0027s netlink policy,\nleading to an error and aborted connection.\n\nSince openvpn does not actually need to send the local port because the\nmodule retrieves it directly from the socket, this commit ensures that\nonly the local address is sent.\n\nChange-Id: I5d9535d46e5a5488f4a2b637a6fcb99aad668fee\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"6c2bd6be4f8ac4f0b25aa05e2d5eb9bf6b736cd1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-06-25 16:49:48.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/68/1068/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/68/1068/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2 \u0026\u0026 git checkout -b change-1068 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/68/1068/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1d3c2b67a73a0aa011c13e62f876d24e49d41df0","subject":"dco linux: avoid redefining ovpn enums"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-06-25 16:26:31.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-06-25 16:33:35.000000000","tz":120},"subject":"dco linux: avoid sending local port to ovpn","message":"dco linux: avoid sending local port to ovpn\n\nWhen sending an OVPN_CMD_NEW_PEER netlink message to ovpn, we currently\nattempt to include the local port along with the local address. However,\n`dco_multi_get_localaddr()` does not record the port, so we end up\nsending a zero value. This zero is rejected by ovpn\u0027s netlink policy,\nleading to an error and aborted connection.\n\nSince openvpn does not actually need to send the local port because the\nmodule retrieves it directly from the socket, this commit ensures that\nonly the local address is sent.\n\nChange-Id: I5d9535d46e5a5488f4a2b637a6fcb99aad668fee\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nMessage-Id: \u003c20250625162638.7769-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31971.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
