)]}'
{"id":"openvpn~1073","triplet_id":"openvpn~master~Ide2cddad193c636eb440c9752751176dae0a6897","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2025-07-14 16:18:26.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-14 13:00:09.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-14 16:18:26.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ide2cddad193c636eb440c9752751176dae0a6897","subject":"prevent search domain races with macOS dns-updown","status":"MERGED","created":"2025-07-03 03:56:20.000000000","updated":"2025-07-14 16:18:26.000000000","submitted":"2025-07-14 16:18:26.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1073","meta_rev_id":"ee61bb92c1ee8236409321147b253334155849d3","_number":1073,"virtual_id_number":1073,"owner":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-03 03:56:20.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-03 03:56:20.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-03 03:56:20.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"da84f0a897001c83ebbeaf9d962662f2f2b9bfc7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-03 03:56:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3ffb6da552b53affe8e50409574819608bfcaf34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-04 10:07:59.000000000","message":"Patch Set 2: Patch Set 1 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000006\u003e","accounts_in_message":[{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}],"_revision_number":2},{"id":"cfd4a7090105d6964c5483a7f087bd5c9ddbc663","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-09 08:57:04.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"08c11cf8596ee82c17fc744696020544b569041d","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-07-14 13:00:09.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ee61bb92c1ee8236409321147b253334155849d3","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-14 16:18:26.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"4848df2fb295740a7fb5a5b44f1baaeeb43307cb","revisions":{"bb9961278690e6bccc6f5d83a0e6cbdf15b62521":{"kind":"REWORK","_number":1,"created":"2025-07-03 03:56:20.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/73/1073/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/1073/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1 \u0026\u0026 git checkout -b change-1073 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"408f0db807e15b149d2b3d223060f8f9b4b0c2f3","subject":"dns: create NRPT registry key if it doesn\u0027t exist"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-27 18:24:53.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 03:52:48.000000000","tz":120},"subject":"prevent search domain races with macOS dns-updown","message":"prevent search domain races with macOS dns-updown\n\nWhen connections go up and down there are situations where search\ndomains of a split DNS connection are either lost, or survive the\nlifetime of the connction. This can happen when there is also a\nconnection that modifies the global DNS setting. When it backs-up the\nglobal settings before modifying them, or when it restores the backup,\nthe search domains could contain or miss VPN domains from other\nconnections, leading to misconfiguration.\n\nThe fix is to also update the backed-up search domains when a split DNS\nconnection comes up or goes down. That way the backup is always up to\ndate and restoring it will keep the global search domains as expected.\n\nChange-Id: Ide2cddad193c636eb440c9752751176dae0a6897\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"bc7d50362b1bc8bada9c8d3c351f2d6b35e97b02":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-04 10:07:59.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/73/1073/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/1073/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2 \u0026\u0026 git checkout -b change-1073 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c18a995d0e6752575299a750539acd5e35115846","subject":"Fix new doxygen warnings about using @return in void functions"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-27 18:24:53.000000000","tz":120},"committer":{"name":"d12fk","email":"heiko@openvpn.net","date":"2025-07-04 10:07:59.000000000","tz":0},"subject":"prevent search domain races with macOS dns-updown","message":"prevent search domain races with macOS dns-updown\n\nWhen connections go up and down there are situations where search\ndomains of a split DNS connection are either lost, or survive the\nlifetime of the connction. This can happen when there is also a\nconnection that modifies the global DNS setting. When it backs-up the\nglobal settings before modifying them, or when it restores the backup,\nthe search domains could contain or miss VPN domains from other\nconnections, leading to misconfiguration.\n\nThe fix is to also update the backed-up search domains when a split DNS\nconnection comes up or goes down. That way the backup is always up to\ndate and restoring it will keep the global search domains as expected.\n\nChange-Id: Ide2cddad193c636eb440c9752751176dae0a6897\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"f25a309f0183a7af9b14828fb3f06680c7ea7311":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-07-09 08:57:04.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/73/1073/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/1073/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3 \u0026\u0026 git checkout -b change-1073 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4dc57d923d23bdc73c7c24a9851c9137f2097d8c","subject":"dns: do not run updown scripts with lwipovpn"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-06-27 18:24:53.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-09 08:50:32.000000000","tz":120},"subject":"prevent search domain races with macOS dns-updown","message":"prevent search domain races with macOS dns-updown\n\nWhen connections go up and down there are situations where search\ndomains of a split DNS connection are either lost, or survive the\nlifetime of the connction. This can happen when there is also a\nconnection that modifies the global DNS setting. When it backs-up the\nglobal settings before modifying them, or when it restores the backup,\nthe search domains could contain or miss VPN domains from other\nconnections, leading to misconfiguration.\n\nThe fix is to also update the backed-up search domains when a split DNS\nconnection comes up or goes down. That way the backup is always up to\ndate and restoring it will keep the global search domains as expected.\n\nChange-Id: Ide2cddad193c636eb440c9752751176dae0a6897\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"4848df2fb295740a7fb5a5b44f1baaeeb43307cb":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-07-14 16:18:26.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/73/1073/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/73/1073/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4 \u0026\u0026 git checkout -b change-1073 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/73/1073/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fcd8f0f9fccdba02ed643dee5df7422ba36ced12","subject":"Fix compiler warning in reliable.c with --disable-debug"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-14 16:08:21.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-14 16:15:11.000000000","tz":120},"subject":"prevent search domain races with macOS dns-updown","message":"prevent search domain races with macOS dns-updown\n\nWhen connections go up and down there are situations where search\ndomains of a split DNS connection are either lost, or survive the\nlifetime of the connction. This can happen when there is also a\nconnection that modifies the global DNS setting. When it backs-up the\nglobal settings before modifying them, or when it restores the backup,\nthe search domains could contain or miss VPN domains from other\nconnections, leading to misconfiguration.\n\nThe fix is to also update the backed-up search domains when a split DNS\nconnection comes up or goes down. That way the backup is always up to\ndate and restoring it will keep the global search domains as expected.\n\nChange-Id: Ide2cddad193c636eb440c9752751176dae0a6897\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20250714160903.7479-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32127.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
