)]}'
{"id":"openvpn~1075","triplet_id":"openvpn~master~I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2025-07-15 14:02:44.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-15 14:02:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-09 13:22:54.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":["mailsubmitted"],"change_id":"I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67","subject":"mac dns: compare servers before restoring backup","status":"MERGED","created":"2025-07-03 03:56:20.000000000","updated":"2025-07-15 14:02:44.000000000","submitted":"2025-07-15 14:02:44.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1075","meta_rev_id":"37f4a196cbab5bd98b76878583bf2ce543d185e6","_number":1075,"virtual_id_number":1075,"owner":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-03 03:56:21.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-03 03:56:21.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-03 03:56:21.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"e2c1ada45c72b4521fd3b9aa498865636b582a7a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-03 03:56:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db8d9f0a499b8dade7a8cc688ac36e911a8249b1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-04 10:07:59.000000000","message":"Patch Set 2: Patch Set 1 was rebased on behalf of \u003cGERRIT_ACCOUNT_1000006\u003e","accounts_in_message":[{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}],"_revision_number":2},{"id":"84e7529be8835e3e0cb80614f875174b1cb9f624","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-07 16:54:05.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3b194464e50eaf027657a30df9cd989994afe304","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-08 14:21:08.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f52df899f2f186b76c85031d0c0ee51a0acb25fb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-09 08:57:04.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR **changekind:TRIVIAL_REBASE** OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"571bd216fda007d4ae86122cc99f470f9ca6040a","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-09 10:08:40.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f55567c8740fa03478329d4975ec842539ce06c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-09 10:25:02.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"d4ba55cd9ee110b59b82ca667824075250c10944","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-09 10:25:23.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"6d04f0181dafbdc0d68bee7e0743e48f502ff021","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-09 13:22:54.000000000","message":"Patch Set 4: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"76bfc979dff4b543ca143c988b0ee54f1d34eda4","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-11 15:22:36.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"2c4cc64c234e3f00f9222e4e3fd124c7146aba7f","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-11 15:23:21.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"37f4a196cbab5bd98b76878583bf2ce543d185e6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-15 14:02:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"c1f44ea8a24754139beee8758c15657fe367cbb0","revisions":{"562ddcf4e605e2dcbf04ce47ffc8c2813394c19f":{"kind":"REWORK","_number":1,"created":"2025-07-03 03:56:20.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/75/1075/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1075/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1 \u0026\u0026 git checkout -b change-1075 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d60febdb56f6224fdd69891189ded082555bb107","subject":"move macOS dns-updown common code into functions"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 00:57:42.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 03:52:57.000000000","tz":120},"subject":"mac dns: compare servers before restoring backup","message":"mac dns: compare servers before restoring backup\n\nIn case anything changed the global DNS server addresses, while the\ntunnel was connected, do not restore the backup of the global DNS\nconfiguration we made when connecting. Doing so would likely change\nDNS to something unexpected. Instead just clear the backup and leave\na message in the log.\n\nChange-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"aaa63de8a6bc88611b8f866705a9169e8625dd92":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-04 10:07:59.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/75/1075/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1075/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2 \u0026\u0026 git checkout -b change-1075 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"68b6f7079be47e229d68d8e828ed67eb28a9d6c5","subject":"move macOS dns-updown common code into functions"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 00:57:42.000000000","tz":120},"committer":{"name":"d12fk","email":"heiko@openvpn.net","date":"2025-07-04 10:07:59.000000000","tz":0},"subject":"mac dns: compare servers before restoring backup","message":"mac dns: compare servers before restoring backup\n\nIn case anything changed the global DNS server addresses, while the\ntunnel was connected, do not restore the backup of the global DNS\nconfiguration we made when connecting. Doing so would likely change\nDNS to something unexpected. Instead just clear the backup and leave\na message in the log.\n\nChange-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master","description":"Rebase"},"409423706796106867205b37c81185a102448176":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-07-09 08:57:04.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/75/1075/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1075/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3 \u0026\u0026 git checkout -b change-1075 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ece5e094fd8ed5cec2412445f2f6ac7f1b997bac","subject":"move macOS dns-updown common code into functions"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 00:57:42.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-09 08:50:32.000000000","tz":120},"subject":"mac dns: compare servers before restoring backup","message":"mac dns: compare servers before restoring backup\n\nIn case anything changed the global DNS server addresses, while the\ntunnel was connected, do not restore the backup of the global DNS\nconfiguration we made when connecting. Doing so would likely change\nDNS to something unexpected. Instead just clear the backup and leave\na message in the log.\n\nChange-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"7b31a281a5c7c29192a30c31fd217f34333fce77":{"kind":"REWORK","_number":4,"created":"2025-07-09 10:25:02.000000000","uploader":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"ref":"refs/changes/75/1075/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1075/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4 \u0026\u0026 git checkout -b change-1075 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ece5e094fd8ed5cec2412445f2f6ac7f1b997bac","subject":"move macOS dns-updown common code into functions"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-03 00:57:42.000000000","tz":120},"committer":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-09 10:24:45.000000000","tz":120},"subject":"mac dns: compare servers before restoring backup","message":"mac dns: compare servers before restoring backup\n\nIn case anything changed the global DNS server addresses, while the\ntunnel was connected, do not restore the backup of the global DNS\nconfiguration we made when connecting. Doing so would likely change\nDNS to something unexpected. Instead just clear the backup and leave\na message in the log.\n\nChange-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\n"},"branch":"refs/heads/master"},"c1f44ea8a24754139beee8758c15657fe367cbb0":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-07-15 14:02:44.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/75/1075/5","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/75/1075/5","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5 \u0026\u0026 git checkout -b change-1075 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/75/1075/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5f34a7a0362ac228787b6d9d0968318132c78276","subject":"Cleanup/simplify mbed TLS related define from autoconf"}],"author":{"name":"Heiko Hund","email":"heiko@ist.eigentlich.net","date":"2025-07-11 15:23:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-15 13:59:34.000000000","tz":120},"subject":"mac dns: compare servers before restoring backup","message":"mac dns: compare servers before restoring backup\n\nIn case anything changed the global DNS server addresses, while the\ntunnel was connected, do not restore the backup of the global DNS\nconfiguration we made when connecting. Doing so would likely change\nDNS to something unexpected. Instead just clear the backup and leave\na message in the log.\n\nChange-Id: I1aabd62e60dd18408a57baccbb0f4ebd6d2f8d67\nSigned-off-by: Heiko Hund \u003cheiko@ist.eigentlich.net\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250711152309.286177-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32110.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
