)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"43f5a57500bdc4aad48a9b409d225d6770a81dd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34df5947_5b5409c5","updated":"2025-07-07 14:05:56.000000000","message":"The check for NULL after already accessing it, looks very fishy.","commit_id":"94f856c06f709eee24788f4e484cce6e426ef010"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ca770d78942120e7b6c0f9d108b51b12f49ac5f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61ae7ade_e5d4fd0b","updated":"2025-07-18 18:55:36.000000000","message":"Interesting.  I can not trigger the ASSERT() with \"master\" with the sequence described\n\n- start multisocket master\n- connect UDP client on peer id 0\n- connect TCP client on peer id 1\n- restart the server\n- TCP client reconnects, now peer id 0\n- UDP client \"sends packets with peer id 0\"\n\nit does some other weird things here, namely killing the TCP #0 instance on each UDP packet from #0 - but this is also fixed with this patch (it will just ignore udp #0 packets).","commit_id":"53afc9d93ba2c42162ed5dd634127c9a60fa140a"}],"src/openvpn/mudp.c":[{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"43f5a57500bdc4aad48a9b409d225d6770a81dd5","unresolved":true,"context_lines":[{"line_number":222,"context_line":"                {"},{"line_number":223,"context_line":"                    mi \u003d m-\u003einstances[peer_id];"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"                    if (mi)"},{"line_number":226,"context_line":"                    {"},{"line_number":227,"context_line":"                        *floated \u003d !link_socket_actual_match(\u0026mi-\u003econtext.c2.from, \u0026m-\u003etop.c2.from);"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5cf6ed60_e43a0b88","line":225,"updated":"2025-07-07 14:05:56.000000000","message":"This looks fishy. This basically can never fail. Since we already access `m-\u003einstances[peer_id]` in the if condition, this would have already segfaulted before even getting to this if (mi) check","commit_id":"94f856c06f709eee24788f4e484cce6e426ef010"},{"author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"change_message_id":"b9386348fb17ccbfa371ae3f7063a8dc6c06e02a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                {"},{"line_number":223,"context_line":"                    mi \u003d m-\u003einstances[peer_id];"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"                    if (mi)"},{"line_number":226,"context_line":"                    {"},{"line_number":227,"context_line":"                        *floated \u003d !link_socket_actual_match(\u0026mi-\u003econtext.c2.from, \u0026m-\u003etop.c2.from);"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5867a758_0966ea4a","line":225,"in_reply_to":"5cf6ed60_e43a0b88","updated":"2025-07-07 15:05:05.000000000","message":"Done","commit_id":"94f856c06f709eee24788f4e484cce6e426ef010"}]}
