)]}'
{"id":"openvpn~1078","triplet_id":"openvpn~master~Iecbbcf32c0059f2b16a05333b3794599060d7d6a","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-18 19:07:23.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"last_update":"2025-07-18 19:07:23.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-18 19:07:23.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iecbbcf32c0059f2b16a05333b3794599060d7d6a","subject":"Multi-socket: Fix assert triggered by stale peer-id reuse","status":"MERGED","created":"2025-07-07 12:57:00.000000000","updated":"2025-07-18 19:07:23.000000000","submitted":"2025-07-18 19:07:23.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1078","meta_rev_id":"8ef61666058cb1204cdb6e75bd4ee40b62013f8c","_number":1078,"virtual_id_number":1078,"owner":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-07 12:57:00.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-07 12:57:00.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-07 12:57:00.000000000","updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"real_updated_by":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-18 18:55:36.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"0e162e3d467af91fa88bc4092d0bb7b3d1d47cd9","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-07-07 12:57:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43f5a57500bdc4aad48a9b409d225d6770a81dd5","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-07-07 14:05:56.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"69921454734f14153639bc4e7ecd6f8f0ca4018e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-07-07 15:04:45.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b9386348fb17ccbfa371ae3f7063a8dc6c06e02a","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-07-07 15:05:05.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3e60618a04b923e9a8c9cafa36b611ccd04a13b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"date":"2025-07-07 16:04:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ca770d78942120e7b6c0f9d108b51b12f49ac5f8","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-18 18:55:36.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8ef61666058cb1204cdb6e75bd4ee40b62013f8c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-18 19:07:23.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"fd93e4ad8245e1fd9530a6c1f89cb66c047f3abe","revisions":{"94f856c06f709eee24788f4e484cce6e426ef010":{"kind":"REWORK","_number":1,"created":"2025-07-07 12:57:00.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/78/1078/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/1078/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1 \u0026\u0026 git checkout -b change-1078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c18a995d0e6752575299a750539acd5e35115846","subject":"Fix new doxygen warnings about using @return in void functions"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 11:33:12.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 12:56:35.000000000","tz":120},"subject":"Multi-socket: Fix assert triggered by stale peer-id reuse","message":"Multi-socket: Fix assert triggered by stale peer-id reuse\n\nFixed a bug where clients using different transport\nprotocols (UDP, TCP) could interfere with each other\nafter a server restart.\nThe issue occurred when a client reused a previously\nassigned peer-id that was now associated with a\ndifferent client using a different transport protocol.\n\nFor example, a UDP client could send packets with a\npeer-id now assigned to a TCP client, which lacks\na valid context-\u003ec2.from which is filled by the\nrecvfrom(), causing an assert to be triggered.\n\nA protocol check has been added to prevent packets\nfrom different protocols from hijacking active\nconnections.\n\nGithub: #773\n\nChange-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"4d01388107020f8e7eec9cb4d99db4c47e10fb2d":{"kind":"REWORK","_number":2,"created":"2025-07-07 15:04:45.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/78/1078/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/1078/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2 \u0026\u0026 git checkout -b change-1078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b133cce839f46902c9df32943646c3289c34889","subject":"Added PQE to WolfSSL"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 11:33:12.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 14:48:58.000000000","tz":120},"subject":"Multi-socket: Fix assert triggered by stale peer-id reuse","message":"Multi-socket: Fix assert triggered by stale peer-id reuse\n\nFixed a bug where clients using different transport\nprotocols (UDP, TCP) could interfere with each other\nafter a server restart.\nThe issue occurred when a client reused a previously\nassigned peer-id that was now associated with a\ndifferent client using a different transport protocol.\n\nFor example, a UDP client could send packets with a\npeer-id now assigned to a TCP client, which lacks\na valid context-\u003ec2.from which is filled by the\nrecvfrom(), causing an assert to be triggered.\n\nA protocol check has been added to prevent packets\nfrom different protocols from hijacking active\nconnections.\n\nGithub: #773\n\nChange-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"53afc9d93ba2c42162ed5dd634127c9a60fa140a":{"kind":"REWORK","_number":3,"created":"2025-07-07 16:04:30.000000000","uploader":{"_account_id":1000034,"name":"Gianmarco De Gregori","display_name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","username":"its_Giaan"},"ref":"refs/changes/78/1078/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/1078/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3 \u0026\u0026 git checkout -b change-1078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1b133cce839f46902c9df32943646c3289c34889","subject":"Added PQE to WolfSSL"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 11:33:12.000000000","tz":120},"committer":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-07 16:03:50.000000000","tz":120},"subject":"Multi-socket: Fix assert triggered by stale peer-id reuse","message":"Multi-socket: Fix assert triggered by stale peer-id reuse\n\nFixed a bug where clients using different transport\nprotocols (UDP, TCP) could interfere with each other\nafter a server restart.\nThe issue occurred when a client reused a previously\nassigned peer-id that was now associated with a\ndifferent client using a different transport protocol.\n\nFor example, a UDP client could send packets with a\npeer-id now assigned to a TCP client, which lacks\na valid context-\u003ec2.from which is filled by the\nrecvfrom(), causing an assert to be triggered.\n\nA protocol check has been added to prevent packets\nfrom different protocols from hijacking active\nconnections.\n\nGithub: #773\n\nChange-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"fd93e4ad8245e1fd9530a6c1f89cb66c047f3abe":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-07-18 19:07:23.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/78/1078/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/78/1078/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4 \u0026\u0026 git checkout -b change-1078 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/78/1078/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cb8a0f6f5741d102b667d98370ab4d553503d0b5","subject":"dco: Add support for float notifications"}],"author":{"name":"Gianmarco De Gregori","email":"gianmarco@mandelbit.com","date":"2025-07-18 18:55:53.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-18 19:00:53.000000000","tz":120},"subject":"Multi-socket: Fix assert triggered by stale peer-id reuse","message":"Multi-socket: Fix assert triggered by stale peer-id reuse\n\nFixed a bug where clients using different transport\nprotocols (UDP, TCP) could interfere with each other\nafter a server restart.\nThe issue occurred when a client reused a previously\nassigned peer-id that was now associated with a\ndifferent client using a different transport protocol.\n\nFor example, a UDP client could send packets with a\npeer-id now assigned to a TCP client, which lacks\na valid context-\u003ec2.from which is filled by the\nrecvfrom(), causing an assert to be triggered.\n\nA protocol check has been added to prevent packets\nfrom different protocols from hijacking active\nconnections.\n\nGithub: OpenVPN/openvpn#773\n\nChange-Id: Iecbbcf32c0059f2b16a05333b3794599060d7d6a\nSigned-off-by: Gianmarco De Gregori \u003cgianmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250718185559.4515-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32220.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
