)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"580b24ccb47291969f22acf1f48f77d058bc4b73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cf950de5_33d885d5","updated":"2025-07-09 12:40:12.000000000","message":"Can we include the GHA update to 3.6.4 in this patch, please?","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"cd8e65f5e8c415ac419d359a0742003cfcfbd568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c01c87ea_86202755","updated":"2025-07-09 11:57:49.000000000","message":"Github Actions run: https://github.com/schwabe/openvpn/actions/runs/16168579847/job/45636215699","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"09f283eccf30de74e429aba56e0f02b0bb5336c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a3c999c_be924851","in_reply_to":"2695d00e_477ebbf9","updated":"2025-07-14 19:36:59.000000000","message":"Done","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"a9584ee51d8e6704316e38335fd2ee8788e46848","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fff3a0bc_9e223469","in_reply_to":"cf950de5_33d885d5","updated":"2025-07-09 14:34:13.000000000","message":"Why should we include that? The fix is also for older version as we compile in functions that are not used. So it didn\u0027t feel like that is strictly tied to a specific version.","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"ffc3cafd062a2176b019e0f8778c734ab28c3c42","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2695d00e_477ebbf9","in_reply_to":"fff3a0bc_9e223469","updated":"2025-07-09 14:42:10.000000000","message":"Okay, I will put it in #1079 and rebase that on top of your change","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"8f21ff4f91e2113a0d13fbb1cc84d692581301a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"00db13d1_31946af8","updated":"2025-07-14 13:54:03.000000000","message":"So, I\u0027m still a bit confused about this twisty maze, but I can confirm that it compiles and connects to a \"master\" server correctly with 2.82.3 and 3.6.3 (both TLS 1.2 and tls-ekm) and 3.6.4 (TLS 1.3).\n\nI would prefer if someone else could +2 the code and build system changes.","commit_id":"5b8690779e95aa5762b4dd76897607f2620ee02a"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"5aaebb50fc77d32b51c91f7ef73290571f283aa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d20a82d7_9eb337ba","updated":"2025-07-15 06:20:54.000000000","message":"passes compile tests and \"openvpn connect to git master server\" for 2.82.3, 3.6.3 and 3.6.4 - the first two with TLS1.2 and tls-ekm, the third one with TLS1.3","commit_id":"0bc58130e5b13e61a1ef135b5bc2ca0a5db8a885"}],"configure.ac":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"7101a9d1073c52c9bbdd674d1ae4b35595b00c7c","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"\t\t[AC_MSG_ERROR([mbed TLS version \u003e\u003d 2.0.0 or \u003e\u003d 3.2.1 required])]"},{"line_number":1039,"context_line":"\t)"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"\tAC_CHECK_HEADER(psa/crypto.h)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1044,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"00ff5884_aeb7bbcd","line":1041,"updated":"2025-07-15 09:28:34.000000000","message":"Needs to be AC_CHECK_HEADERS, otherwise HAVE_MBEDTLS_PSA_CRYPTO_H is never defined.\n\nBut this passed everywhere. So does this mean this whole check is useless?","commit_id":"0bc58130e5b13e61a1ef135b5bc2ca0a5db8a885"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"3d776f4feac0728cfe399c04a431e840686ee8fc","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"\t\t[AC_MSG_ERROR([mbed TLS version \u003e\u003d 2.0.0 or \u003e\u003d 3.2.1 required])]"},{"line_number":1039,"context_line":"\t)"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"\tAC_CHECK_HEADER(psa/crypto.h)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1044,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"327557b0_9308dcaf","line":1041,"in_reply_to":"00ff5884_aeb7bbcd","updated":"2025-07-15 10:42:21.000000000","message":"*sigh* I hate autconf. Might be fine to remove it but I am not in the mood today to try this in this patch and then figure out, it wasn\u0027t. Let\u0027s do that in some follow up patch.","commit_id":"0bc58130e5b13e61a1ef135b5bc2ca0a5db8a885"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"13415b5d5115a0bd06f3ea561ffa7c931baf99ce","unresolved":false,"context_lines":[{"line_number":1038,"context_line":"\t\t[AC_MSG_ERROR([mbed TLS version \u003e\u003d 2.0.0 or \u003e\u003d 3.2.1 required])]"},{"line_number":1039,"context_line":"\t)"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"\tAC_CHECK_HEADER(psa/crypto.h)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1044,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3278c867_05e6ee0b","line":1041,"in_reply_to":"136d3b26_e9bdddae","updated":"2025-07-15 12:24:28.000000000","message":"Done","commit_id":"0bc58130e5b13e61a1ef135b5bc2ca0a5db8a885"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"5d24c8861e68645a0102d8cb3005d259d9522374","unresolved":true,"context_lines":[{"line_number":1038,"context_line":"\t\t[AC_MSG_ERROR([mbed TLS version \u003e\u003d 2.0.0 or \u003e\u003d 3.2.1 required])]"},{"line_number":1039,"context_line":"\t)"},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"\tAC_CHECK_HEADER(psa/crypto.h)"},{"line_number":1042,"context_line":""},{"line_number":1043,"context_line":"\tAC_CHECK_FUNCS([mbedtls_ssl_tls_prf mbedtls_ssl_conf_export_keys_ext_cb])"},{"line_number":1044,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"136d3b26_e9bdddae","line":1041,"in_reply_to":"327557b0_9308dcaf","updated":"2025-07-15 11:11:01.000000000","message":"Sorry, this is still not correct. Now it defines HAVE_PSA_CRYPTO_H, not HAVE_MBEDTLS_PSA_CRYPTO_H %)","commit_id":"0bc58130e5b13e61a1ef135b5bc2ca0a5db8a885"}],"src/openvpn/mbedtls_compat.h":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"09f283eccf30de74e429aba56e0f02b0bb5336c1","unresolved":true,"context_lines":[{"line_number":48,"context_line":"#include \u003cmbedtls/version.h\u003e"},{"line_number":49,"context_line":"#include \u003cmbedtls/x509_crt.h\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"#ifdef HAVE_MBEDTLS_PSA_CRYPTO_H"},{"line_number":52,"context_line":"    #include \u003cpsa/crypto.h\u003e"},{"line_number":53,"context_line":"#endif"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"a66a43b0_418c29b4","line":51,"updated":"2025-07-14 19:36:59.000000000","message":"This is wrong, we always define it, just to 0","commit_id":"5b8690779e95aa5762b4dd76897607f2620ee02a"},{"author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"ff1b65d5f378bd4aba601f7841d3a618d944a4e2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"#include \u003cmbedtls/version.h\u003e"},{"line_number":49,"context_line":"#include \u003cmbedtls/x509_crt.h\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"#ifdef HAVE_MBEDTLS_PSA_CRYPTO_H"},{"line_number":52,"context_line":"    #include \u003cpsa/crypto.h\u003e"},{"line_number":53,"context_line":"#endif"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":6,"id":"33d2c36f_3dc99cd6","line":51,"in_reply_to":"a66a43b0_418c29b4","updated":"2025-07-14 22:00:08.000000000","message":"Done","commit_id":"5b8690779e95aa5762b4dd76897607f2620ee02a"}],"src/openvpn/ssl_mbedtls.c":[{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"efe0d9a1e5b6d512c0d284af5e9a092f73946d74","unresolved":true,"context_lines":[{"line_number":174,"context_line":"    return ctx-\u003einitialised;"},{"line_number":175,"context_line":"}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"#if HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB \u0026\u0026 !defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT)"},{"line_number":178,"context_line":"/*"},{"line_number":179,"context_line":" * Key export callback for older versions of mbed TLS, to be used with"},{"line_number":180,"context_line":" * mbedtls_ssl_conf_export_keys_ext_cb(). It is called with the master"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"eaa93c85_55785638","line":177,"updated":"2025-07-09 15:02:49.000000000","message":"Change makes sense, but now every clause of the #if .. #elif .. #elif has a `!defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT)`. So I think it would be easier to understand wrapping the whole thing into a separate `#if !defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT`.","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"},{"author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"95a6650b0344da56768d26d868ad00a9535de68a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    return ctx-\u003einitialised;"},{"line_number":175,"context_line":"}"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"#if HAVE_MBEDTLS_SSL_CONF_EXPORT_KEYS_EXT_CB \u0026\u0026 !defined(MBEDTLS_SSL_KEYING_MATERIAL_EXPORT)"},{"line_number":178,"context_line":"/*"},{"line_number":179,"context_line":" * Key export callback for older versions of mbed TLS, to be used with"},{"line_number":180,"context_line":" * mbedtls_ssl_conf_export_keys_ext_cb(). It is called with the master"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"7552178f_39f98b2e","line":177,"in_reply_to":"eaa93c85_55785638","updated":"2025-07-10 11:14:48.000000000","message":"Done","commit_id":"56dd0572e1d86f1f15e392b020409d6d57a51d76"}]}
