)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"3bf17465e3e4c86e2a1c3f53daa01492fab7097a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"977e9817_2d757b7c","updated":"2025-07-15 14:23:00.000000000","message":"looks good to me","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"ba9719e25d218933396b9e4cea265ac714091f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c8024d00_a3950aa5","updated":"2025-07-17 15:54:28.000000000","message":"*b00m*\n\nso this is the testbed: ununtu 20.04 server with backported float notification patch, commit 31aedd7fb plus this patch.\n\none server instance, with 2 UDP sockets (one udp6/dual-stack, one udp4 only).  Client connecting to the UDP4 socket (so v6 mapped is not relevant).\n\nServer has --reneg-sec 60, and in between renegotiations the client is made to roam between LAN and WiFi (by unplugging and replugging the LAN cable).  It floats quite happily, and then explodes - it\u0027s something with timing, float, and server-triggered renegotiation, though I do not really know what sequence of things I need.  `peer-id 2` is the floating client, `peer-id 1` is just sticking around.\n\n```\n2025-07-17 17:45:32 us\u003d32787 freebsd-74-amd64/udp6:194.97.140.3:61704 peer-id\u003d1 Control Channel: TLSv1.2, cipher TLS-ECDHE-RSA-WITH-AES-256-GCM-SHA384, 2048 bit key\n2025-07-17 17:45:32 us\u003d32932 freebsd-74-amd64/udp6:194.97.140.3:61704 peer-id\u003d1 dco_install_key: peer_id\u003d1 keyid\u003d6, currently 1 keys installed\n2025-07-17 17:45:32 us\u003d32963 freebsd-74-amd64/udp6:194.97.140.3:61704 peer-id\u003d1 dco_new_key: slot 1, key-id 6, peer-id 1, cipher AES-256-GCM\n2025-07-17 17:45:32 us\u003d658862 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 Swapping primary and secondary keys to primary-id\u003d6 secondary-id\u003d5\n2025-07-17 17:45:32 us\u003d658933 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 dco_swap_keys: peer-id 2\n2025-07-17 17:45:59 us\u003d350653 dco_do_read\n2025-07-17 17:45:59 us\u003d350790 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5501, peer-id 2, address: [AF_INET]193.149.48.173:63385\n2025-07-17 17:45:59 us\u003d350937 peer 2 (cron2-freebsd-tc-amd64) floated from udp4:193.149.48.172:63385 to [AF_INET6]::ffff:193.149.48.173:63385 (via ::ffff:195.30.8.84%ens160)\n2025-07-17 17:46:02 us\u003d32434 cron2-freebsd-tc-amd64/udp6:193.149.48.173:63385 peer-id\u003d2 TLS: soft reset sec\u003d60/59 bytes\u003d0/-1 pkts\u003d0/0 aead_limit_send\u003d0/60129542137 aead_limit_recv\u003d0/60129542137\n2025-07-17 17:46:02 us\u003d32639 cron2-freebsd-tc-amd64/udp6:193.149.48.173:63385 peer-id\u003d2 dco_del_key: peer-id 2, slot 1\n2025-07-17 17:46:02 us\u003d32911 cron2-freebsd-tc-amd64/udp6:193.149.48.173:63385 peer-id\u003d2 UDPv4 WRITE [54] to [AF_INET6]::ffff:193.149.48.173:63385 (via ::ffff:195.30.8.84%ens160): P_CONTROL_SOFT_RESET_V1 kid\u003d7 [ ] pid\u003d12648 DATA len\u003d40\n2025-07-17 17:46:02 us\u003d32981 cron2-freebsd-tc-amd64/udp6:193.149.48.173:63385 peer-id\u003d2 write UDPv4 []: Address family not supported by protocol (fd\u003d7,code\u003d97)\n2025-07-17 17:46:02 us\u003d352420 dco_do_read\n2025-07-17 17:46:02 us\u003d352549 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5501, peer-id 2, address: [AF_INET]193.149.48.172:63385\n2025-07-17 17:46:02 us\u003d352705 peer 2 (cron2-freebsd-tc-amd64) floated from udp6:193.149.48.173:63385 to [AF_INET6]::ffff:193.149.48.172:63385 (via ::ffff:195.30.8.84%ens160)\n2025-07-17 17:46:02 us\u003d529069 freebsd-74-amd64/udp6:194.97.140.3:61704 peer-id\u003d1 Swapping primary and secondary keys to primary-id\u003d6 secondary-id\u003d5\n2025-07-17 17:46:02 us\u003d529153 freebsd-74-amd64/udp6:194.97.140.3:61704 peer-id\u003d1 dco_swap_keys: peer-id 1\n2025-07-17 17:46:04 us\u003d286241 cron2-freebsd-tc-amd64/udp6:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [54] to [AF_INET6]::ffff:193.149.48.172:63385 (via ::ffff:195.30.8.84%ens160): P_CONTROL_SOFT_RESET_V1 kid\u003d7 [ ] pid\u003d12904 DATA len\u003d40\n2025-07-17 17:46:04 us\u003d286325 cron2-freebsd-tc-amd64/udp6:193.149.48.172:63385 peer-id\u003d2 write UDPv4 []: Address family not supported by protocol (fd\u003d7,code\u003d97)\n2025-07-17 17:46:05 us\u003d364294 dco_get_peer_stats_multi\n2025-07-17 17:46:05 us\u003d364768 dco_parse_peer_multi: parsing message...\n2025-07-17 17:46:05 us\u003d364822 dco_update_peer_stat: no link RX bytes provided in reply for peer 2\n2025-07-17 17:46:05 us\u003d364854 dco_update_peer_stat: no link TX bytes provided in reply for peer 2\n2025-07-17 17:46:05 us\u003d364913 dco_update_peer_stat: no VPN RX bytes provided in reply for peer 2\n2025-07-17 17:46:05 us\u003d364931 dco_update_peer_stat: no VPN TX bytes provided in reply for peer 2\n2025-07-17 17:46:05 us\u003d364994 dco_parse_peer_multi: parsing message...\n2025-07-17 17:46:05 us\u003d365028 dco_update_peer_stat / dco_read_bytes: 1648\n2025-07-17 17:46:05 us\u003d365057 dco_update_peer_stat / dco_write_bytes: 1440\n2025-07-17 17:46:05 us\u003d365103 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-17 17:46:05 us\u003d365129 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-17 17:46:05 us\u003d365145 dco_parse_peer_multi: parsing message...\n2025-07-17 17:46:05 us\u003d365180 dco_update_peer_stat / dco_read_bytes: 53648\n2025-07-17 17:46:05 us\u003d365208 dco_update_peer_stat / dco_write_bytes: 53248\n2025-07-17 17:46:05 us\u003d365269 dco_update_peer_stat / tun_read_bytes: 43264\n2025-07-17 17:46:05 us\u003d365304 dco_update_peer_stat / tun_write_bytes: 43264\n2025-07-17 17:46:05 us\u003d366195 dco_do_read\n2025-07-17 17:46:05 us\u003d366301 dco_do_read: netlink reports error (-4): Try again\n2025-07-17 17:46:08 us\u003d370284 dco_do_read\n2025-07-17 17:46:08 us\u003d370355 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5501, peer-id 2, address: [AF_INET]193.149.48.172:63385\n2025-07-17 17:46:08 us\u003d370416 closing instance cron2-freebsd-tc-amd64/udp6:193.149.48.172:63385 peer-id\u003d2\n2025-07-17 17:46:08 us\u003d370469 dco_get_peer_stats_multi\n2025-07-17 17:46:08 us\u003d370666 dco_parse_peer_multi: parsing message...\n2025-07-17 17:46:08 us\u003d370811 dco_update_peer_stat / dco_read_bytes: 1648\n2025-07-17 17:46:08 us\u003d370856 dco_update_peer_stat / dco_write_bytes: 1440\n2025-07-17 17:46:08 us\u003d370887 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-17 17:46:08 us\u003d370918 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-17 17:46:08 us\u003d371212 dco_parse_peer_multi: parsing message...\n2025-07-17 17:46:08 us\u003d371249 dco_parse_peer_multi: cannot store DCO stats for peer 2\n2025-07-17 17:46:08 us\u003d371410 register signal: SIGTERM (close_context)\n2025-07-17 17:46:08 us\u003d371534 dco_del_peer: peer-id 2\n```\n\n(why does it want to close peer 2?  so something went fishy already at this point)\n\n```\nProgram received signal SIGSEGV, Segmentation fault.\n0x00005555555989b3 in multi_process_float (m\u003dm@entry\u003d0x7fffffffbb90, mi\u003dmi@entry\u003d0x555555772a70, \n    sock\u003d0x5555556c7a20) at multi.c:3258\n3258        msg(D_MULTI_MEDIUM, \"peer %\" PRIu32 \" (%s) floated from %s to %s\",\n(gdb) where\n#0  0x00005555555989b3 in multi_process_float (m\u003dm@entry\u003d0x7fffffffbb90, mi\u003dmi@entry\u003d0x555555772a70, \n    sock\u003d0x5555556c7a20) at multi.c:3258\n#1  0x0000555555598f53 in multi_process_incoming_dco (m\u003dm@entry\u003d0x7fffffffbb90) at multi.c:3393\n#2  0x000055555559d7e0 in multi_io_process_io (m\u003dm@entry\u003d0x7fffffffbb90) at multi_io.c:534\n#3  0x000055555559c740 in tunnel_server_loop (multi\u003d0x7fffffffbb90) at multi.c:4287\n#4  tunnel_server (top\u003d0x7fffffffd0c0) at multi.c:4339\n#5  0x00005555555a1f29 in openvpn_main (argc\u003d5, argv\u003d0x7fffffffe598) at openvpn.c:318\n#6  0x00007ffff7d72083 in __libc_start_main (main\u003d0x55555555fb70 \u003cmain\u003e, argc\u003d5, argv\u003d0x7fffffffe598, \n    init\u003d\u003coptimized out\u003e, fini\u003d\u003coptimized out\u003e, rtld_fini\u003d\u003coptimized out\u003e, stack_end\u003d0x7fffffffe588)\n    at ../csu/libc-start.c:308\n#7  0x000055555555fbae in _start () at openvpn.c:395\n(gdb) list\n3253\n3254            msg(D_MULTI_MEDIUM, \"closing instance %s\", multi_instance_string(ex_mi, false, \u0026gc));\n3255            multi_close_instance(m, ex_mi, false);\n3256        }\n3257\n3258        msg(D_MULTI_MEDIUM, \"peer %\" PRIu32 \" (%s) floated from %s to %s\",\n3259            mi-\u003econtext.c2.tls_multi-\u003epeer_id,\n3260            tls_common_name(mi-\u003econtext.c2.tls_multi, false),\n3261            mroute_addr_print(\u0026mi-\u003ereal, \u0026gc),\n3262            print_link_socket_actual(\u0026m-\u003etop.c2.from, \u0026gc));\n(gdb) print mi-\u003econtext.c2.tls_multi\n$1 \u003d (struct tls_multi *) 0x0\n```\n\nthe kernel log around that time says\n\n```\nJul 17 17:46:01 ubuntu2004 kernel: [3570425.002983] tun7: peer 2 floated to 193.149.48.173:63385\nJul 17 17:46:01 ubuntu2004 kernel: [3570426.825096] tun7: sending keepalive to peer 1\nJul 17 17:46:01 ubuntu2004 kernel: [3570426.825119] tun7: scheduling keepalive work: now\u003d1752767170 next_run\u003d1752767161 delta\u003d9\nJul 17 17:46:02 ubuntu2004 kernel: [3570427.685495] deleting key slot 1, key_id\u003d5\nJul 17 17:46:02 ubuntu2004 kernel: [3570428.004618] tun7: peer 2 floated to 193.149.48.172:63385\nJul 17 17:46:02 ubuntu2004 kernel: [3570428.182001] key swapped: (old primary) 5 \u003c-\u003e (new primary) 6\nJul 17 17:46:03 ubuntu2004 kernel: [3570429.235584] tun7: ping received from peer 1\nJul 17 17:46:08 ubuntu2004 kernel: [3570431.015784] tun7: peer 2 floated to 193.149.48.173:63385\nJul 17 17:46:08 ubuntu2004 kernel: [3570434.022364] tun7: peer 2 floated to 193.149.48.172:63385\nJul 17 17:46:08 ubuntu2004 kernel: [3570434.024151] tun7: del peer 2\nJul 17 17:46:08 ubuntu2004 kernel: [3570434.024169] tun7: deleting peer with id 2, reason 1\nJul 17 17:46:10 ubuntu2004 kernel: [3570436.040898] tun7: scheduling keepalive work: now\u003d1752767171 next_run\u003d1752767170 delta\u003d1\nJul 17 17:46:11 ubuntu2004 kernel: [3570437.064852] tun7: sending keepalive to peer 1\n```","commit_id":"873ed940b82458fbd11d5e82e9d63ab1ca27e1a2"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"7fe52a92aed0584b3b1e61c3f6ab74be5cf5077e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5f9c02b3_ac43c3dc","updated":"2025-07-17 16:02:30.000000000","message":"so here\u0027s the last successful TLS reneg, one minute earlier\n\n```\n2025-07-17 17:45:02 us\u003d482995 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 TLS: soft reset sec\u003d59/59 bytes\u003d0/-1 pkts\u003d0/0 aead_limit_send\u003d0/60129542137 aead_limit_recv\u003d0/60129542137\n2025-07-17 17:45:02 us\u003d483272 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 dco_del_key: peer-id 2, slot 1\n2025-07-17 17:45:02 us\u003d483585 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [54] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_SOFT_RESET_V1 kid\u003d6 [ ] pid\u003d10600 DATA len\u003d40\n2025-07-17 17:45:02 us\u003d490075 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [66] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_SOFT_RESET_V1 kid\u003d6 [ ] pid\u003d10600 DATA len\u003d52\n2025-07-17 17:45:02 us\u003d490260 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [62] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_ACK_V1 kid\u003d6 [ ] DATA len\u003d52\n2025-07-17 17:45:02 us\u003d495340 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [355] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d10856 DATA len\u003d341\n2025-07-17 17:45:02 us\u003d505576 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [1262] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d11112 DATA len\u003d1248\n2025-07-17 17:45:02 us\u003d505746 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [923] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d11368 DATA len\u003d909\n2025-07-17 17:45:02 us\u003d510213 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [66] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_ACK_V1 kid\u003d6 [ ] DATA len\u003d56\n2025-07-17 17:45:02 us\u003d519114 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [1262] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d11368 DATA len\u003d1248\n2025-07-17 17:45:02 us\u003d519243 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [70] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_ACK_V1 kid\u003d6 [ ] DATA len\u003d60\n2025-07-17 17:45:02 us\u003d519353 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [1262] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d11624 DATA len\u003d1248\n2025-07-17 17:45:02 us\u003d519471 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [74] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_ACK_V1 kid\u003d6 [ ] DATA len\u003d64\n2025-07-17 17:45:02 us\u003d519586 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [753] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d11880 DATA len\u003d739\n2025-07-17 17:45:02 us\u003d519991 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 VERIFY OK: depth\u003d1, C\u003dUS, ST\u003dCalifornia, L\u003dPleasanton, O\u003dOpenVPN community project, CN\u003dOpenVPN community project CA, emailAddress\u003dsamuli@openvpn.net\n2025-07-17 17:45:02 us\u003d520144 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 VERIFY OK: depth\u003d0, C\u003dDE, ST\u003dBavaria, L\u003dMunich, O\u003dOpenVPN community project, OU\u003dServer Testing, CN\u003dcron2-freebsd-tc-amd64, emailAddress\u003dgert@greenie.net\n2025-07-17 17:45:02 us\u003d525244 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [121] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d12136 DATA len\u003d107\n2025-07-17 17:45:02 us\u003d530446 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [525] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d12136 DATA len\u003d511\n2025-07-17 17:45:02 us\u003d530543 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_VER\u003d2.7_alpha2\n2025-07-17 17:45:02 us\u003d530583 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_PLAT\u003dmac\n2025-07-17 17:45:02 us\u003d530619 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_TCPNL\u003d1\n2025-07-17 17:45:02 us\u003d530646 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_MTU\u003d1600\n2025-07-17 17:45:02 us\u003d530666 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_NCP\u003d2\n2025-07-17 17:45:02 us\u003d530687 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_CIPHERS\u003dAES-256-GCM:AES-128-GCM:CHACHA20-POLY1305\n2025-07-17 17:45:02 us\u003d530705 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_PROTO\u003d3998\n2025-07-17 17:45:02 us\u003d530726 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_LZ4\u003d1\n2025-07-17 17:45:02 us\u003d530755 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_LZ4v2\u003d1\n2025-07-17 17:45:02 us\u003d530779 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_LZO\u003d1\n2025-07-17 17:45:02 us\u003d530801 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_COMP_STUB\u003d1\n2025-07-17 17:45:02 us\u003d530821 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 peer info: IV_COMP_STUBv2\u003d1\n2025-07-17 17:45:02 us\u003d530859 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 Note: \u0027compress migrate\u0027 detected remote peer with compression enabled.\n2025-07-17 17:45:02 us\u003d531008 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 WRITE [286] to [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_CONTROL_V1 kid\u003d6 [ ] pid\u003d12392 DATA len\u003d272\n2025-07-17 17:45:02 us\u003d535798 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 UDPv4 READ [78] from [AF_INET]193.149.48.172:63385 (via [AF_INET]195.30.8.84%ens160): P_ACK_V1 kid\u003d6 [ ] DATA len\u003d68\n2025-07-17 17:45:02 us\u003d535906 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 Control Channel: TLSv1.2, cipher TLS-ECDHE-RSA-WITH-CHACHA20-POLY1305-SHA256, 2048 bit key\n2025-07-17 17:45:02 us\u003d536025 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 dco_install_key: peer_id\u003d2 keyid\u003d6, currently 1 keys installed\n2025-07-17 17:45:02 us\u003d536058 cron2-freebsd-tc-amd64/udp4:193.149.48.172:63385 peer-id\u003d2 dco_new_key: slot 1, key-id 6, peer-id 2, cipher AES-256-GCM\n2025-07-17 17:45:05 us\u003d707606 dco_get_peer_stats_multi\n2025-07-17 17:45:05 us\u003d707964 dco_parse_peer_multi: parsing message...\n2025-07-17 17:45:05 us\u003d707999 dco_update_peer_stat / dco_read_bytes: 1408\n2025-07-17 17:45:05 us\u003d708017 dco_update_peer_stat / dco_write_bytes: 1200\n2025-07-17 17:45:05 us\u003d708032 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-17 17:45:05 us\u003d708051 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-17 17:45:05 us\u003d708071 dco_parse_peer_multi: parsing message...\n```","commit_id":"873ed940b82458fbd11d5e82e9d63ab1ca27e1a2"},{"author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"9afdbf7d69630eccf93b13884a448e626be06649","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0246029c_480e2079","updated":"2025-07-18 08:39:45.000000000","message":"So, it segfaulted again - which is a different bug than the AF_INET6 thing (which seems fixed).  Not sure how to trigger it yet... I had 2 sockets, and 3 clients this time (something stable on the udp6 socket with peer-id 0 + 1, and the floating client on the udp4 socket with peer-id 2).\n\nIt got confused again about \"something\", then tried to delete the peer, and segfaulted at the same place (race condition between userspace already having deleted half the peer info and then kernel sending up a message?)\n\nTrying to extract the interesting bits\n\n```\n2025-07-18 10:32:39 us\u003d870590 dco_do_read\n2025-07-18 10:32:39 us\u003d870769 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5651, peer-id 2, address: [AF_INET]193.149.48.173:62227\n2025-07-18 10:32:39 us\u003d870881 peer 2 (cron2-freebsd-tc-amd64) floated from udp4:193.149.48.172:62227 to [AF_INET]193.149.48.173:62227\n2025-07-18 10:32:43 us\u003d883102 dco_do_read\n2025-07-18 10:32:43 us\u003d883230 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5651, peer-id 2, address: [AF_INET]193.149.48.172:62227\n2025-07-18 10:32:43 us\u003d883293 peer 2 (cron2-freebsd-tc-amd64) floated from udp4:193.149.48.173:62227 to [AF_INET]193.149.48.172:62227\n(everything fine)\n\n2025-07-18 10:32:55 us\u003d935486 dco_get_peer_stats_multi\n2025-07-18 10:32:55 us\u003d935798 dco_parse_peer_multi: parsing message...\n2025-07-18 10:32:55 us\u003d935851 dco_update_peer_stat: no link RX bytes provided in reply for peer 2\n2025-07-18 10:32:55 us\u003d935881 dco_update_peer_stat: no link TX bytes provided in reply for peer 2\n2025-07-18 10:32:55 us\u003d935900 dco_update_peer_stat: no VPN RX bytes provided in reply for peer 2\n2025-07-18 10:32:55 us\u003d935919 dco_update_peer_stat: no VPN TX bytes provided in reply for peer 2\n2025-07-18 10:32:55 us\u003d937904 dco_parse_peer_multi: parsing message...\n2025-07-18 10:32:55 us\u003d937991 dco_update_peer_stat / dco_read_bytes: 976\n2025-07-18 10:32:55 us\u003d938052 dco_update_peer_stat / dco_write_bytes: 440\n2025-07-18 10:32:55 us\u003d938098 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-18 10:32:55 us\u003d938151 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-18 10:32:55 us\u003d938212 dco_parse_peer_multi: parsing message...\n2025-07-18 10:32:55 us\u003d938270 dco_update_peer_stat / dco_read_bytes: 400\n2025-07-18 10:32:55 us\u003d938322 dco_update_peer_stat / dco_write_bytes: 440\n2025-07-18 10:32:55 us\u003d938366 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-18 10:32:55 us\u003d938425 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-18 10:32:55 us\u003d938483 dco_parse_peer_multi: parsing message...\n2025-07-18 10:32:55 us\u003d938535 dco_update_peer_stat / dco_read_bytes: 13840\n2025-07-18 10:32:55 us\u003d938579 dco_update_peer_stat / dco_write_bytes: 13440\n2025-07-18 10:32:55 us\u003d938638 dco_update_peer_stat / tun_read_bytes: 10920\n2025-07-18 10:32:55 us\u003d938695 dco_update_peer_stat / tun_write_bytes: 10920\n2025-07-18 10:32:55 us\u003d939599 dco_do_read\n2025-07-18 10:32:55 us\u003d939755 dco_do_read: netlink reports error (-4): Try again\n\n(this \"no RX bytes for peer 2\" is what I saw yesterday as well, and the \"Try again\")\n\n2025-07-18 10:33:00 us\u003d100235 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 TLS: soft reset sec\u003d56/56 bytes\u003d0/-1 pkts\u003d0/0 aead_limit_send\u003d0/60129542137 aead_limit_recv\u003d0/60129542137\n2025-07-18 10:33:00 us\u003d100434 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 Sent warning SSL alert: close notify\n2025-07-18 10:33:00 us\u003d100719 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 dco_del_key: peer-id 2, slot 1\n\n(this still looks normal, skipping the UDP read/write)\n\n2025-07-18 10:33:00 us\u003d132607 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 VERIFY OK: depth\u003d1, C\u003dUS, ST\u003dCalifornia, L\u003dPleasanton, O\u003dOpenVPN community project, CN\u003dOpenVPN community project CA, emailAddress\u003dsamuli@openvpn.net\n2025-07-18 10:33:00 us\u003d132851 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 VERIFY OK: depth\u003d0, C\u003dDE, ST\u003dBavaria, L\u003dMunich, O\u003dOpenVPN community project, OU\u003dServer Testing, CN\u003dcron2-freebsd-tc-amd64, emailAddress\u003dgert@greenie.net\n2025-07-18 10:33:00 us\u003d133145 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_VER\u003d2.7_alpha2\n2025-07-18 10:33:00 us\u003d133198 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_PLAT\u003dmac\n2025-07-18 10:33:00 us\u003d133238 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_TCPNL\u003d1\n2025-07-18 10:33:00 us\u003d133283 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_MTU\u003d1600\n2025-07-18 10:33:00 us\u003d133315 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_NCP\u003d2\n2025-07-18 10:33:00 us\u003d133348 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_CIPHERS\u003dAES-256-GCM:AES-128-GCM:CHACHA20-POLY1305\n2025-07-18 10:33:00 us\u003d133385 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_PROTO\u003d3998\n2025-07-18 10:33:00 us\u003d133418 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_LZ4\u003d1\n2025-07-18 10:33:00 us\u003d133453 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_LZ4v2\u003d1\n2025-07-18 10:33:00 us\u003d133487 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_LZO\u003d1\n2025-07-18 10:33:00 us\u003d133521 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_COMP_STUB\u003d1\n2025-07-18 10:33:00 us\u003d133553 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 peer info: IV_COMP_STUBv2\u003d1\n2025-07-18 10:33:00 us\u003d133592 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 Note: \u0027compress migrate\u0027 detected remote peer with compression enabled.\n2025-07-18 10:33:00 us\u003d133743 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 UDPv4 WRITE [236] to [AF_INET]193.149.48.172:62227: P_CONTROL_V1 kid\u003d2 [ ] pid\u003d4456 DATA len\u003d222\n2025-07-18 10:33:00 us\u003d133834 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 UDPv4 WRITE [287] to [AF_INET]193.149.48.172:62227: P_CONTROL_V1 kid\u003d2 [ ] pid\u003d4712 DATA len\u003d273\n2025-07-18 10:33:00 us\u003d137204 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 UDPv4 READ [78] from [AF_INET]193.149.48.172:62227: P_ACK_V1 kid\u003d2 [ ] DATA len\u003d68\n2025-07-18 10:33:00 us\u003d140572 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 UDPv4 READ [82] from [AF_INET]193.149.48.172:62227: P_ACK_V1 kid\u003d2 [ ] DATA len\u003d72\n2025-07-18 10:33:00 us\u003d140640 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 Control Channel: TLSv1.3, cipher TLSv1.3 TLS_AES_256_GCM_SHA384, peer certificate: 2048 bits RSA, signature: RSA-SHA1, peer temporary key: 253 bits X25519, peer signing digest/type: SHA256 RSASSA-PSS\n2025-07-18 10:33:00 us\u003d140720 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 dco_install_key: peer_id\u003d2 keyid\u003d2, currently 1 keys installed\n2025-07-18 10:33:00 us\u003d140767 cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2 dco_new_key: slot 1, key-id 2, peer-id 2, cipher AES-256-GCM\n2025-07-18 10:33:00 us\u003d951542 dco_do_read\n2025-07-18 10:33:00 us\u003d951670 ovpn-dco: received CMD_PEER_FLOAT_NTF, ifindex: 5651, peer-id 2, address: [AF_INET]193.149.48.172:62227\n2025-07-18 10:33:00 us\u003d951736 closing instance cron2-freebsd-tc-amd64/udp4:193.149.48.172:62227 peer-id\u003d2\n2025-07-18 10:33:00 us\u003d951806 dco_get_peer_stats_multi\n2025-07-18 10:33:00 us\u003d952053 dco_parse_peer_multi: parsing message...\n2025-07-18 10:33:00 us\u003d952099 dco_update_peer_stat / dco_read_bytes: 976\n2025-07-18 10:33:00 us\u003d952135 dco_update_peer_stat / dco_write_bytes: 440\n2025-07-18 10:33:00 us\u003d952169 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-18 10:33:00 us\u003d952478 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-18 10:33:00 us\u003d952541 dco_parse_peer_multi: parsing message...\n2025-07-18 10:33:00 us\u003d952580 dco_update_peer_stat / dco_read_bytes: 400\n2025-07-18 10:33:00 us\u003d952614 dco_update_peer_stat / dco_write_bytes: 440\n2025-07-18 10:33:00 us\u003d952663 dco_update_peer_stat / tun_read_bytes: 0\n2025-07-18 10:33:00 us\u003d952707 dco_update_peer_stat / tun_write_bytes: 0\n2025-07-18 10:33:00 us\u003d952754 dco_parse_peer_multi: parsing message...\n2025-07-18 10:33:00 us\u003d952791 dco_parse_peer_multi: cannot store DCO stats for peer 2\n2025-07-18 10:33:00 us\u003d952892 register signal: SIGTERM (close_context)\n2025-07-18 10:33:00 us\u003d952943 dco_del_peer: peer-id 2\n2025-07-18 10:33:00 us\u003d972424 Sent warning SSL alert: close notify\n2025-07-18 10:33:00 us\u003d972698 Sent warning SSL alert: close notify\n\nProgram received signal SIGSEGV, Segmentation fault.\n0x0000555555599ef3 in multi_process_float (m\u003dm@entry\u003d0x7fffffffbcc0, mi\u003dmi@entry\u003d0x5555556a2050, sock\u003d0x55555564dbe0) at multi.c:3258\n3258        msg(D_MULTI_MEDIUM, \"peer %\" PRIu32 \" (%s) floated from %s to %s\",\n(gdb) list\n3253\n3254            msg(D_MULTI_MEDIUM, \"closing instance %s\", multi_instance_string(ex_mi, false, \u0026gc));\n3255            multi_close_instance(m, ex_mi, false);\n3256        }\n3257\n3258        msg(D_MULTI_MEDIUM, \"peer %\" PRIu32 \" (%s) floated from %s to %s\",\n3259            mi-\u003econtext.c2.tls_multi-\u003epeer_id,\n3260            tls_common_name(mi-\u003econtext.c2.tls_multi, false),\n3261            mroute_addr_print(\u0026mi-\u003ereal, \u0026gc),\n3262            print_link_socket_actual(\u0026m-\u003etop.c2.from, \u0026gc));\n(gdb) print mi-\u003econtext.c2.tls_multi\n$1 \u003d (struct tls_multi *) 0x0\n```","commit_id":"b5759cc366e5feceeb38cd5ad3ebf3aa2d090792"}],"src/openvpn/multi.c":[{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"6700d4491d8ae6b6674b868e31e9610652ede5cc","unresolved":true,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d4327cbe_dc45f82d","line":3390,"updated":"2025-07-15 14:21:46.000000000","message":"Do we really need this \"if\"? Could we trust the kernel and just assert inside `extract_dco_float_peer_addr` on incorrect AF?","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"97cc2c41dcb61bebcd07b22e24ea0c33cc96544f","unresolved":false,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"ec73084a_1fed51b8","line":3390,"in_reply_to":"32317b9e_d8a2c183","updated":"2025-07-16 08:56:42.000000000","message":"Done","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"5b4860c385ef47df7d30f5c919b52f57fe2f7485","unresolved":true,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"e60039a2_6836322f","line":3390,"in_reply_to":"347abf04_7c9f0c38","updated":"2025-07-16 08:00:41.000000000","message":"Yeah I would trust the kernel on Windows and add an assert to dco_handle_overlapped_success(). I think this would make the logic more simple. I could send you the diff and you could squash it into this patch.","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"3bf17465e3e4c86e2a1c3f53daa01492fab7097a","unresolved":true,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"febbeba3_6cfc1fdf","line":3390,"in_reply_to":"d4327cbe_dc45f82d","updated":"2025-07-15 14:23:00.000000000","message":"no, we can\u0027t trust the kernel. when talking to an external component we can\u0027t just assume it will always do the right thing. A bug in the kernel code should not crash userspace.","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"461c552aabf94987ce2d9142778d3f770b65c1d0","unresolved":true,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"32317b9e_d8a2c183","line":3390,"in_reply_to":"e60039a2_6836322f","updated":"2025-07-16 08:31:39.000000000","message":"after discussion on IRC we decided just to remove this \"if\" and not to add an assert - we\u0027ll get a error later in an improbable cause if dco-win returns invalid AF.","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"},{"author":{"_account_id":1000041,"name":"Ralf Lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"change_message_id":"a5cdd031dd4a75bf57495076a2b5db87859fda36","unresolved":true,"context_lines":[{"line_number":3387,"context_line":"#if defined(TARGET_LINUX) || defined(TARGET_WIN32)"},{"line_number":3388,"context_line":"        else if (dco-\u003edco_message_type \u003d\u003d OVPN_CMD_FLOAT_PEER)"},{"line_number":3389,"context_line":"        {"},{"line_number":3390,"context_line":"            if (extract_dco_float_peer_addr(peer_id, \u0026m-\u003etop.c2.from.dest,"},{"line_number":3391,"context_line":"                                            (struct sockaddr *)\u0026dco-\u003edco_float_peer_ss))"},{"line_number":3392,"context_line":"            {"},{"line_number":3393,"context_line":"                ASSERT(mi-\u003econtext.c2.link_sockets[0]);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"347abf04_7c9f0c38","line":3390,"in_reply_to":"febbeba3_6cfc1fdf","updated":"2025-07-15 15:36:44.000000000","message":"This isn’t actually a parsing of the kernel message, but rather a utility function to transpose the content of dco_float_peer_ss into m-\u003etop.c2.from.dest. Since dco_float_peer_ss is constructed by parsing the kernel notification, it would never contain an incorrect address family, thanks to a specific check in the Linux parser (ovpn_parse_float_addr()). OTOH, on Windows, we simply receive the sockaddr object from the kernel (if my understanding is correct), though I assume there’s a similar check in dco-win.\n\nSo this \u0027if\u0027 statement is probably redundant on Linux but might act as the missing userspace check for Windows. But if you\u0027d rather use an assert (since dco_float_peer_ss should never be ill-formed once we reach this point) we could add a check in dco_handle_overlapped_success() (or somewhere else in the dco_win-specific code) just to be safe.","commit_id":"b3a8d16668d240d21322cfeba6f4b3d456aaae0b"}]}
