)]}'
{"id":"openvpn~1088","triplet_id":"openvpn~master~I317be5253d6563906dd3826421dc81f737beba76","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-16 15:14:00.000000000","reason":"removed on reply"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-16 16:26:18.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I317be5253d6563906dd3826421dc81f737beba76","subject":"configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks","status":"MERGED","created":"2025-07-16 14:08:28.000000000","updated":"2025-07-16 16:26:18.000000000","submitted":"2025-07-16 16:26:18.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1088","meta_rev_id":"5bb2b78f0400a72ae74c4d47d01a9425143e0f09","_number":1088,"virtual_id_number":1088,"owner":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-16 14:08:29.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-16 14:08:29.000000000","updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"real_updated_by":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"b2d803bd5834009be5b7f05d285dbb459bd44324","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-16 14:08:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"917f85f2df13cb37845fa3bfe905271c82ccc184","author":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-07-16 15:14:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b2daa5041dbd135672e09a84e6e9ce69a0547f8f","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-07-16 15:19:08.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"5bb2b78f0400a72ae74c4d47d01a9425143e0f09","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-16 16:26:18.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ed690d1d58792f70b86b75b00c09df2ad96babca","revisions":{"469843143379b1f126bf417604a5fab8bc1b5fd9":{"kind":"REWORK","_number":1,"created":"2025-07-16 14:08:28.000000000","uploader":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/88/1088/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1088/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1 \u0026\u0026 git checkout -b change-1088 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"074bd7451decad407398c59006aa0e24ea1f451c","subject":"reliable: Review and fix gc_arena usage"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-07-16 14:05:52.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-07-16 14:05:52.000000000","tz":120},"subject":"configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks","message":"configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks\n\nThis code was copied over and over since many years,\nsince commit 9a3f670248d6f519a399e65a7232e2196b5115db\n(\"Fixed autoconf script to properly detect missing pkcs11\nwith polarssl\"). It is unclear what exact purpose it\nserved back then but probably it is obsolete. It is\ndefinitely wrong since it means that you get\nPKCS11_HELPER_LIBS even if you do not specify\n--enable-pkcs11.\n\nChange-Id: I317be5253d6563906dd3826421dc81f737beba76\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ed690d1d58792f70b86b75b00c09df2ad96babca":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-07-16 16:26:18.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1088/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1088/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2 \u0026\u0026 git checkout -b change-1088 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/88/1088/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3fdbad843550372ddaada223ef14dc1d935481d3","subject":"README.dco: update Linux instructions"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-07-16 15:18:57.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-16 16:25:04.000000000","tz":120},"subject":"configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks","message":"configure.ac: Remove use of PKCS11_HELPER_LIBS in mbedTLS checks\n\nThis code was copied over and over since many years,\nsince commit 9a3f670248d6f519a399e65a7232e2196b5115db\n(\"Fixed autoconf script to properly detect missing pkcs11\nwith polarssl\"). It is unclear what exact purpose it\nserved back then but probably it is obsolete. It is\ndefinitely wrong since it means that you get\nPKCS11_HELPER_LIBS even if you do not specify\n--enable-pkcs11.\n\nChange-Id: I317be5253d6563906dd3826421dc81f737beba76\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20250716151857.385959-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32187.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
