)]}'
{"id":"openvpn~1094","triplet_id":"openvpn~master~I673a17f8c5dec66cc6c28c1ed44780a7a63927d7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-23 15:00:14.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-07-23 13:38:51.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-23 15:00:14.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-07-23 15:00:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I673a17f8c5dec66cc6c28c1ed44780a7a63927d7","subject":"dco: only pass struct context to init function","status":"MERGED","created":"2025-07-22 20:22:05.000000000","updated":"2025-07-23 15:00:14.000000000","submitted":"2025-07-23 15:00:14.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1094","meta_rev_id":"f6e33feda07214de000d4101863bdd4486142a1b","_number":1094,"virtual_id_number":1094,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-22 20:22:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-22 20:22:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-22 20:22:07.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-23 06:19:18.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"},{"updated":"2025-07-23 08:16:03.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"CC"}],"messages":[{"id":"c0acb0423fb59d9d51bcf43fdeb29e98ec0cbeab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:22:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe14d170cdf59a54cee0ac4857412e4969622e09","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:26:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"37189d6506e7962e5b04d8744250096ffdc9f5fb","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 06:19:18.000000000","message":"Patch Set 2: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1c218dbf24f548dbafd2bbf9708b6e825aa24573","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-23 08:16:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"483fc7dc2aeb9f042a78b987528c0dbc9f6a52ae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-23 09:59:41.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"9dfb67616f7d1cf7a6b6a1366907b74b8a2c746d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-23 12:48:52.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"da8b27dba523c9dcd085f511bfc3d663e6d2e99b","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 13:38:51.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"f6e33feda07214de000d4101863bdd4486142a1b","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 15:00:14.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"a699681bb86c6e9a2c9f205543f60400208aea4b","revisions":{"7a72c8e568b880cfc627fcc01f819730da6096b2":{"kind":"REWORK","_number":1,"created":"2025-07-22 20:22:05.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/94/1094/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1094/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1 \u0026\u0026 git checkout -b change-1094 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"34acc8f75b6690783c50313f06ac44bb9e99e4ba","subject":"multi: store multi_context address inside top instance"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 09:12:04.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:22:01.000000000","tz":120},"subject":"dco: only pass struct context to init function","message":"dco: only pass struct context to init function\n\nFuture DCO code will require accessing the `multi` member of the\ncontext object.\n\nFor this reason a pointer to the context has to be stored in the\nDCO context along with the rest.\n\nAt this point, rather than making the call to ovpn_dco_init()\nlonger with more and more parameters, pass the struct context\nonly and let the implementation extract the needed fields.\n\nChange-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"aa72fdbbe82bca4460d89a274afa8cbbe2d809e2":{"kind":"REWORK","_number":2,"created":"2025-07-22 20:26:46.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/94/1094/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1094/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2 \u0026\u0026 git checkout -b change-1094 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"34acc8f75b6690783c50313f06ac44bb9e99e4ba","subject":"multi: store multi_context address inside top instance"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 09:12:04.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:26:41.000000000","tz":120},"subject":"dco: only pass struct context to init function","message":"dco: only pass struct context to init function\n\nFuture DCO code will require accessing the `multi` member of the\ncontext object.\n\nFor this reason a pointer to the context has to be stored in the\nDCO context along with the rest.\n\nAt this point, rather than making the call to ovpn_dco_init()\nlonger with more and more parameters, pass the struct context\nonly and let the implementation extract the needed fields.\n\nChange-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"6419aa66a1f68b2f2110b4a862f71be32c7d5190":{"kind":"REWORK","_number":3,"created":"2025-07-23 09:59:41.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/94/1094/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1094/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3 \u0026\u0026 git checkout -b change-1094 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f5a6deae33a338a23d7e8ff8526db8fdddf4bc2","subject":"multi: store multi_context address inside top instance"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 09:12:04.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 09:57:39.000000000","tz":120},"subject":"dco: only pass struct context to init function","message":"dco: only pass struct context to init function\n\nFuture DCO code will require accessing the `multi` member of the\ncontext object.\n\nFor this reason a pointer to the context has to be stored in the\nDCO context along with the rest.\n\nAt this point, rather than making the call to ovpn_dco_init()\nlonger with more and more parameters, pass the struct context\nonly and let the implementation extract the needed fields.\n\nChange-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"482409c8a009b117c0ae2a24c36d8de377b1057f":{"kind":"REWORK","_number":4,"created":"2025-07-23 12:48:52.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/94/1094/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1094/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4 \u0026\u0026 git checkout -b change-1094 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f5a6deae33a338a23d7e8ff8526db8fdddf4bc2","subject":"multi: store multi_context address inside top instance"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 09:12:04.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 10:03:49.000000000","tz":120},"subject":"dco: only pass struct context to init function","message":"dco: only pass struct context to init function\n\nFuture DCO code will require accessing the `multi` member of the\ncontext object.\n\nFor this reason a pointer to the context has to be stored in the\nDCO context along with the rest.\n\nAt this point, rather than making the call to ovpn_dco_init()\nlonger with more and more parameters, pass the struct context\nonly and let the implementation extract the needed fields.\n\nChange-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"a699681bb86c6e9a2c9f205543f60400208aea4b":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-07-23 15:00:14.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/94/1094/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/94/1094/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5 \u0026\u0026 git checkout -b change-1094 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/94/1094/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7f5a6deae33a338a23d7e8ff8526db8fdddf4bc2","subject":"multi: store multi_context address inside top instance"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 13:39:11.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-23 14:58:09.000000000","tz":120},"subject":"dco: only pass struct context to init function","message":"dco: only pass struct context to init function\n\nFuture DCO code will require accessing the `multi` member of the\ncontext object.\n\nFor this reason a pointer to the context has to be stored in the\nDCO context along with the rest.\n\nAt this point, rather than making the call to ovpn_dco_init()\nlonger with more and more parameters, pass the struct context\nonly and let the implementation extract the needed fields.\n\nChange-Id: I673a17f8c5dec66cc6c28c1ed44780a7a63927d7\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250723133918.19431-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32293.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}