)]}'
{"id":"openvpn~1096","triplet_id":"openvpn~master~Ifc442b4426c02de7282d0f69629e8a10b679c589","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000007":{"account":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-07-23 08:18:40.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-23 08:18:40.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-23 08:18:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifc442b4426c02de7282d0f69629e8a10b679c589","subject":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths","status":"MERGED","created":"2025-07-22 20:22:05.000000000","updated":"2025-07-23 08:18:40.000000000","submitted":"2025-07-23 08:18:40.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1096","meta_rev_id":"405b2fe22f7edffc080fc5ed35d5b0ba197f5271","_number":1096,"virtual_id_number":1096,"owner":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-22 20:22:08.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-22 20:22:08.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-22 20:22:08.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-23 06:30:12.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"834976e335dea6a58ec19c83829e4c6a39c107f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:22:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8e83e85eda154f2e87e46831076ba0b93344c99b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:26:46.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"bede003c4d5160d2bbca7cb7e094e33176a60ce1","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 06:30:12.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"405b2fe22f7edffc080fc5ed35d5b0ba197f5271","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 08:18:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"dfe71b0a397273efffabbc01d1f6a9933f607933","revisions":{"a72674fcfc107b3d87e7d849154b159adca2d017":{"kind":"REWORK","_number":1,"created":"2025-07-22 20:22:05.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/96/1096/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1096/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1 \u0026\u0026 git checkout -b change-1096 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"41cd50a797855bd4ad32ad9df4c9dd9a68795955","subject":"dco_linux: fix case statement by using proper error value"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 13:26:13.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:22:01.000000000","tz":120},"subject":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths","message":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths\n\nNetlink code doesn\u0027t set errno upon error (with the exception of\nany *alloc() function which probably inherits the errno\u003dENOMEM\nfrom the underlying malloc call), therefore we should not print\nerror messages with M_ERR, but rather rely on M_FATAL.\n\nM_ERR is equivalent to M_FATAL with the addition of appending\n\": $errno\" to the error string.\n\nSince errno is not meaningful in this context, we can just opt\nfor the less confusing M_FATAL.\n\nChange-Id: Ifc442b4426c02de7282d0f69629e8a10b679c589\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"24d30785840f581330873225eb0cb5715c027385":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-22 20:26:46.000000000","uploader":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/96/1096/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1096/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2 \u0026\u0026 git checkout -b change-1096 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"82ebf46ce41420b92fba7f80a24d6487233bb54f","subject":"dco_linux: fix case statement by using proper error value"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 13:26:13.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:26:41.000000000","tz":120},"subject":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths","message":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths\n\nNetlink code doesn\u0027t set errno upon error (with the exception of\nany *alloc() function which probably inherits the errno\u003dENOMEM\nfrom the underlying malloc call), therefore we should not print\nerror messages with M_ERR, but rather rely on M_FATAL.\n\nM_ERR is equivalent to M_FATAL with the addition of appending\n\": $errno\" to the error string.\n\nSince errno is not meaningful in this context, we can just opt\nfor the less confusing M_FATAL.\n\nChange-Id: Ifc442b4426c02de7282d0f69629e8a10b679c589\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"dfe71b0a397273efffabbc01d1f6a9933f607933":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-07-23 08:18:40.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/96/1096/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/96/1096/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3 \u0026\u0026 git checkout -b change-1096 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/96/1096/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f1a2a37897a6517c4c321abb7bc343bf495c94e2","subject":"dco_linux: fix case statement by using proper error value"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 06:30:30.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-23 08:16:01.000000000","tz":120},"subject":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths","message":"dco_linux: use M_FATAL instead of M_ERR in netlink error code paths\n\nNetlink code doesn\u0027t set errno upon error (with the exception of\nany *alloc() function which probably inherits the errno\u003dENOMEM\nfrom the underlying malloc call), therefore we should not print\nerror messages with M_ERR, but rather rely on M_FATAL.\n\nM_ERR is equivalent to M_FATAL with the addition of appending\n\": $errno\" to the error string.\n\nSince errno is not meaningful in this context, we can just opt\nfor the less confusing M_FATAL.\n\nChange-Id: Ifc442b4426c02de7282d0f69629e8a10b679c589\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250723063039.25449-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32271.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
