)]}'
{"id":"openvpn~1099","triplet_id":"openvpn~master~I7bbc40b7b66f6e0512cd2cf9791766bcc4970461","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-23 16:16:47.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-23 16:16:47.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-07-23 16:16:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7bbc40b7b66f6e0512cd2cf9791766bcc4970461","subject":"dco_linux: factor out netlink notification code","status":"MERGED","created":"2025-07-22 20:22:05.000000000","updated":"2025-07-23 16:16:47.000000000","submitted":"2025-07-23 16:16:47.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1099","meta_rev_id":"dba2e61f4441f010bfb9f74e14f724dc7b49d19d","_number":1099,"virtual_id_number":1099,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-22 20:22:09.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-22 20:22:09.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-22 20:22:09.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-23 15:32:04.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"abd06b5764ade2ddb7ba2d6ec5b98d4c8970ef7c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:22:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c1955b6a3aff20362b07b04b26d4865844a9dcb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-22 20:26:46.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.","accounts_in_message":[],"_revision_number":2},{"id":"551c3ee7b4427a70915e4f426fa18b531dc28ff1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-23 09:59:41.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"526cc8ac626a1c07ac0f1150739e1fa15e35a578","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-23 10:02:25.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"487a3a89b9c8a67d248b4faf52562bd701d1b664","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-23 12:48:52.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3cc7f5903d3eadc6766c1579b2aad464e9d99b96","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 15:32:04.000000000","message":"Patch Set 4: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"dba2e61f4441f010bfb9f74e14f724dc7b49d19d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-23 16:16:47.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0e0023fe48357150ef1c35b99451f6d3054e2c0b","revisions":{"4bde9d33de060b95f6964660f1a35c7e64c28032":{"kind":"REWORK","_number":1,"created":"2025-07-22 20:22:05.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/99/1099/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1099/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1 \u0026\u0026 git checkout -b change-1099 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"53dc9d877c21618b71bb973997cfdc6f307710b0","subject":"dco_linux: rearrange functions"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 14:24:33.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:22:01.000000000","tz":120},"subject":"dco_linux: factor out netlink notification code","message":"dco_linux: factor out netlink notification code\n\novpn_handle_msg() is soon becoming the main entry point for parsing\n*all* incoming netlink messages. For this reason it is essential\nthat this function is kept simple and slim.\n\nMove all code parsing netlink multicast notifications to their own\nhelpers and then invoke them.\n\nThis patch does not introduce any functional change.\nIt is intended in preparation for extending ovpn_handle_msg() to\nbecome a genering netlink message parser.\n\nChange-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"2dc04bcc59d5a54d8da6361b839efa0b2c58ddb2":{"kind":"NO_CHANGE","_number":2,"created":"2025-07-22 20:26:46.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/99/1099/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1099/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2 \u0026\u0026 git checkout -b change-1099 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d9cac516727098c87d838096884568f5c98479e5","subject":"dco_linux: rearrange functions"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 14:24:33.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 20:26:41.000000000","tz":120},"subject":"dco_linux: factor out netlink notification code","message":"dco_linux: factor out netlink notification code\n\novpn_handle_msg() is soon becoming the main entry point for parsing\n*all* incoming netlink messages. For this reason it is essential\nthat this function is kept simple and slim.\n\nMove all code parsing netlink multicast notifications to their own\nhelpers and then invoke them.\n\nThis patch does not introduce any functional change.\nIt is intended in preparation for extending ovpn_handle_msg() to\nbecome a genering netlink message parser.\n\nChange-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"9c33b0c4389bf272ca32cb6467b7b72941f78928":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-07-23 09:59:41.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/99/1099/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1099/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3 \u0026\u0026 git checkout -b change-1099 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6419aa66a1f68b2f2110b4a862f71be32c7d5190","subject":"dco: only pass struct context to init function"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 14:24:33.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 09:57:40.000000000","tz":120},"subject":"dco_linux: factor out netlink notification code","message":"dco_linux: factor out netlink notification code\n\novpn_handle_msg() is soon becoming the main entry point for parsing\n*all* incoming netlink messages. For this reason it is essential\nthat this function is kept simple and slim.\n\nMove all code parsing netlink multicast notifications to their own\nhelpers and then invoke them.\n\nThis patch does not introduce any functional change.\nIt is intended in preparation for extending ovpn_handle_msg() to\nbecome a genering netlink message parser.\n\nChange-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"684fdd6a0606513cd15d99cea9066d2309650d1c":{"kind":"REWORK","_number":4,"created":"2025-07-23 12:48:52.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/99/1099/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1099/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4 \u0026\u0026 git checkout -b change-1099 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"482409c8a009b117c0ae2a24c36d8de377b1057f","subject":"dco: only pass struct context to init function"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-22 14:24:33.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 12:28:36.000000000","tz":120},"subject":"dco_linux: factor out netlink notification code","message":"dco_linux: factor out netlink notification code\n\novpn_handle_msg() is soon becoming the main entry point for parsing\n*all* incoming netlink messages. For this reason it is essential\nthat this function is kept simple and slim.\n\nMove all code parsing netlink multicast notifications to their own\nhelpers and then invoke them.\n\nThis patch does not introduce any functional change.\nIt is intended in preparation for extending ovpn_handle_msg() to\nbecome a genering netlink message parser.\n\nChange-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"0e0023fe48357150ef1c35b99451f6d3054e2c0b":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-07-23 16:16:47.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/99/1099/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/99/1099/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5 \u0026\u0026 git checkout -b change-1099 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/99/1099/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a699681bb86c6e9a2c9f205543f60400208aea4b","subject":"dco: only pass struct context to init function"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-23 15:32:19.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-23 16:15:33.000000000","tz":120},"subject":"dco_linux: factor out netlink notification code","message":"dco_linux: factor out netlink notification code\n\novpn_handle_msg() is soon becoming the main entry point for parsing\n*all* incoming netlink messages. For this reason it is essential\nthat this function is kept simple and slim.\n\nMove all code parsing netlink multicast notifications to their own\nhelpers and then invoke them.\n\nThis patch does not introduce any functional change.\nIt is intended in preparation for extending ovpn_handle_msg() to\nbecome a genering netlink message parser.\n\nChange-Id: I7bbc40b7b66f6e0512cd2cf9791766bcc4970461\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250723153224.13708-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32298.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}