)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"b054955efe82dd24b37c903afb484d5b594c4111","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e384a5ab_a062e9b5","updated":"2025-09-14 17:42:52.000000000","message":"Would it be less noisy and less space-consuming to change the other users to always use \"int\" instead?\n\nAlso, it breaks tests :-(","commit_id":"11ede9ff314dbf5b9b37c2737c593ee747b24a26"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"82fb3ea01553be5492ef964d0fe303f4b146b2de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7de44001_71804402","in_reply_to":"8c805422_f0500019","updated":"2025-09-17 15:56:29.000000000","message":"Acknowledged","commit_id":"11ede9ff314dbf5b9b37c2737c593ee747b24a26"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"0ab691b594bf2d65d6e0f1064a1b3aa8a536dedc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8c805422_f0500019","in_reply_to":"e384a5ab_a062e9b5","updated":"2025-09-15 15:13:07.000000000","message":"I just checked both patches and honestly it immediately looked weird to me that \"flags\" are stored in a \"signed\" container.\nJust as an example: normally flags are printed in hex format with %x - this one obviously doesn\u0027t expect a signed int.\n\nI\u0027d much rather go with this patch and drop #1189","commit_id":"11ede9ff314dbf5b9b37c2737c593ee747b24a26"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"89117934f8ec4122ad0768142d82f492dc302f2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7109e06c_06832fe9","updated":"2025-09-18 12:08:42.000000000","message":"LGTM","commit_id":"fcbef24bd54a93ae44d22e7349adef7583bc079e"}],"src/openvpn/error.c":[{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"6420e7806581929841db637743d1df278bb4c072","unresolved":true,"context_lines":[{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"bool"},{"line_number":104,"context_line":"set_debug_level(const int level, const unsigned int flags)"},{"line_number":105,"context_line":"{"},{"line_number":106,"context_line":"    if (level \u003e\u003d 0 \u0026\u0026 level \u003c\u003d M_DEBUG_LEVEL)"},{"line_number":107,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"e38154f9_4a81f5bc","line":104,"updated":"2025-09-18 08:13:48.000000000","message":"why not turning this into msglvl_t too?\nI see it normally gets passed o-\u003everbosity, but it could also be turned to msglvl_t as well since it never gets assigned a negative number.\n\nThe only situation to check is manage.c:1467. The mgmt interface technically accepts \"verb -1\", but it is a bogus case. We could force it to be positive as well.","commit_id":"fcbef24bd54a93ae44d22e7349adef7583bc079e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"d86fbf37110b1585c53d8438761172e9f8b097c0","unresolved":true,"context_lines":[{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"bool"},{"line_number":104,"context_line":"set_debug_level(const int level, const unsigned int flags)"},{"line_number":105,"context_line":"{"},{"line_number":106,"context_line":"    if (level \u003e\u003d 0 \u0026\u0026 level \u003c\u003d M_DEBUG_LEVEL)"},{"line_number":107,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"e7d1179f_51d3b84a","line":104,"in_reply_to":"e38154f9_4a81f5bc","updated":"2025-09-18 09:44:52.000000000","message":"I considered it, but then decided to leave it as is. I had to draw a boundary somewhere. We could definitely change it in a separate commit but this one is big enough as it is.","commit_id":"fcbef24bd54a93ae44d22e7349adef7583bc079e"},{"author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"change_message_id":"89117934f8ec4122ad0768142d82f492dc302f2d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"bool"},{"line_number":104,"context_line":"set_debug_level(const int level, const unsigned int flags)"},{"line_number":105,"context_line":"{"},{"line_number":106,"context_line":"    if (level \u003e\u003d 0 \u0026\u0026 level \u003c\u003d M_DEBUG_LEVEL)"},{"line_number":107,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":16,"id":"adb8b041_da6e06cc","line":104,"in_reply_to":"e7d1179f_51d3b84a","updated":"2025-09-18 12:08:42.000000000","message":"Done","commit_id":"fcbef24bd54a93ae44d22e7349adef7583bc079e"}]}