)]}'
{"id":"openvpn~1114","triplet_id":"openvpn~master~Icbc70225d53ca678b8c22ed437b424c16e199d66","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-27 10:45:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-27 10:45:45.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-07-27 10:45:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Icbc70225d53ca678b8c22ed437b424c16e199d66","subject":"dco_linux: clean up PEER_GET trigger and parser","status":"MERGED","created":"2025-07-25 23:29:40.000000000","updated":"2025-07-27 10:45:45.000000000","submitted":"2025-07-27 10:45:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1114","meta_rev_id":"d730b9c55bb3e83045b0beaf30d687eab9f2eaf8","_number":1114,"virtual_id_number":1114,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-25 23:29:41.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-25 23:29:41.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-25 23:29:41.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-27 10:21:49.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"60dcd038c8980e2633ebd3380554ddca7fa3a188","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-25 23:29:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e446207616344a84f9a686ffcab734e040ec655","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-25 23:31:01.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e30cf62b3f6d2a6b3f87bf12adeff5c6c166dc9b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-25 23:41:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"bbf4c21eab0a3534dc184fa50b30f87759d4bee9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-27 10:21:49.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"d730b9c55bb3e83045b0beaf30d687eab9f2eaf8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-27 10:45:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"d1f2afc26bc8cc1837c2c12981e7eb6afdd4fcf6","revisions":{"652892429f1ed84295f7a5ee10c4f9bfded439d2":{"kind":"REWORK","_number":1,"created":"2025-07-25 23:29:40.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/14/1114/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1114/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1 \u0026\u0026 git checkout -b change-1114 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7d5ec053f0f30c6cd27b60ed76859a09f6dbf5e4","subject":"add flag to print addresses in a consistent format during float"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:24:23.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:29:17.000000000","tz":120},"subject":"dco_linux: clean up PEER_GET trigger and parser","message":"dco_linux: clean up PEER_GET trigger and parser\n\nThis patch is intended to reduce code duplication and\ncleanup the DCO code around the PEER_GET command.\n\nSpecifically it:\n* unified PEER_GET reply parser for `multi` and\n  `non-multi` case\n* unified PEER_GET request trigger for `multi` and\n  `non-multi` case\n* dropped struct multi_context from the argument list of\n  dco_get_peer_stats_multi()\n\nChange-Id: Icbc70225d53ca678b8c22ed437b424c16e199d66\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"779c87b0266adb815d27d3e4dfcc35433ede0fcb":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-07-25 23:31:01.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/14/1114/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1114/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2 \u0026\u0026 git checkout -b change-1114 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7d5ec053f0f30c6cd27b60ed76859a09f6dbf5e4","subject":"add flag to print addresses in a consistent format during float"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:24:23.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:30:44.000000000","tz":120},"subject":"dco_linux: clean up PEER_GET trigger and parser","message":"dco_linux: clean up PEER_GET trigger and parser\n\nThis patch is intended to reduce code duplication and\ncleanup the DCO code around the PEER_GET command.\n\nSpecifically it:\n* unified PEER_GET reply parser for `multi` and\n  `non-multi` case\n* unified PEER_GET request trigger for `multi` and\n  `non-multi` case\n* dropped struct multi_context from the argument list of\n  dco_get_peer_stats_multi()\n\nGithub: closes OpenVPN/openvpn#800\nChange-Id: Icbc70225d53ca678b8c22ed437b424c16e199d66\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"fccbd9cb853b31825c74115dbca61cde0f7eff82":{"kind":"REWORK","_number":3,"created":"2025-07-25 23:41:44.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/14/1114/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1114/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3 \u0026\u0026 git checkout -b change-1114 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7d5ec053f0f30c6cd27b60ed76859a09f6dbf5e4","subject":"add flag to print addresses in a consistent format during float"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:24:23.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:41:30.000000000","tz":120},"subject":"dco_linux: clean up PEER_GET trigger and parser","message":"dco_linux: clean up PEER_GET trigger and parser\n\nThis patch is intended to reduce code duplication and\ncleanup the DCO code around the PEER_GET command.\n\nSpecifically it:\n* unified PEER_GET reply parser for `multi` and\n  `non-multi` case\n* unified PEER_GET request trigger for `multi` and\n  `non-multi` case\n* dropped struct multi_context from the argument list of\n  dco_get_peer_stats_multi()\n\nGithub: closes OpenVPN/openvpn#800\nChange-Id: Icbc70225d53ca678b8c22ed437b424c16e199d66\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"d1f2afc26bc8cc1837c2c12981e7eb6afdd4fcf6":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-07-27 10:45:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/14/1114/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/14/1114/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4 \u0026\u0026 git checkout -b change-1114 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/14/1114/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3594f5901db17d9b57d8809c729ef24d4bbfddf5","subject":"multi: make some multi_*() functions static"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-27 10:22:40.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-27 10:40:42.000000000","tz":120},"subject":"dco_linux: clean up PEER_GET trigger and parser","message":"dco_linux: clean up PEER_GET trigger and parser\n\nThis patch is intended to reduce code duplication and\ncleanup the DCO code around the PEER_GET command.\n\nSpecifically it:\n* unified PEER_GET reply parser for `multi` and\n  `non-multi` case\n* unified PEER_GET request trigger for `multi` and\n  `non-multi` case\n* dropped struct multi_context from the argument list of\n  dco_get_peer_stats_multi()\n\nGithub: closes OpenVPN/openvpn#800\nChange-Id: Icbc70225d53ca678b8c22ed437b424c16e199d66\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250727102245.24931-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32361.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}