)]}'
{"id":"openvpn~1116","triplet_id":"openvpn~master~I1ad5df0f6785ffe9becd9f83329a9335d1a36f24","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-12 17:00:35.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-11 20:12:00.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-12 17:00:35.000000000","reason":"Change was submitted"},"1000007":{"account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"last_update":"2025-09-11 19:00:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000007\u003e replied on the change","reason_account":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}}},"hashtags":["mailsubmitted"],"change_id":"I1ad5df0f6785ffe9becd9f83329a9335d1a36f24","subject":"dco: add standard mi prefix handling to multi_process_incoming_dco()","status":"MERGED","created":"2025-07-26 00:01:18.000000000","updated":"2025-09-12 17:00:35.000000000","submitted":"2025-09-12 17:00:35.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":9,"unresolved_comment_count":2,"has_review_started":true,"submission_id":"1116","meta_rev_id":"694533f0583c4c25c009dafd89d4f231fa3a222f","_number":1116,"virtual_id_number":1116,"owner":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-26 00:01:19.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-26 00:01:19.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-26 00:01:19.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-27 10:24:07.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"4b1446d2113bee333e63395d273e39450e9def52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-26 00:01:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2eabc7b5cd1d7393613c968ed8d82cd792470aae","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-26 00:08:34.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"97a86031fe128dec7d989dabab2e82b3da8660e0","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-27 10:24:07.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"9afb9ee15c18ab798246934c2ed9d6814326e17e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-27 10:39:01.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"56f809cded1d20dfbd5d08a7fa83816df9b9e18d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-27 11:02:31.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"177cd211a8e905cf84909fcea8138184eedea826","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-28 11:37:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8354516a6b4379038941547c894ae8f0166745d5","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-28 11:39:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e351551bbb5920acfe1b02f9f7e80d15d7caa379","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-08 20:40:13.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1dd2a5cb7d5febcdd791f65c4ccea76219458e59","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-11 17:39:44.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"3ccfbe347f951fd926037cd7976c743585079b00","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-09-11 19:00:21.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"cb5918db2ea8b303c5a70873b34c46c3dd16a237","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-11 20:12:00.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"2d1b9efe2b85df77bce8f3e216c96cb39322b2e6","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-12 13:13:02.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":3},{"id":"694533f0583c4c25c009dafd89d4f231fa3a222f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-12 17:00:35.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"531fef40b73f73632548c88697af34cf15a70531","revisions":{"02333a0ad84c66ac7ef71ddf3231192173c6c806":{"kind":"REWORK","_number":1,"created":"2025-07-26 00:01:18.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/16/1116/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1116/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1 \u0026\u0026 git checkout -b change-1116 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44e0844d1b643289606b937225ce191e135f2d02","subject":"multi: make multi_process_float() static"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:57:20.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-26 00:00:21.000000000","tz":120},"subject":"dco: drop client prefix after DCO PEER_FLOAT notification","message":"dco: drop client prefix after DCO PEER_FLOAT notification\n\nmulti_process_float() will possibly float a client and\nalso generate and set its new prefix.\n\nHowever, after processing the PEER_FLOAT_NTF message, we\nwere not clearing the prefix, thus effectivly making\nthe generated prefix permanent until the next set_prefix()\ncall.\n\nClear the prefix right after calling multi_process_float()\nto avoid printing messages with the wrong prefix.\n\nGithub: closes OpenVPN/openvpn#799\nChange-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"39d22dc66acc8f353b269b6f06f749a7add1e927":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-07-26 00:08:34.000000000","uploader":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"ref":"refs/changes/16/1116/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1116/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2 \u0026\u0026 git checkout -b change-1116 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4041fb48b35162d41bc146aa23532f087c828433","subject":"multi: make some multi_*() functions static"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:57:20.000000000","tz":120},"committer":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-26 00:08:31.000000000","tz":120},"subject":"dco: drop client prefix after DCO PEER_FLOAT notification","message":"dco: drop client prefix after DCO PEER_FLOAT notification\n\nmulti_process_float() will possibly float a client and\nalso generate and set its new prefix.\n\nHowever, after processing the PEER_FLOAT_NTF message, we\nwere not clearing the prefix, thus effectivly making\nthe generated prefix permanent until the next set_prefix()\ncall.\n\nClear the prefix right after calling multi_process_float()\nto avoid printing messages with the wrong prefix.\n\nGithub: closes OpenVPN/openvpn#799\nChange-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"822a5684af7450388eede627f63777a975a2e525":{"kind":"REWORK","_number":3,"created":"2025-09-11 17:39:44.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/16/1116/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1116/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3 \u0026\u0026 git checkout -b change-1116 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88f8edbf7545dc7913d031ea12c4bae5250bb766","subject":"replace assert() calls with ASSERT()"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-07-25 23:57:20.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-11 17:39:23.000000000","tz":120},"subject":"dco: add standard mi prefix handling to multi_process_incoming_dco()","message":"dco: add standard mi prefix handling to multi_process_incoming_dco()\n\nOur code generally expects functions that deal with a multi instance\nto set up a log prefix at the beginning with set_prefix(mi) and clear\nit at the end with clear_prefix().\n\nAdd the calls to multi_process_incoming_dco() in a similar way to\nwhat is done for multi_process_incoming_link() - handling \"link\nevents\" and \"dco events\" the same, with correct prefix in the\nfunction and no leftover prefix afterwards.\n\nGithub: closes OpenVPN/openvpn#799\nChange-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"531fef40b73f73632548c88697af34cf15a70531":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-09-12 17:00:35.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/16/1116/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1116/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4 \u0026\u0026 git checkout -b change-1116 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1116/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"340b5b2d264a47c24aa948efb83ffa04e0e9c7e2","subject":"remove newline characters at the end of msg() calls"}],"author":{"name":"Antonio Quartulli","email":"antonio@mandelbit.com","date":"2025-09-11 20:12:16.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-12 16:17:06.000000000","tz":120},"subject":"dco: add standard mi prefix handling to multi_process_incoming_dco()","message":"dco: add standard mi prefix handling to multi_process_incoming_dco()\n\nOur code generally expects functions that deal with a multi instance\nto set up a log prefix at the beginning with set_prefix(mi) and clear\nit at the end with clear_prefix().\n\nAdd the calls to multi_process_incoming_dco() in a similar way to\nwhat is done for multi_process_incoming_link() - handling \"link\nevents\" and \"dco events\" the same, with correct prefix in the\nfunction and no leftover prefix afterwards.\n\nGithub: closes OpenVPN/openvpn#799\nChange-Id: I1ad5df0f6785ffe9becd9f83329a9335d1a36f24\nSigned-off-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250911201222.25382-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32859.html\nURL: https://gerrit.openvpn.net/c/openvpn/+/1116\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}