)]}'
{"id":"openvpn~1117","triplet_id":"openvpn~master~I6977d23b5289eba5db436608e0500216e0e689ec","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-28 10:35:40.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-07-28 10:35:40.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-28 10:35:40.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6977d23b5289eba5db436608e0500216e0e689ec","subject":"mudp.c, multi.c, multi_io.c: get rid of \u0027all three DCO platforms\u0027 #ifdefs","status":"MERGED","created":"2025-07-28 08:10:18.000000000","updated":"2025-07-28 10:35:40.000000000","submitted":"2025-07-28 10:35:40.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1117","meta_rev_id":"87b2822cbcf77de7083a810c1a24ed531ed233d4","_number":1117,"virtual_id_number":1117,"owner":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-28 08:10:18.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-28 08:10:18.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-28 08:10:18.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-28 08:38:18.000000000","updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"real_updated_by":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"0ad70f12d337b100fb3f883da5f63beeda8b4b67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-28 08:10:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e16f44919f5a92723d8fbd08643be3691c01418","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-28 08:12:40.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1c983998a3ebaba907f54aa88fd1d803ed0ef560","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-28 08:25:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"41de5c857ba228265ed493abbc2bed89bbbb34ef","author":{"_account_id":1000007,"name":"Antonio Quartulli","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-07-28 08:38:18.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"87b2822cbcf77de7083a810c1a24ed531ed233d4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-28 10:35:40.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6d0e38370b62488374a09336652ab415776955fc","revisions":{"29d601e8e9e860711c0670b60d25c67bb8bb3d84":{"kind":"REWORK","_number":1,"created":"2025-07-28 08:10:18.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1117/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1117/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1 \u0026\u0026 git checkout -b change-1117 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b66b80b2ab73bb422826911b675798e6b789ef03","subject":"dco: support float notifications on FreeBSD"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:07:29.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:07:29.000000000","tz":120},"subject":"multi.c get rid of #ifdef surrounding DCO float notifications","message":"multi.c get rid of #ifdef surrounding DCO float notifications\n\nWith commit b66b80b2a all three platforms with DCO support have DCO float\nnotifications now, so the #ifdef inside multi_process_incoming_dco() is\nno longer needed.\n\nChange-Id: I6977d23b5289eba5db436608e0500216e0e689ec\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"d814386bf6eee8b92a0ab66034ed04accead68e9":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-07-28 08:12:40.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1117/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1117/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2 \u0026\u0026 git checkout -b change-1117 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b66b80b2ab73bb422826911b675798e6b789ef03","subject":"dco: support float notifications on FreeBSD"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:07:29.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:12:30.000000000","tz":120},"subject":"multi.c: get rid of #ifdef surrounding DCO float notifications","message":"multi.c: get rid of #ifdef surrounding DCO float notifications\n\nWith commit b66b80b2a all three platforms with DCO support have DCO float\nnotifications now, so the #ifdef inside multi_process_incoming_dco() is\nno longer needed.\n\nChange-Id: I6977d23b5289eba5db436608e0500216e0e689ec\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c1a0b52412b11f40cd6780330d516bdde17312b6":{"kind":"REWORK","_number":3,"created":"2025-07-28 08:25:27.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1117/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1117/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3 \u0026\u0026 git checkout -b change-1117 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b66b80b2ab73bb422826911b675798e6b789ef03","subject":"dco: support float notifications on FreeBSD"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:07:29.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:23:57.000000000","tz":120},"subject":"mudp.c, multi.c, multi_io.c: get rid of \"all three DCO platforms\" #ifdefs","message":"mudp.c, multi.c, multi_io.c: get rid of \"all three DCO platforms\" #ifdefs\n\nWith commit b66b80b2a all three platforms with DCO support have DCO float\nnotifications now, so the #ifdef inside multi_process_incoming_dco() is\nno longer needed.\n\nAlso, the whole notification block (process_incoming_del_peer() and\nmulti_process_incoming_dco()) was surrounded by an\n\n  #ifdef ENABLE_DCO \"and all 3 platforms\"\n\nwhich is also not making sense anymore (if we add a fourth DCO platform,\nwe need to aim for having \"all notifications from day 1\", at least having\nthe stubs and defines).\n\nLast not least, the event stuff in mudp.c and multi_io.c had grown the\nsame construct - and we\u0027ll need events for any future DCO platform, too.\n\nSo, fix those #ifdef as well, while at it.\n\nChange-Id: I6977d23b5289eba5db436608e0500216e0e689ec\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"6d0e38370b62488374a09336652ab415776955fc":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2025-07-28 10:35:40.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/17/1117/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/17/1117/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4 \u0026\u0026 git checkout -b change-1117 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/17/1117/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b66b80b2ab73bb422826911b675798e6b789ef03","subject":"dco: support float notifications on FreeBSD"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 08:42:49.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-28 10:24:13.000000000","tz":120},"subject":"mudp.c, multi.c, multi_io.c: get rid of \u0027all three DCO platforms\u0027 #ifdefs","message":"mudp.c, multi.c, multi_io.c: get rid of \u0027all three DCO platforms\u0027 #ifdefs\n\nWith commit b66b80b2a all three platforms with DCO support have DCO float\nnotifications now, so the #ifdef inside multi_process_incoming_dco() is\nno longer needed.\n\nAlso, the whole notification block (process_incoming_del_peer() and\nmulti_process_incoming_dco()) was surrounded by an\n\n  #ifdef ENABLE_DCO \"and all 3 platforms\"\n\nwhich is also not making sense anymore (if we add a fourth DCO platform,\nwe need to aim for having \"all notifications from day 1\", at least having\nthe stubs and defines).\n\nLast not least, the event stuff in mudp.c and multi_io.c had grown the\nsame construct - and we\u0027ll need events for any future DCO platform, too.\n\nSo, fix those #ifdef as well, while at it.\n\nChange-Id: I6977d23b5289eba5db436608e0500216e0e689ec\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nMessage-Id: \u003c20250728084255.1824-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32377.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
