)]}'
{"id":"openvpn~1120","triplet_id":"openvpn~master~Id95cd14095a03afb3140a03ae96e9f5679e4fe89","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-07-31 10:55:39.000000000","reason":"Change was submitted"},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-31 10:55:39.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-07-31 10:48:12.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-31 10:55:39.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Id95cd14095a03afb3140a03ae96e9f5679e4fe89","subject":"Fix --dns options for TAP adapter","status":"MERGED","created":"2025-07-31 09:16:15.000000000","updated":"2025-07-31 12:42:38.000000000","submitted":"2025-07-31 10:55:39.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1120","meta_rev_id":"b54a775e8133ec8e2a61699fed120051e95048df","_number":1120,"virtual_id_number":1120,"owner":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-31 09:16:15.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-31 09:16:15.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-31 09:16:15.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-31 09:29:55.000000000","updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"real_updated_by":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"003159b2bb0bb141b22f295a01e8decb45a0d227","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 09:16:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a7d6a0d2b8707d9c8ee7678554c814ae66cb9cb","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-31 09:29:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b4b111975afd7e026d7d0ca1afe6ce3b191a9dc0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 09:48:16.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6901af662699b2efb65c99898ef166aeceea293d","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-31 10:48:12.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cb36a94298e18ae1ca0315a8b47dbad16e65b527","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-31 10:55:39.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3},{"id":"b54a775e8133ec8e2a61699fed120051e95048df","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 12:42:38.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"264fe91660fb1a7a426161a9a042ed3f9bd0a7a6","revisions":{"ad27149684cdb3e50276dabcf26243d88c751d0b":{"kind":"REWORK","_number":1,"created":"2025-07-31 09:16:15.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/20/1120/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1120/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1 \u0026\u0026 git checkout -b change-1120 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"040e0d1c308a587ae9a26295eeaa070561befa0d","subject":"Fix broken DHCP options"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 09:06:21.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 09:11:56.000000000","tz":180},"subject":"Fix --dns options for TAP adapter","message":"Fix --dns options for TAP adapter\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas accidentally removed setting of the DHCP_OPTIONS_DHCP_OPTIONAL\nflag when copying --dns options. This flag is required to apply options\nvia DHCP string, which we do for TAP adapter. As a result, --dns options\nstopped working for TAP.\n\nFix by setting this flag when copying --dns options to tuntap_options.\n\nChange-Id: Id95cd14095a03afb3140a03ae96e9f5679e4fe89\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"59fc7e586deed9be18e5c0d669908bd4d4ba5608":{"kind":"REWORK","_number":2,"created":"2025-07-31 09:48:16.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/20/1120/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1120/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2 \u0026\u0026 git checkout -b change-1120 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"040e0d1c308a587ae9a26295eeaa070561befa0d","subject":"Fix broken DHCP options"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 09:06:21.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 09:48:07.000000000","tz":180},"subject":"Fix --dns options for TAP adapter","message":"Fix --dns options for TAP adapter\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas accidentally removed setting of the DHCP_OPTIONS_DHCP_OPTIONAL\nflag when copying --dns options. This flag is required to apply options\nvia DHCP string, which we do for TAP adapter. As a result, --dns options\nstopped working for TAP.\n\nFix by setting this flag when copying --dns options to tuntap_options.\n\nChange-Id: Id95cd14095a03afb3140a03ae96e9f5679e4fe89\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"264fe91660fb1a7a426161a9a042ed3f9bd0a7a6":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2025-07-31 10:55:39.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/20/1120/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/20/1120/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3 \u0026\u0026 git checkout -b change-1120 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/20/1120/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"040e0d1c308a587ae9a26295eeaa070561befa0d","subject":"Fix broken DHCP options"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 10:48:27.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-31 10:53:27.000000000","tz":120},"subject":"Fix --dns options for TAP adapter","message":"Fix --dns options for TAP adapter\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas accidentally removed setting of the DHCP_OPTIONS_DHCP_OPTIONAL\nflag when copying --dns options. This flag is required to apply options\nvia DHCP string, which we do for TAP adapter. As a result, --dns options\nstopped working for TAP.\n\nFix by setting this flag when copying --dns options to tuntap_options.\n\nChange-Id: Id95cd14095a03afb3140a03ae96e9f5679e4fe89\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250731104833.23305-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32436.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
