)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"86fce696fb8c01f7e0b77454db30af16bc9e9e52","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"It has also added a new storage for --dhcp-option. The push-update"},{"line_number":17,"context_line":"code didn\u0027t clear it and as a result, incoming --dhcp-option options"},{"line_number":18,"context_line":"were added to existing once instead of overwriting them."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixed by:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"cc9f9b67_aace83f8","line":18,"updated":"2025-07-31 12:07:39.000000000","message":"*existing ones","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"8be1115c1269ecea57ce09c88345fecb08845c66","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"It has also added a new storage for --dhcp-option. The push-update"},{"line_number":17,"context_line":"code didn\u0027t clear it and as a result, incoming --dhcp-option options"},{"line_number":18,"context_line":"were added to existing once instead of overwriting them."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixed by:"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0cd9cff6_537c22be","line":18,"in_reply_to":"cc9f9b67_aace83f8","updated":"2025-07-31 12:19:28.000000000","message":"Acknowledged","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"86fce696fb8c01f7e0b77454db30af16bc9e9e52","unresolved":true,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixed by:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":" - reseting tuntap DNS options (regression from abovementioned commit)"},{"line_number":23,"context_line":" - clearing dhcp options storage in push-update code"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"GitHub: fixes OpenVPN/openvpn#804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6f40d257_3c5dd855","line":22,"updated":"2025-07-31 12:07:39.000000000","message":"*resetting","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"8be1115c1269ecea57ce09c88345fecb08845c66","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Fixed by:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":" - reseting tuntap DNS options (regression from abovementioned commit)"},{"line_number":23,"context_line":" - clearing dhcp options storage in push-update code"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"GitHub: fixes OpenVPN/openvpn#804"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4febbb73_89ff723d","line":22,"in_reply_to":"6f40d257_3c5dd855","updated":"2025-07-31 12:19:28.000000000","message":"Acknowledged","commit_id":"1e450b160139747bde4e9302875e24df073b9406"}],"src/openvpn/options.c":[{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"86fce696fb8c01f7e0b77454db30af16bc9e9e52","unresolved":true,"context_lines":[{"line_number":3545,"context_line":"    }"},{"line_number":3546,"context_line":""},{"line_number":3547,"context_line":"    const struct dns_server *s \u003d dns-\u003eservers;"},{"line_number":3548,"context_line":"    if (s)"},{"line_number":3549,"context_line":"    {"},{"line_number":3550,"context_line":"        tt-\u003edns_len \u003d 0;"},{"line_number":3551,"context_line":"        tt-\u003edns6_len \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"769a02c7_b70d0065","line":3548,"updated":"2025-07-31 12:07:39.000000000","message":"s will never be NULL here, in that case we\u0027d branched to /* Copy --dhcp-options to tuntap_options */ above already","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"8be1115c1269ecea57ce09c88345fecb08845c66","unresolved":false,"context_lines":[{"line_number":3545,"context_line":"    }"},{"line_number":3546,"context_line":""},{"line_number":3547,"context_line":"    const struct dns_server *s \u003d dns-\u003eservers;"},{"line_number":3548,"context_line":"    if (s)"},{"line_number":3549,"context_line":"    {"},{"line_number":3550,"context_line":"        tt-\u003edns_len \u003d 0;"},{"line_number":3551,"context_line":"        tt-\u003edns6_len \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d5dc85c6_45b16c8c","line":3548,"in_reply_to":"769a02c7_b70d0065","updated":"2025-07-31 12:19:28.000000000","message":"Acknowledged","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"86fce696fb8c01f7e0b77454db30af16bc9e9e52","unresolved":true,"context_lines":[{"line_number":6224,"context_line":"            }"},{"line_number":6225,"context_line":"            o-\u003edisable_nbt \u003d 0;"},{"line_number":6226,"context_line":"            o-\u003edhcp_options \u003d 0;"},{"line_number":6227,"context_line":""},{"line_number":6228,"context_line":"            CLEAR(options-\u003edns_options.from_dhcp);"},{"line_number":6229,"context_line":"#if defined(TARGET_ANDROID)"},{"line_number":6230,"context_line":"            o-\u003ehttp_proxy_port \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"c0668a3d_ef605be7","line":6227,"updated":"2025-07-31 12:07:39.000000000","message":"This code should instead store the DNS related things in `options-\u003edns_options.from_dhcp`. Using `tuntap_options` directly is not how it is done any longer. Instead \"values\" of whatever origin are copied to `tuntap_options` during the postprocess stage if needed.","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"change_message_id":"82a882212693613bdbd1cee3de7fae6ab75ae747","unresolved":false,"context_lines":[{"line_number":6224,"context_line":"            }"},{"line_number":6225,"context_line":"            o-\u003edisable_nbt \u003d 0;"},{"line_number":6226,"context_line":"            o-\u003edhcp_options \u003d 0;"},{"line_number":6227,"context_line":""},{"line_number":6228,"context_line":"            CLEAR(options-\u003edns_options.from_dhcp);"},{"line_number":6229,"context_line":"#if defined(TARGET_ANDROID)"},{"line_number":6230,"context_line":"            o-\u003ehttp_proxy_port \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"d515ce38_997af3de","line":6227,"in_reply_to":"472f0a8d_8ef94cd9","updated":"2025-07-31 12:22:32.000000000","message":"Ah yes, misjudged where this code is actually located, thought it was the regular option processing. All good here.","commit_id":"1e450b160139747bde4e9302875e24df073b9406"},{"author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"8be1115c1269ecea57ce09c88345fecb08845c66","unresolved":false,"context_lines":[{"line_number":6224,"context_line":"            }"},{"line_number":6225,"context_line":"            o-\u003edisable_nbt \u003d 0;"},{"line_number":6226,"context_line":"            o-\u003edhcp_options \u003d 0;"},{"line_number":6227,"context_line":""},{"line_number":6228,"context_line":"            CLEAR(options-\u003edns_options.from_dhcp);"},{"line_number":6229,"context_line":"#if defined(TARGET_ANDROID)"},{"line_number":6230,"context_line":"            o-\u003ehttp_proxy_port \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"472f0a8d_8ef94cd9","line":6227,"in_reply_to":"c0668a3d_ef605be7","updated":"2025-07-31 12:19:28.000000000","message":"but we don\u0027t store anything here - just nullifying tuntap_options and calling add_option(), which does the right thing by storing data in from_dhcp.","commit_id":"1e450b160139747bde4e9302875e24df073b9406"}]}
