)]}'
{"id":"openvpn~1121","triplet_id":"openvpn~master~Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787","project":"openvpn","branch":"master","full_branch":"refs/heads/master","attention_set":{},"removed_from_attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-07-31 12:56:45.000000000","reason":"Change was submitted"},"1000006":{"account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"last_update":"2025-07-31 12:22:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000006\u003e replied on the change","reason_account":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}},"1000003":{"account":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-07-31 12:56:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-07-31 12:56:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787","subject":"Fix DNS options duplication on PUSH_UPDATE","status":"MERGED","created":"2025-07-31 10:56:14.000000000","updated":"2025-07-31 12:56:45.000000000","submitted":"2025-07-31 12:56:45.000000000","submitter":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1121","meta_rev_id":"73d99e32f43fe8b3d61b78e8236159510494d9a9","_number":1121,"virtual_id_number":1121,"owner":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},{"value":0,"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-07-31 10:56:14.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-07-31 10:56:14.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"Frank Lichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-07-31 10:56:14.000000000","updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"real_updated_by":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"Arne Schwabe","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-07-31 12:07:39.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"CC"},{"updated":"2025-07-31 12:23:00.000000000","updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"real_updated_by":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"reviewer":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"state":"REVIEWER"}],"messages":[{"id":"e71270e0cdcf08e6cac4c5a15fc75f60b63a8f73","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 10:56:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a40cc3b9bb88dc839a7f0190b94e8301a2647fd7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 11:21:36.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"86fce696fb8c01f7e0b77454db30af16bc9e9e52","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-31 12:07:39.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"081d973d4c70fb608f1bcb381398322f58e37d39","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 12:19:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"8be1115c1269ecea57ce09c88345fecb08845c66","author":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-07-31 12:19:28.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"82a882212693613bdbd1cee3de7fae6ab75ae747","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-31 12:22:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"6f917cbaa95770b907bd734febe37db460d9c77b","author":{"_account_id":1000006,"name":"Heiko Hund","display_name":"Heiko Hund","email":"heiko@ist.eigentlich.net","username":"d12fk"},"date":"2025-07-31 12:23:00.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"73d99e32f43fe8b3d61b78e8236159510494d9a9","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-07-31 12:56:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"70d4c6776bd563f487add399bd4acf58c5e22334","revisions":{"794bb91443a03a5b691d202cff674bf31619daaa":{"kind":"REWORK","_number":1,"created":"2025-07-31 10:56:14.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/1121/1","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/1121/1","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1 \u0026\u0026 git checkout -b change-1121 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"59fc7e586deed9be18e5c0d669908bd4d4ba5608","subject":"Fix --dns options for TAP adapter"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 10:41:18.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 10:41:18.000000000","tz":180},"subject":"Fix DNS options duplication on PUSH_UPDATE","message":"Fix DNS options duplication on PUSH_UPDATE\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas removed reset of tuntap DNS options. Due to that, incoming --dns\noptions are added to existing ones instead of overwriting them.\n\nIt has also added a new storage for --dhcp-option. The push-update\ncode didn\u0027t clear it and as a result, incoming --dhcp-option options\nwere added to existing once instead of overwriting them.\n\nFixed by:\n\n - reseting tuntap DNS options (regression from abovementioned commit)\n - clearing dhcp options storage in push-update code\n\nChange-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"1e450b160139747bde4e9302875e24df073b9406":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-07-31 11:21:36.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/1121/2","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/1121/2","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2 \u0026\u0026 git checkout -b change-1121 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"264fe91660fb1a7a426161a9a042ed3f9bd0a7a6","subject":"Fix --dns options for TAP adapter"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 10:41:18.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 11:20:11.000000000","tz":180},"subject":"Fix DNS options duplication on PUSH_UPDATE","message":"Fix DNS options duplication on PUSH_UPDATE\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas removed reset of tuntap DNS options. Due to that, incoming --dns\noptions are added to existing ones instead of overwriting them.\n\nIt has also added a new storage for --dhcp-option. The push-update\ncode didn\u0027t clear it and as a result, incoming --dhcp-option options\nwere added to existing once instead of overwriting them.\n\nFixed by:\n\n - reseting tuntap DNS options (regression from abovementioned commit)\n - clearing dhcp options storage in push-update code\n\nGitHub: fixes OpenVPN/openvpn#804\n\nChange-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"417ec12bb9a511b7ce8addbd241dc3f0aa193f9a":{"kind":"REWORK","_number":3,"created":"2025-07-31 12:19:15.000000000","uploader":{"_account_id":1000008,"name":"Lev Stipakov","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/21/1121/3","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/1121/3","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3 \u0026\u0026 git checkout -b change-1121 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"264fe91660fb1a7a426161a9a042ed3f9bd0a7a6","subject":"Fix --dns options for TAP adapter"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 10:41:18.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 12:18:36.000000000","tz":180},"subject":"Fix DNS options duplication on PUSH_UPDATE","message":"Fix DNS options duplication on PUSH_UPDATE\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas removed reset of tuntap DNS options. Due to that, incoming --dns\noptions are added to existing ones instead of overwriting them.\n\nIt has also added a new storage for --dhcp-option. The push-update\ncode didn\u0027t clear it and as a result, incoming --dhcp-option options\nwere added to existing ones instead of overwriting them.\n\nFixed by:\n\n - resetting tuntap DNS options (regression from abovementioned commit)\n - clearing dhcp options storage in push-update code\n\nGitHub: fixes OpenVPN/openvpn#804\n\nChange-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"70d4c6776bd563f487add399bd4acf58c5e22334":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-07-31 12:56:45.000000000","uploader":{"_account_id":1000002,"name":"Gert Doering","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/21/1121/4","fetch":{"anonymous http":{"url":"https://gerrit.openvpn.net/openvpn","ref":"refs/changes/21/1121/4","commands":{"Branch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4 \u0026\u0026 git checkout -b change-1121 FETCH_HEAD","Checkout":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4","Reset To":"git fetch https://gerrit.openvpn.net/openvpn refs/changes/21/1121/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8854550d4da0b29af122723def898d38e6b3fea2","subject":"Update systemd service name param to match command"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-07-31 12:24:05.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-07-31 12:42:29.000000000","tz":120},"subject":"Fix DNS options duplication on PUSH_UPDATE","message":"Fix DNS options duplication on PUSH_UPDATE\n\nCommit\n\n    2dfc4f (\"dns: deal with --dhcp-options when --dns is active\")\n\nhas removed reset of tuntap DNS options. Due to that, incoming --dns\noptions are added to existing ones instead of overwriting them.\n\nIt has also added a new storage for --dhcp-option. The push-update\ncode didn\u0027t clear it and as a result, incoming --dhcp-option options\nwere added to existing ones instead of overwriting them.\n\nFixed by:\n\n - resetting tuntap DNS options (regression from abovementioned commit)\n - clearing dhcp options storage in push-update code\n\nGitHub: fixes OpenVPN/openvpn#804\n\nChange-Id: Ife4d8fc5f8e2183e61226d66a76bbaa02c06f787\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Heiko Hund \u003cheiko@openvpn.net\u003e\nMessage-Id: \u003c20250731122410.12200-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32448.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[]}
