)]}'
{"id":"openvpn~1141","triplet_id":"openvpn~master~Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-06 20:53:20.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-06 20:53:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152","subject":"Review CMocka assertion usage","status":"MERGED","created":"2025-08-08 12:12:25.000000000","updated":"2025-10-06 20:53:20.000000000","submitted":"2025-10-06 20:53:20.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1141","meta_rev_id":"4103ac6dfb10cf8daeca2b50dc77e717414621a2","_number":1141,"virtual_id_number":1141,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-08 12:12:34.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-08 12:12:34.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-06 20:40:56.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"6dfba179e9a4c2838a36404a4d62fa4c31631250","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-08 12:12:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35e5bd275f40eb14b09455cd033ea307422fc631","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-11 13:51:37.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"5a3d2d34bdb67a90dbed4d4e4fe0b0ae8f5c950b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 13:35:26.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"ed5075ae126565fcca876ceb77569a0ff72c5f86","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-06 20:40:56.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4103ac6dfb10cf8daeca2b50dc77e717414621a2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-06 20:53:20.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0e3dd1ccba4612fc461f6bbf0a076eae1033e141","revisions":{"5ff2e675b55a91ba722bb00f0fc91215e13c8a0e":{"kind":"REWORK","_number":1,"created":"2025-08-08 12:12:25.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1141/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1141/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1 \u0026\u0026 git checkout -b change-1141 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"22643742ab3f7aece7271068fc38825d456e893c","subject":"Collect trivial conversion fixes"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-08 11:00:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-08 12:11:32.000000000","tz":120},"subject":"Review CMocka assertion usage","message":"Review CMocka assertion usage\n\nReplace some assert_true calls with more specific\nassertions. This should improve reporting in case\nof problems and also just makes the code nicer.\n\nChange-Id: Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e3881318494f46deda69bd89586a3eeaf1972966":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-08-11 13:51:37.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1141/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1141/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2 \u0026\u0026 git checkout -b change-1141 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"db1fd1a80baa9e44df8ae82f0fd2b56c59195484","subject":"t_client.sh: Do not wait 3 seconds for OpenVPN to come up"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-08 11:00:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-11 13:51:30.000000000","tz":120},"subject":"Review CMocka assertion usage","message":"Review CMocka assertion usage\n\nReplace some assert_true calls with more specific\nassertions. This should improve reporting in case\nof problems and also just makes the code nicer.\n\nChange-Id: Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9da22a26bc913064bf8fcbd90bb712da44260f7a":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-09-24 13:35:26.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/41/1141/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1141/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3 \u0026\u0026 git checkout -b change-1141 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9db98baf657c0aa6f56154019c531535d3d16ded","subject":"Make unit tests -Wconversion clean"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-08 11:00:08.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 13:34:41.000000000","tz":120},"subject":"Review CMocka assertion usage","message":"Review CMocka assertion usage\n\nReplace some assert_true calls with more specific\nassertions. This should improve reporting in case\nof problems and also just makes the code nicer.\n\nChange-Id: Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0e3dd1ccba4612fc461f6bbf0a076eae1033e141":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-10-06 20:53:20.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/41/1141/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/41/1141/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4 \u0026\u0026 git checkout -b change-1141 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/41/1141/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4fa3897915745375c6b832796baf3d7a6a686d43","subject":"mtu: Trivial -Wconversion fix"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-06 20:41:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-06 20:50:51.000000000","tz":120},"subject":"Review CMocka assertion usage","message":"Review CMocka assertion usage\n\nReplace some assert_true calls with more specific\nassertions. This should improve reporting in case\nof problems and also just makes the code nicer.\n\nChange-Id: Ia2f374476c87855bba6c0f9d3e2f28a5fe62a152\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1141\nMessage-Id: \u003c20251006204118.26237-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59243096/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}