)]}'
{"id":"openvpn~1145","triplet_id":"openvpn~master~If66438662bd862a195b2a69c4fa45f63838982b7","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-08-20 18:03:54.000000000","reason":"removed on reply"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-08-20 21:13:11.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-08-20 21:13:11.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"If66438662bd862a195b2a69c4fa45f63838982b7","subject":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file","status":"MERGED","created":"2025-08-20 15:02:41.000000000","updated":"2025-08-20 21:13:11.000000000","submitted":"2025-08-20 21:13:11.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1145","meta_rev_id":"e431de9d76afb2a3162005afb6f340ec905fb1f0","_number":1145,"virtual_id_number":1145,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-20 15:02:42.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-20 15:02:42.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-08-20 15:02:42.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"83dea304746bcfa4b63f4ec7b38b5a8e329730bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-20 15:02:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"268c771547be9b0ef55da0878234a308ab3751da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-20 15:10:39.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"5726b113d917629aeae7f650c66a5755dab7e15b","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-08-20 15:36:34.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"597da6d898b692a4c8adf848d4ce4c1115b982cd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-20 17:21:21.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b3af3234bf1aec751d6f6a3dca586741fc05c5e1","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-08-20 18:03:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"e431de9d76afb2a3162005afb6f340ec905fb1f0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-20 21:13:11.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2d73540316af3986bcb3e162040b5aaef74b1845","revisions":{"edfceee9d1c2030aed4b8f5c5e38bc55c1978a33":{"kind":"REWORK","_number":1,"created":"2025-08-20 15:02:41.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/1145/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1145/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1 \u0026\u0026 git checkout -b change-1145 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"acc8f82fca61ea5478ab0bd16c16fff5c07ec9af","subject":"Collect trivial conversion fixes"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 14:50:56.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 14:50:56.000000000","tz":120},"subject":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file","message":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file\n\nSince commit bd9aa06feb41 (Jan 2015) OpenVPN has allowed to use\n\u0027--dh none\u0027 to disable traditional Diffie Hellman, since more secure\nECDH algorithms are available that do not use explicit DH parameters.\n\nIf configured with a suffiently high securelevel (3+), or if running in\nFIPS mode, OpenSSL 3.5 will refuse 2048 bit DH files, making our tests\nfail.\n\nThus, remove all the DH2048 stuff from our sample configs.\n\nChange-Id: If66438662bd862a195b2a69c4fa45f63838982b7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"01c382c14e4d3ab344644bab590380f2a6c037c3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-20 15:10:39.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/1145/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1145/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2 \u0026\u0026 git checkout -b change-1145 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"acc8f82fca61ea5478ab0bd16c16fff5c07ec9af","subject":"Collect trivial conversion fixes"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 14:50:56.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 15:10:14.000000000","tz":120},"subject":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file","message":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file\n\nSince commit bd9aa06feb41 (Jan 2015) OpenVPN has allowed to use\n\u0027--dh none\u0027 to disable traditional Diffie Hellman, since more secure\nECDH algorithms are available that do not use explicit DH parameters.\n\nIf configured with a suffiently high securelevel (3+), or if running in\nFIPS mode, OpenSSL 3.5 will refuse 2048 bit DH files, making our tests\nfail.\n\nThus, remove all the DH2048 stuff from our sample configs.\n\nGithub: triggered by OpenVPN/openvpn#819\n\nChange-Id: If66438662bd862a195b2a69c4fa45f63838982b7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c1f4fced4f24d61cb6bf8cae18b5280052e607a8":{"kind":"REWORK","_number":3,"created":"2025-08-20 17:21:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/1145/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1145/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3 \u0026\u0026 git checkout -b change-1145 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"acc8f82fca61ea5478ab0bd16c16fff5c07ec9af","subject":"Collect trivial conversion fixes"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 14:50:56.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 17:20:44.000000000","tz":120},"subject":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file","message":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file\n\nSince commit bd9aa06feb41 (Jan 2015) OpenVPN has allowed to use\n\u0027--dh none\u0027 to disable traditional Diffie Hellman, since more secure\nECDH algorithms are available that do not use explicit DH parameters.\n\nIf configured with a suffiently high securelevel (3+), or if running in\nFIPS mode, OpenSSL 3.5 will refuse 2048 bit DH files, making our tests\nfail.\n\nThus, remove all the DH2048 stuff from our sample configs.\n\nGithub: triggered by OpenVPN/openvpn#819\n\nChange-Id: If66438662bd862a195b2a69c4fa45f63838982b7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"2d73540316af3986bcb3e162040b5aaef74b1845":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-08-20 21:13:11.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/45/1145/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/45/1145/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4 \u0026\u0026 git checkout -b change-1145 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/45/1145/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"72a0e6f94f16a6dcfe2b445758d42dedaba11b92","subject":"dns: fix systemd dns-updown script"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 17:54:53.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-20 21:11:33.000000000","tz":120},"subject":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file","message":"Remove use of \u0027dh dh2048.pem\u0027 from sample configs, remove \u0027dh2048.pem\u0027 file\n\nSince commit bd9aa06feb41 (Jan 2015) OpenVPN has allowed to use\n\u0027--dh none\u0027 to disable traditional Diffie Hellman, since more secure\nECDH algorithms are available that do not use explicit DH parameters.\n\nIf configured with a suffiently high securelevel (3+), or if running in\nFIPS mode, OpenSSL 3.5 will refuse 2048 bit DH files, making our tests\nfail.\n\nThus, remove all the DH2048 stuff from our sample configs.\n\nGithub: triggered by OpenVPN/openvpn#819\n\nChange-Id: If66438662bd862a195b2a69c4fa45f63838982b7\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250820175459.11227-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32632.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}