)]}'
{"id":"openvpn~1151","triplet_id":"openvpn~master~Ic30612971367a4aa54ca89f93452efc172d4f4e2","project":"openvpn","branch":"master","topic":"atoi","attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2026-02-12 12:30:32.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2026-08-14 08:28:33.000000000","reason":"Someone else replied on the change"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ic30612971367a4aa54ca89f93452efc172d4f4e2","subject":"options: Introduce boolean_flag() and review usages of atoi_warn","status":"NEW","created":"2025-08-22 13:45:17.000000000","updated":"2026-08-14 08:28:33.000000000","submit_type":"CHERRY_PICK","submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eab18667e04fc46cfb5b52d2aa4228e5bbda0945","_number":1151,"virtual_id_number":1151,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":2,"date":"2026-08-14 08:28:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-22 13:45:19.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-22 13:45:19.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2026-08-14 08:28:33.000000000","updated_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"reviewer":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"state":"REVIEWER"}],"messages":[{"id":"8f90808b02f60bd86f77e553df03025a272edbd8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-22 13:45:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6b92ec1ba6177f660f5ea9b3f924db048a906821","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-22 15:51:51.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"6e51329cfafd1932489b54f4ad62f4b6bc92cb68","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-22 16:25:13.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"05aa93fdfa99480809585bf398f85c225adefb0f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-02 12:11:52.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"65e821ae490be771c5846ba2b3195b8dbd0d575a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-02 12:15:38.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"27659208a82c95d8241b72bca216cff680651823","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 13:32:11.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":5},{"id":"69844576d20060866111c65179ca0dd6a86457a1","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 13:33:58.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"f2c82b9167b2e428b77def711f48448354a7d47c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-09 16:40:30.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"77e1c95e820389ee7f2719e06b97d04691875442","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-12 12:22:48.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.","accounts_in_message":[],"_revision_number":8},{"id":"1ef33962cd10acd13fceea9d5658ab69677d4c04","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-12 12:29:48.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"6e7b33dcef70d7d0c8fab07d442c997323468315","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2026-02-12 12:30:32.000000000","message":"Patch Set 9:\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":9},{"id":"eab18667e04fc46cfb5b52d2aa4228e5bbda0945","author":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"},"date":"2026-08-14 08:28:33.000000000","message":"Patch Set 9: Code-Review+2","accounts_in_message":[],"_revision_number":9}],"current_revision_number":9,"current_revision":"b609470e7d0d6d80081897b55725e09f75e403ad","revisions":{"0dc50eee72e2a1a86c504b538c174d09d7cb79a8":{"kind":"REWORK","_number":1,"created":"2025-08-22 13:45:17.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cde57d507385b75f1dfcc07968d81dc83e5a9716","subject":"options: Introduce atoi_constrained and review usages of atoi_warn"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:43:54.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"422e536a0d3be67b10d594bd711298baf5983c66":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-08-22 15:51:51.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eabf92363395172a587d9a0411fd706b612d9fa2","subject":"options: Introduce atoi_constrained and review usages of atoi_warn"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:51:29.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"6c30c822e85cf8deb1fc7b85d5291a1f394dbec1":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-08-22 16:25:13.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a227dc0770380717b88cb2fba677c77dffbee58d","subject":"options: Introduce atoi_constrained and review usages of atoi_warn"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 16:23:58.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"a2161048021eac0a8ce36cfcfdd5fc7fdeabc3e0":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-09-02 12:11:52.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5ae6cf3052a086ad23037b4b5a8b717bba009bec","subject":"options: Introduce atoi_constrained and review usages of atoi_warn"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-02 12:09:56.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"89cf169533f9c00adc05d5b602a5e697b5692cb3":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-09-02 12:15:38.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1544e6cd765ae22d3a044a8270dc05fbfe677a43","subject":"options: Introduce atoi_constrained and review usages of atoi_warn"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-02 12:15:21.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c12226afd3480317cd21692fff13e09e819dab5f":{"kind":"REWORK","_number":6,"created":"2025-09-24 13:33:58.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b681daac669ff06d0fbc55f8db2732906e0f3f61","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 13:33:42.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"58771b554d4642dfad3e94f45b9d13106654206c":{"kind":"REWORK","_number":7,"created":"2025-10-09 16:40:30.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/7","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/7","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9589606d230eae7b722f1eb54b303b2a221aab38","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-09 16:40:02.000000000","tz":120},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b74be1e6b569d82d13f7382c5339a1bf69d60194":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2026-02-12 12:22:48.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/8","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/8","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee1577744fb09af760dc319d57746e6abc55db85","subject":"OpenVPN Release 2.7.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-12 12:22:10.000000000","tz":60},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"b609470e7d0d6d80081897b55725e09f75e403ad":{"kind":"REWORK","_number":9,"created":"2026-02-12 12:29:48.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/51/1151/9","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/51/1151/9","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9 \u0026\u0026 git checkout -b change-1151 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/51/1151/9 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ee1577744fb09af760dc319d57746e6abc55db85","subject":"OpenVPN Release 2.7.0"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 13:26:39.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2026-02-12 12:28:43.000000000","tz":60},"subject":"options: Introduce boolean_flag() and review usages of atoi_warn","message":"options: Introduce boolean_flag() and review usages of atoi_warn\n\nThis uses atoi_constrained. Note that this makes the tests\nstricter since previously any non-zero integer would be\ninterpreted as \"true\".\n\nChange-Id: Ic30612971367a4aa54ca89f93452efc172d4f4e2\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"}},"requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000053,"name":"razvanc","display_name":"Razvan Cojocaru","email":"razvanc@mailbox.org","username":"razvanc"}}]},{"rule_name":"checks~ChecksSubmitRule","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"All required checks must pass","type":"checks_pass"}]}],"submit_requirements":[{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"failing_atoms":[]}},{"name":"checks~ChecksSubmitRule","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:checks~ChecksSubmitRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["checks~ChecksSubmitRule"]}}]}
