)]}'
{"src/openvpn/options.c":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"bbe3dbfdd0f6f62175bf57c74acc615a67e12f86","unresolved":true,"context_lines":[{"line_number":7994,"context_line":"    else if (streq(p[0], \"max-routes-per-client\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":7995,"context_line":"    {"},{"line_number":7996,"context_line":"        VERIFY_PERMISSION(OPT_P_INHERIT);"},{"line_number":7997,"context_line":"        atoi_constrained(p[1], \u0026options-\u003emax_routes_per_client, p[0], 1, INT_MAX, msglevel);"},{"line_number":7998,"context_line":"    }"},{"line_number":7999,"context_line":"    else if (streq(p[0], \"client-cert-not-required\") \u0026\u0026 !p[1])"},{"line_number":8000,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b09f5803_fa7ecbdd","line":7997,"updated":"2025-09-26 17:08:44.000000000","message":"This changes the program behavior. Before, it silently corrected max_routes_per_client to 1, now it exits with an error.\n\nProbably a good change, but I\u0027m not sure if you intended this commit to change behavior.","commit_id":"b681daac669ff06d0fbc55f8db2732906e0f3f61"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"f00db36100a18754db7b6380fc86c301cee3868d","unresolved":false,"context_lines":[{"line_number":7994,"context_line":"    else if (streq(p[0], \"max-routes-per-client\") \u0026\u0026 p[1] \u0026\u0026 !p[2])"},{"line_number":7995,"context_line":"    {"},{"line_number":7996,"context_line":"        VERIFY_PERMISSION(OPT_P_INHERIT);"},{"line_number":7997,"context_line":"        atoi_constrained(p[1], \u0026options-\u003emax_routes_per_client, p[0], 1, INT_MAX, msglevel);"},{"line_number":7998,"context_line":"    }"},{"line_number":7999,"context_line":"    else if (streq(p[0], \"client-cert-not-required\") \u0026\u0026 !p[1])"},{"line_number":8000,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"18e489ea_91e53016","line":7997,"in_reply_to":"b09f5803_fa7ecbdd","updated":"2025-10-09 20:59:38.000000000","message":"I think this is acceptable.  There might be a config somewhere that has `max-routes-per-client 0` in it, auto-upgraded to `1`, but it does not make any sense whatsoever... \"do not use options you do not understand\".","commit_id":"b681daac669ff06d0fbc55f8db2732906e0f3f61"}]}