)]}'
{"id":"openvpn~1154","triplet_id":"openvpn~master~I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61","project":"openvpn","branch":"master","topic":"atoi","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-14 13:26:23.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-14 13:26:23.000000000","reason":"Change was submitted"}},"hashtags":["mailsubmitted"],"change_id":"I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61","subject":"options: Factor out usages of strtoll and atoll","status":"MERGED","created":"2025-08-22 15:51:51.000000000","updated":"2025-09-14 13:26:23.000000000","submitted":"2025-09-14 13:26:23.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1154-atoi","meta_rev_id":"e5bbfa16b5c3c7340bb6973beef94694fb8fdc65","_number":1154,"virtual_id_number":1154,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-22 15:51:54.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-22 15:51:54.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-11 15:49:15.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"}],"messages":[{"id":"e1fe7491a1cc6064fd88c1731c7676e00f9891f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-22 15:51:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ba887b9d0a8850279536070026ccc04855828af7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-22 16:25:13.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"2cdba202a18dbe1b9a7671cd653780364fbb3be6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-02 12:11:52.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"d308359788da8035982c66dd41d21fc520f75781","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-02 12:15:38.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"dfbf0ea751f61618c10f0faa56d1ba1593dc9922","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-09-11 15:49:15.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"02d2415d439ceaa583b04d352c4b415f3ac86f98","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-12 13:06:40.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":4},{"id":"e5bbfa16b5c3c7340bb6973beef94694fb8fdc65","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-14 13:26:23.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"10c42c7407ccc467f75e25f752275e412ff35a91","revisions":{"6d3305041c452ed5ac1ef0a7f4321337f29adf50":{"kind":"REWORK","_number":1,"created":"2025-08-22 15:51:51.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1154/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1154/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1 \u0026\u0026 git checkout -b change-1154 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"d13f85710cc7d4dc705ba82207b01379b4b52273","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:48:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:51:29.000000000","tz":120},"subject":"options: Factor out usages of strtoll and atoll","message":"options: Factor out usages of strtoll and atoll\n\nThis covers the cases where we actually want to\nallow numbers \u003e 2^31\n\nChange-Id: I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"c49c68be0ca0bcc558c447625ffa031bcf57f768":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-08-22 16:25:13.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1154/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1154/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2 \u0026\u0026 git checkout -b change-1154 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c47391e7788e83f0523c4aa013c57e5b99a51848","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:48:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 16:23:58.000000000","tz":120},"subject":"options: Factor out usages of strtoll and atoll","message":"options: Factor out usages of strtoll and atoll\n\nThis covers the cases where we actually want to\nallow numbers \u003e 2^31\n\nChange-Id: I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"e5a0dd1ce3c5d459d10844476e4d9032d5bdbc78":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-09-02 12:11:52.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1154/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1154/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3 \u0026\u0026 git checkout -b change-1154 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1fec18232ec02c544535377a678081fcd99e783d","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:48:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-02 12:11:39.000000000","tz":120},"subject":"options: Factor out usages of strtoll and atoll","message":"options: Factor out usages of strtoll and atoll\n\nThis covers the cases where we actually want to\nallow numbers \u003e 2^31\n\nChange-Id: I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"138f4364477d508323655cb9a52f184fdf4b67ae":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-09-02 12:15:38.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/54/1154/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1154/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4 \u0026\u0026 git checkout -b change-1154 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"eaeecd2ebd1a65d4a0e41d2d4b3e242ff06de0f0","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-22 15:48:43.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-02 12:15:21.000000000","tz":120},"subject":"options: Factor out usages of strtoll and atoll","message":"options: Factor out usages of strtoll and atoll\n\nThis covers the cases where we actually want to\nallow numbers \u003e 2^31\n\nChange-Id: I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"10c42c7407ccc467f75e25f752275e412ff35a91":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-09-14 13:26:23.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/54/1154/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/54/1154/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5 \u0026\u0026 git checkout -b change-1154 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/54/1154/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"dd20c79d9d5dc38370eb8c6d796a558a269705ba","subject":"ssl_common: Make sure ssl flags are treated as unsigned"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-11 20:15:00.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-14 12:25:02.000000000","tz":120},"subject":"options: Factor out usages of strtoll and atoll","message":"options: Factor out usages of strtoll and atoll\n\nThis covers the cases where we actually want to\nallow numbers \u003e 2^31\n\nChange-Id: I454126b3f8fa9d14501f6c4b1ed9ce7b2904be61\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nURL: https://gerrit.openvpn.net/c/openvpn/+/1154\nMessage-Id: \u003c20250911201505.25582-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32858.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}