)]}'
{"id":"openvpn~1156","triplet_id":"openvpn~master~I1e623b4a836f7216750867243299c7e4d0bd32d0","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-08-26 12:54:51.000000000","reason":"removed on reply"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-08-27 19:03:20.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-08-27 19:03:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1e623b4a836f7216750867243299c7e4d0bd32d0","subject":"Introduce env variables to communicate desired gateway redirection to NM.","status":"MERGED","created":"2025-08-23 20:16:11.000000000","updated":"2025-08-27 19:03:20.000000000","submitted":"2025-08-27 19:03:20.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1156","meta_rev_id":"b061fd3a937f43ff63995bb17e8dd9e0eb23af33","_number":1156,"virtual_id_number":1156,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-23 20:16:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-23 20:16:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-08-23 20:16:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"7a6e1bc70d8631cce9887afc16969df5a3c88d4c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-23 20:16:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e23af4e9efd8729b1b897ea2ffa0c1a1cc619b56","author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"date":"2025-08-26 12:54:51.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b061fd3a937f43ff63995bb17e8dd9e0eb23af33","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-27 19:03:20.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1cc3525b46a3ef8b064e44b0ea33d84a39a479e9","revisions":{"2c73ca0edaf7b134ee05043348933d78f109ce1c":{"kind":"REWORK","_number":1,"created":"2025-08-23 20:16:11.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/56/1156/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/1156/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1 \u0026\u0026 git checkout -b change-1156 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"518e122b42739b0dbb54e7169a8a3aadb4773125","subject":"Check message id/acked ids too when doing sessionid cookie checks"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-23 16:44:34.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-23 20:13:26.000000000","tz":120},"subject":"Introduce env variables to communicate desired gateway redirection to NM.","message":"Introduce env variables to communicate desired gateway redirection to NM.\n\nWhen run under Network Manager control, OpenVPN is not allowed to\ncontrol routing.  Instead, NM uses the OpenVPN-set environment variables\n(\"route_network_1\" etc) to set up routes as requested.  This method never\nworked properly for \"redirect-gateway\", as the information was not made\navailable in environment variables.\n\nIntroduce new env vars:\n\n route_redirect_gateway_ipv4\n route_redirect_gateway_ipv6\n\nto communicate desired state:\n\n \u003cnot set\u003e \u003d no gateway redirection desired\n 1 \u003d \"redirect-gateway for that protocol in question\"\n 2 \u003d \"include block-local to redirect the local LAN as well\"\n\nWe intentionally do not expose all the IPv4 flags (\"local\", \"def1\", ...)\nas this is really internal OpenVPN historical cruft.\n\nChange-Id: I1e623b4a836f7216750867243299c7e4d0bd32d0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"1cc3525b46a3ef8b064e44b0ea33d84a39a479e9":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-08-27 19:03:20.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/56/1156/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/56/1156/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2 \u0026\u0026 git checkout -b change-1156 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/56/1156/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3671c420f60004d694ce4970cf333db79a4aed29","subject":"route: Make sure various route flags are treated as unsigned"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-26 18:40:38.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-27 19:02:18.000000000","tz":120},"subject":"Introduce env variables to communicate desired gateway redirection to NM.","message":"Introduce env variables to communicate desired gateway redirection to NM.\n\nWhen run under Network Manager control, OpenVPN is not allowed to\ncontrol routing.  Instead, NM uses the OpenVPN-set environment variables\n(\"route_network_1\" etc) to set up routes as requested.  This method never\nworked properly for \"redirect-gateway\", as the information was not made\navailable in environment variables.\n\nIntroduce new env vars:\n\n route_redirect_gateway_ipv4\n route_redirect_gateway_ipv6\n\nto communicate desired state:\n\n \u003cnot set\u003e \u003d no gateway redirection desired\n 1 \u003d \"redirect-gateway for that protocol in question\"\n 2 \u003d \"include block-local to redirect the local LAN as well\"\n\nWe intentionally do not expose all the IPv4 flags (\"local\", \"def1\", ...)\nas this is really internal OpenVPN historical cruft.\n\nChange-Id: I1e623b4a836f7216750867243299c7e4d0bd32d0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Arne Schwabe \u003carne-openvpn@rfc2549.org\u003e\nMessage-Id: \u003c20250826184046.21434-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32686.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}