)]}'
{"id":"openvpn~1157","triplet_id":"openvpn~master~I7bc7de284fdbfd4be26a907ecd5c21c075bc5ac4","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-08-29 07:33:51.000000000","reason":"Change was abandoned"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-08-29 07:33:51.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I7bc7de284fdbfd4be26a907ecd5c21c075bc5ac4","subject":"Don\u0027t call bytecount client logic in server mode","status":"ABANDONED","created":"2025-08-27 11:50:22.000000000","updated":"2025-08-29 07:33:51.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"eb7b4e1738b9513b2f2f68abc808212774801271","_number":1157,"virtual_id_number":1157,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-27 11:50:22.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-27 11:50:22.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-08-27 11:50:22.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"06901d27847c27f7760da13b0d8f6a3109b3ad82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-08-27 11:50:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7079c1125f8d579441467bfb892af440e9b02555","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-08-27 11:50:58.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"eb7b4e1738b9513b2f2f68abc808212774801271","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-08-29 07:33:51.000000000","message":"Abandoned\n\nWill be superceded","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"efa68e6a5b1188a1c8aee1b1034c687fcb0bc4b8","revisions":{"5d6e4407397a7f848fc9d9d3f447690ba69e9a37":{"kind":"REWORK","_number":1,"created":"2025-08-27 11:50:22.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/57/1157/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/57/1157/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1 \u0026\u0026 git checkout -b change-1157 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6841905d757cb35961f147c8a75d4f590e3d1ab","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:49:58.000000000","tz":180},"subject":"Don\u0027t call bytecount client logic in server mode","message":"Don\u0027t call bytecount client logic in server mode\n\nCalling this in server mode is wrong because:\n\n - we only output those counters via management interface\n (\u003eBYTECOUT:) in client mode, so in server mode this is no-op\n\n - the timer callback to fetch DCO stats is triggerer\n independenty for each peer. It is a waste of resources in server mode\n where we could fetch stats for all peers with the single ioctl.\n\nChange-Id: I7bc7de284fdbfd4be26a907ecd5c21c075bc5ac4\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"efa68e6a5b1188a1c8aee1b1034c687fcb0bc4b8":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-27 11:50:58.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/57/1157/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/57/1157/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2 \u0026\u0026 git checkout -b change-1157 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/57/1157/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6841905d757cb35961f147c8a75d4f590e3d1ab","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:50:44.000000000","tz":180},"subject":"Don\u0027t call bytecount client logic in server mode","message":"Don\u0027t call bytecount client logic in server mode\n\nCalling this in server mode is wrong because:\n\n - we only output those counters via management interface\n (\u003eBYTECOUNT:) in client mode, so in server mode this is no-op\n\n - the timer callback to fetch DCO stats is triggerer\n independenty for each peer. It is a waste of resources in server mode\n where we could fetch stats for all peers with the single ioctl.\n\nChange-Id: I7bc7de284fdbfd4be26a907ecd5c21c075bc5ac4\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}