)]}'
{"id":"openvpn~1159","triplet_id":"openvpn~master~I7393459b975fb9b3e0a42743f58645f769d1be5a","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-08-31 16:27:28.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-08-31 16:27:28.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7393459b975fb9b3e0a42743f58645f769d1be5a","subject":"socket: Create socket_util with non-socket functions","status":"MERGED","created":"2025-08-28 15:52:31.000000000","updated":"2025-08-31 16:27:28.000000000","submitted":"2025-08-31 16:27:28.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1159","meta_rev_id":"bee138e053eada2e4d29b1579433f0c37091a01e","_number":1159,"virtual_id_number":1159,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-28 15:52:31.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-28 15:52:31.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-08-31 15:59:07.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"ce3d47a57df24323c28e4c44f8f3d5b02ddcf97f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-08-28 15:52:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f2c72d7363fddfa65f230f8970e63aafa3c21b16","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-31 15:59:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"bee138e053eada2e4d29b1579433f0c37091a01e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-08-31 16:27:28.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cdd61ffbccfcc81b560d2bec54c9a431ab6a025a","revisions":{"573cae196f8abef895c0d055d33c6df6e8243939":{"kind":"REWORK","_number":1,"created":"2025-08-28 15:52:31.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/59/1159/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1159/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1 \u0026\u0026 git checkout -b change-1159 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1cc3525b46a3ef8b064e44b0ea33d84a39a479e9","subject":"Introduce env variables to communicate desired gateway redirection to NM."}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-28 15:34:41.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-28 15:50:16.000000000","tz":120},"subject":"socket: Create socket_util with non-socket functions","message":"socket: Create socket_util with non-socket functions\n\nThis extracts a lot of the helper functions that do not\nactually work on sockets, but instead on addresses or\nsimilar.\n\nThis includes\n\n- openvpn_getaddrinfo and related functions\n- print_*\n- setenv_*\n\nAnd lots of the inline functions.\n\nThis move will make it easier to add unit tests\nfor these moved functions.\n\nChange-Id: I7393459b975fb9b3e0a42743f58645f769d1be5a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"cdd61ffbccfcc81b560d2bec54c9a431ab6a025a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-08-31 16:27:28.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/59/1159/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/59/1159/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2 \u0026\u0026 git checkout -b change-1159 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/59/1159/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1cc3525b46a3ef8b064e44b0ea33d84a39a479e9","subject":"Introduce env variables to communicate desired gateway redirection to NM."}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-08-31 15:59:32.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-08-31 16:03:55.000000000","tz":120},"subject":"socket: Create socket_util with non-socket functions","message":"socket: Create socket_util with non-socket functions\n\nThis extracts a lot of the helper functions that do not\nactually work on sockets, but instead on addresses or\nsimilar.\n\nThis includes\n\n- openvpn_getaddrinfo and related functions\n- print_*\n- setenv_*\n\nAnd lots of the inline functions.\n\nThis move will make it easier to add unit tests\nfor these moved functions.\n\nChange-Id: I7393459b975fb9b3e0a42743f58645f769d1be5a\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250831155939.29240-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32727.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}