)]}'
{"id":"openvpn~1162","triplet_id":"openvpn~master~I43a93f0d84f01fd808a64115e1b8c3b806706491","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-02 15:28:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-02 15:28:45.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-09-02 15:28:45.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-09-02 15:28:45.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I43a93f0d84f01fd808a64115e1b8c3b806706491","subject":"Refactor management bytecount tracking","status":"MERGED","created":"2025-08-29 09:46:52.000000000","updated":"2025-09-02 15:28:45.000000000","submitted":"2025-09-02 15:28:45.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1162","meta_rev_id":"f88f1e468e24b1a08dd35d2273d0e13aa399e5c0","_number":1162,"virtual_id_number":1162,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-08-29 09:46:52.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-08-29 09:46:52.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-08-29 09:46:52.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-08-29 14:25:36.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"state":"REVIEWER"},{"updated":"2025-09-02 10:35:44.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"7972db41853f6a28c8d8aa19eb20f0b9da5085c5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-08-29 09:46:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"49ac4fd47dc6ffe929d78da3ebad5aabfd0f6fde","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-08-29 14:25:36.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5ee3117dcf2babd07f38d0948f9dc8880ba82b6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-02 08:09:52.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":2},{"id":"55830cc54a0c98689dbb096db8252caecefe021a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-02 08:35:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6b1c119936db8d4ce0cf90f12eef0ee7cf13b029","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 10:35:44.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"f88f1e468e24b1a08dd35d2273d0e13aa399e5c0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 15:28:45.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"da309c1e8bed7b9c25e800499400c8ad908276db","revisions":{"21192ab9a2ed891931755f450a2be4b75d9d006a":{"kind":"REWORK","_number":1,"created":"2025-08-29 09:46:52.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/62/1162/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/1162/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1 \u0026\u0026 git checkout -b change-1162 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6841905d757cb35961f147c8a75d4f590e3d1ab","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-29 07:42:51.000000000","tz":180},"subject":"Refactor management bytecount tracking","message":"Refactor management bytecount tracking\n\nThere are few issues with it:\n\n - when using DCO, the server part doesn\u0027t output BYTECOUNT_CLI\n since process_incoming_link_part1/process_outgoing_link are not called\n\n - when using DCO, the server part applies bytecount timer to the each\n connection, unneccessary making too many calls to the kernel and also\n uses incorect BYTECOUNT output.\n\n - client part outputs counters using timer, server part utilizes\n traffic activity -\u003e inconsistency\n\nFollowing changes have been made:\n\n - Use timer to output counters in client and server mode. Code which\n deals with bytecount on traffic activity has been removed. This unifies\n DCO and non-DCO, as well as client and server mode\n\n - In server mode, peers stats are fetched with the single ioctl call\n\n - Per-packet stats are not persisted anymore in the client mode during\n   traffic activity. Instead cumulative stats (including DCO stats) are\n   persisted when the session closes.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/820\n\nChange-Id: I43a93f0d84f01fd808a64115e1b8c3b806706491\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"e61bd8b5fc992c2198fb787064c5e7e17d35cb7d":{"kind":"REWORK","_number":2,"created":"2025-09-02 08:09:52.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/62/1162/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/1162/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2 \u0026\u0026 git checkout -b change-1162 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6841905d757cb35961f147c8a75d4f590e3d1ab","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-02 08:02:30.000000000","tz":180},"subject":"Refactor management bytecount tracking","message":"Refactor management bytecount tracking\n\nThere are few issues with it:\n\n - when using DCO, the server part doesn\u0027t output BYTECOUNT_CLI\n since process_incoming_link_part1/process_outgoing_link are not called\n\n - when using DCO, the server part applies bytecount timer to the each\n connection, unneccessary making too many calls to the kernel and also\n uses incorect BYTECOUNT output.\n\n - client part outputs counters using timer, server part utilizes\n traffic activity -\u003e inconsistency\n\nFollowing changes have been made:\n\n - Use timer to output counters in client and server mode. Code which\n deals with bytecount on traffic activity has been removed. This unifies\n DCO and non-DCO, as well as client and server mode\n\n - In server mode, peers stats are fetched with the single ioctl call\n\n - Per-packet stats are not persisted anymore in the client mode during\n   traffic activity. Instead cumulative stats (including DCO stats) are\n   persisted when the session closes.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/820\n\nChange-Id: I43a93f0d84f01fd808a64115e1b8c3b806706491\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"dabafe77717d72cc280cd210b3ceb2908a296d81":{"kind":"REWORK","_number":3,"created":"2025-09-02 08:35:56.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/62/1162/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/1162/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3 \u0026\u0026 git checkout -b change-1162 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"b6841905d757cb35961f147c8a75d4f590e3d1ab","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-08-27 11:15:07.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-02 08:35:11.000000000","tz":180},"subject":"Refactor management bytecount tracking","message":"Refactor management bytecount tracking\n\nThere are few issues with it:\n\n - when using DCO, the server part doesn\u0027t output BYTECOUNT_CLI\n since process_incoming_link_part1/process_outgoing_link are not called\n\n - when using DCO, the server part applies bytecount timer to the each\n connection, unneccessary making too many calls to the kernel and also\n uses incorect BYTECOUNT output.\n\n - client part outputs counters using timer, server part utilizes\n traffic activity -\u003e inconsistency\n\nFollowing changes have been made:\n\n - Use timer to output counters in client and server mode. Code which\n deals with bytecount on traffic activity has been removed. This unifies\n DCO and non-DCO, as well as client and server mode\n\n - In server mode, peers stats are fetched with the single ioctl call\n\n - Per-packet stats are not persisted anymore in the client mode during\n   traffic activity. Instead cumulative stats (including DCO stats) are\n   persisted when the session closes.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/820\n\nChange-Id: I43a93f0d84f01fd808a64115e1b8c3b806706491\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"da309c1e8bed7b9c25e800499400c8ad908276db":{"kind":"REWORK","_number":4,"created":"2025-09-02 15:28:45.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/62/1162/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/62/1162/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4 \u0026\u0026 git checkout -b change-1162 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/62/1162/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"6d450085c6a66d0c9e59eafddb83759166fb48c7","subject":"dco-win: add support for multipeer stats"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-02 10:36:01.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-02 15:27:33.000000000","tz":120},"subject":"Refactor management bytecount tracking","message":"Refactor management bytecount tracking\n\nThere are few issues with it:\n\n - when using DCO, the server part doesn\u0027t output BYTECOUNT_CLI since\n   process_incoming_link_part1/process_outgoing_link are not called\n\n - when using DCO, the server part applies bytecount timer to the each\n   connection, unneccessary making too many calls to the kernel and also\n   uses incorrect BYTECOUNT output.\n\n - client part outputs counters using timer, server part utilizes\n   traffic activity -\u003e inconsistency\n\nFollowing changes have been made:\n\n - Use timer to output counters in client and server mode. Code which\n   deals with bytecount on traffic activity has been removed. This unifies\n   DCO and non-DCO, as well as client and server mode\n\n - In server mode, peers stats are fetched with the single ioctl call\n\n - Per-packet stats are not persisted anymore in the client mode during\n   traffic activity. Instead cumulative stats (including DCO stats) are\n   persisted when the session closes.\n\nGitHub: closes OpenVPN/openvpn#820\n\nChange-Id: I43a93f0d84f01fd808a64115e1b8c3b806706491\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250902103606.22181-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59228150/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}