)]}'
{"id":"openvpn~1166","triplet_id":"openvpn~master~I40c11864745cc1619cb9cbf490b168f90feb5eac","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-02 17:00:59.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-02 17:00:59.000000000","reason":"Change was submitted"},"1000041":{"account":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"last_update":"2025-09-02 17:00:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I40c11864745cc1619cb9cbf490b168f90feb5eac","subject":"dco_linux: validate tun interface before fetching stats","status":"MERGED","created":"2025-09-02 14:55:07.000000000","updated":"2025-09-02 17:00:59.000000000","submitted":"2025-09-02 17:00:59.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1166","meta_rev_id":"811d53bd731b9be46fa6af7f38e6959a63c05de6","_number":1166,"virtual_id_number":1166,"owner":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-02 14:55:08.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-02 14:55:08.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-02 14:55:08.000000000","updated_by":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-02 15:08:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"359814f1e57872cb0561d7c423566e1bca219e95","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-09-02 14:55:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad9fe00414f63a55f890192b5725678bd8bb4a09","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 15:08:11.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"98cee57b4f48b0ed5a8a3f7bfcfd5576306ee8e3","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 15:46:44.000000000","message":"Patch Set 1: Code-Review-2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"eabbf35dc26e0ea50cc621cf23a9ce02f43fdcfc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"date":"2025-09-02 16:26:30.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3cfa11b2c9de2e5002afd0f78d05e1aa89034b63","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 16:45:05.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"811d53bd731b9be46fa6af7f38e6959a63c05de6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-02 17:00:59.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"14ced61eef89797e606c3b7600adc4da83a336f4","revisions":{"bf730073fbce9128fa141afd3ff7bd543eb70236":{"kind":"REWORK","_number":1,"created":"2025-09-02 14:55:07.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/66/1166/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1166/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1 \u0026\u0026 git checkout -b change-1166 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"10476e240fcbaa1240ee04e2a6ae52a9cc0cea14","subject":"forward: Make sure pip flags are treated as unsigned"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-09-02 14:19:05.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-09-02 14:40:48.000000000","tz":120},"subject":"dco_linux: validate tun interface before fetching stats","message":"dco_linux: validate tun interface before fetching stats\n\nIf dco_get_peer_stats() is called with an uninitialized c-\u003ec1.tuntap it\nresults in a segfault. This issue happens when a client who has not\nconnected to any server:\n  - has --management and exits,\n  - has --management and a management interface client issues either\n    `bytecount` or `status` or\n  - if SIGUSR2 is sent to it.\n\nAdd a check to ensure the tun interface was set up before attempting to\nretrieve peer statistics.\n\nChange-Id: I40c11864745cc1619cb9cbf490b168f90feb5eac\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"5b91a733f810e1107948f1f642b0a320c69d74e2":{"kind":"REWORK","_number":2,"created":"2025-09-02 16:26:30.000000000","uploader":{"_account_id":1000041,"name":"ralf_lici","display_name":"Ralf Lici","email":"ralf@mandelbit.com","username":"ralf_lici"},"ref":"refs/changes/66/1166/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1166/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2 \u0026\u0026 git checkout -b change-1166 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3bc0b2d0aea742640a1acf97fc4b41726b88ce96","subject":"management: resync timer on bytecount interval change"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-09-02 14:19:05.000000000","tz":120},"committer":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-09-02 16:24:43.000000000","tz":120},"subject":"dco_linux: validate tun interface before fetching stats","message":"dco_linux: validate tun interface before fetching stats\n\nIf dco_get_peer_stats() is called with an uninitialized c-\u003ec1.tuntap it\nresults in a segfault. This issue happens when a client who has not\nconnected to any server:\n  - has --management and exits,\n  - has --management and a management interface client issues either\n    `bytecount` or `status` or\n  - if SIGUSR2 is sent to it.\n\nAdd a check to ensure the tun interface was set up before attempting to\nretrieve peer statistics.\n\nChange-Id: I40c11864745cc1619cb9cbf490b168f90feb5eac\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\n"},"branch":"refs/heads/master"},"14ced61eef89797e606c3b7600adc4da83a336f4":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-09-02 17:00:59.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/66/1166/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/66/1166/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3 \u0026\u0026 git checkout -b change-1166 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/66/1166/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9e9ba09adbe08e93d91d8340efe63bae978f5f34","subject":"dco: avoid printing mi prefix on debug messages"}],"author":{"name":"Ralf Lici","email":"ralf@mandelbit.com","date":"2025-09-02 16:45:15.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-02 16:57:05.000000000","tz":120},"subject":"dco_linux: validate tun interface before fetching stats","message":"dco_linux: validate tun interface before fetching stats\n\nIf dco_get_peer_stats() is called with an uninitialized c-\u003ec1.tuntap it\nresults in a segfault. This issue happens when a client who has not\nconnected to any server:\n  - has --management and exits,\n  - has --management and a management interface client issues either\n    `bytecount` or `status` or\n  - if SIGUSR2 is sent to it.\n\nAdd a check to ensure the tun interface was set up before attempting to\nretrieve peer statistics.\n\nChange-Id: I40c11864745cc1619cb9cbf490b168f90feb5eac\nSigned-off-by: Ralf Lici \u003cralf@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nMessage-Id: \u003c20250902164521.23145-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32768.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}