)]}'
{"id":"openvpn~1171","triplet_id":"openvpn~master~I6480d6f741c2368a0d951004b91167d5943f8f9d","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-08 10:38:04.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-08 10:38:04.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-08 10:38:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6480d6f741c2368a0d951004b91167d5943f8f9d","subject":"replace assert() calls with ASSERT()","status":"MERGED","created":"2025-09-07 10:22:04.000000000","updated":"2025-09-08 10:38:04.000000000","submitted":"2025-09-08 10:38:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1171","meta_rev_id":"9312d7f2a28aa7aea41383c44af8eafbc2c311d5","_number":1171,"virtual_id_number":1171,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-07 10:22:04.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-07 10:22:04.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-07 10:22:04.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-07 15:12:39.000000000","updated_by":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"reviewer":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"state":"REVIEWER"}],"messages":[{"id":"d2d007ddcbcc4ae0caf0d9ab9e467d4f6444b450","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-07 10:22:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"17ca630d0edb09661c54e7a4e2de0e28de9831f2","author":{"_account_id":1000046,"name":"mandree","email":"matthias.andree@gmx.de","username":"mandree"},"date":"2025-09-07 15:12:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9312d7f2a28aa7aea41383c44af8eafbc2c311d5","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-08 10:38:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"88f8edbf7545dc7913d031ea12c4bae5250bb766","revisions":{"06fb034c042fbc1ec5aee16b23928840180a2da7":{"kind":"REWORK","_number":1,"created":"2025-09-07 10:22:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/71/1171/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/1171/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1 \u0026\u0026 git checkout -b change-1171 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1e7b9a0fb021f0a64e76369f4efd2001d50ef42b","subject":"OpenVPN Release 2.7_beta1"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-07 08:47:41.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-07 08:47:41.000000000","tz":120},"subject":"replace assert() calls with ASSERT()","message":"replace assert() calls with ASSERT()\n\nOpenVPN\u0027s ASSERT() macro will do a bit more than the standard-libc\nassert() call, namely print out which function and what expression\nfailed, before calling _exit(1).  Also, it can not be accidentially\ncompiled-away (-DNDEBUG).\n\nUse of ASSERT() generally only advised in cases of \"this must not happen,\nbut if it does, it\u0027s a programming or state corruption error that we\nmust know about\".  Use of assert() is lacking the extra debug info, and as\nsuch, not advised at all.\n\nChange-Id: I6480d6f741c2368a0d951004b91167d5943f8f9d\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"88f8edbf7545dc7913d031ea12c4bae5250bb766":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-09-08 10:38:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/71/1171/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/71/1171/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2 \u0026\u0026 git checkout -b change-1171 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/71/1171/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1e7b9a0fb021f0a64e76369f4efd2001d50ef42b","subject":"OpenVPN Release 2.7_beta1"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-07 21:12:46.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-08 10:19:28.000000000","tz":120},"subject":"replace assert() calls with ASSERT()","message":"replace assert() calls with ASSERT()\n\nOpenVPN\u0027s ASSERT() macro will do a bit more than the standard-libc\nassert() call, namely print out which function and what expression\nfailed, before calling _exit(1).  Also, it can not be accidentially\ncompiled-away (-DNDEBUG).\n\nUse of ASSERT() is generally only advised in cases of \"this must not\nhappen, but if it does, it\u0027s a programming or state corruption error\nthat we must know about\".  Use of assert() is lacking the extra debug\ninfo, and as such, not advised at all.\n\nChange-Id: I6480d6f741c2368a0d951004b91167d5943f8f9d\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: mandree \u003cmatthias.andree@gmx.de\u003e\nMessage-Id: \u003c20250907211252.23924-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg32824.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}