)]}'
{"id":"openvpn~1180","triplet_id":"openvpn~master~I889b53ed72efaec546a6609491fae9715726ea00","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-12 16:13:39.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-12 16:13:39.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-12 09:44:48.000000000","reason":"removed on reply"}},"hashtags":["mailsubmitted"],"change_id":"I889b53ed72efaec546a6609491fae9715726ea00","subject":"remove newline characters at the end of msg() calls","status":"MERGED","created":"2025-09-11 17:59:11.000000000","updated":"2025-09-12 16:13:39.000000000","submitted":"2025-09-12 16:13:39.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1180","meta_rev_id":"50f9a370ebbb7a19b3b89983996a85ff159c580f","_number":1180,"virtual_id_number":1180,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-11 17:59:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-11 17:59:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-11 17:59:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"}],"messages":[{"id":"b202c439afef88a6198ab78ade325793b560aa19","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-11 17:59:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d9d5595b4882a86c19ad831b9bb67cb8fb65499f","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-12 09:44:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a9b2bcd5f37ca52f8f4de974c040c81327261d96","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-12 13:16:19.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":1},{"id":"50f9a370ebbb7a19b3b89983996a85ff159c580f","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-12 16:13:39.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"340b5b2d264a47c24aa948efb83ffa04e0e9c7e2","revisions":{"13c267b5265f2bbc191216f2b74c70755cab39dd":{"kind":"REWORK","_number":1,"created":"2025-09-11 17:59:11.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/80/1180/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1180/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1 \u0026\u0026 git checkout -b change-1180 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"88f8edbf7545dc7913d031ea12c4bae5250bb766","subject":"replace assert() calls with ASSERT()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-11 17:57:23.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-11 17:59:04.000000000","tz":120},"subject":"remove newline characters at the end of msg() calls","message":"remove newline characters at the end of msg() calls\n\nUnlike debugging with printf(), or msg() calls do not need or want\na \u0027\\n\u0027 at the end of the string.  Remove those that were overlooked.\n\nChange-Id: I889b53ed72efaec546a6609491fae9715726ea00\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"340b5b2d264a47c24aa948efb83ffa04e0e9c7e2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2025-09-12 16:13:39.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/80/1180/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/80/1180/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2 \u0026\u0026 git checkout -b change-1180 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/80/1180/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"c3600e9b5991e00d8cf8b29aec4d3005fb311f84","subject":"push-update-server: comment about buf_string_compare_advance() usage in send_single_push_update()"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-12 13:16:09.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-12 16:08:24.000000000","tz":120},"subject":"remove newline characters at the end of msg() calls","message":"remove newline characters at the end of msg() calls\n\nUnlike debugging with printf(), or msg() calls do not need or want\na \u0027\\n\u0027 at the end of the string.  Remove those that were overlooked.\n\nChange-Id: I889b53ed72efaec546a6609491fae9715726ea00\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nMessage-Id: \u003c20250912131609.43444-1-frank@lichtenheld.com\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59232448/\nURL: https://gerrit.openvpn.net/c/openvpn/+/1180\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}