)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"bc0896d0355c9faa7de6fecacd899dadcdb0d982","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59fb6596_ba4a6b20","updated":"2025-09-16 16:51:25.000000000","message":"@selva.nair@gmail.com - if you\u0027re fine with the patch otherwise, feel free to +2 it.  I\u0027ll volunteer to take care of the autconf bits (and send in a followup patch).","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"3608246b13125bd4011577fce413adf263473841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1104dd5_f8f87fe2","updated":"2025-09-16 17:42:20.000000000","message":"Building with cmake and mingw using mingw-x64 preset works, but openvpnservmsg.dll not generated. eventmsg.h and rc do get made without error.\nIf there is an MSVC build artifact somewhere, I can test it.","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"35e34990a0e43f7b592382788fdc115d468aafdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"21a6ea06_882137f0","updated":"2025-09-16 15:43:48.000000000","message":"Looks good but I have not build-tested. Can we get the gerrit checks to run?\n\nAlso, I\u0027ve not been following build system changes, so not sure, but don\u0027t we still support building using autotools and mingw for Windows? Espeically cross-compiling. Could be handled in a separate patch, though.","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"d9d3dfe4b0c06d38ba35464d629bcc9af856d88a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb9be566_c246fdc0","updated":"2025-09-16 21:27:38.000000000","message":"cmake-MSVC build is good and the dll works as expected.\nFixing cmake-mingw build may be handled in a separate patch.","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"9342ca215c1967a9b9c96ad04fa944799e579b06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d057b1c_f78aa0dc","in_reply_to":"16ff4007_42b7e333","updated":"2025-09-17 23:39:32.000000000","message":"If that is so, all is good. Does the log just show building, or is the dll really generated as well? Also, is there a way to see buildbot logs -- for me the link always times out trying to connect to some AWS site. \n\nFurther, is --no-entry really a valid linker option? Googling brings it up but that could be an \"AI hallucination\" based on MSVC\u0027s /NOENTRY. Anyway, I cant get that option to work. A way to make DLLs with no entry point using gnu linker is probably to pass -nostartfiles option to gcc.\n\nThat said, I get no build errors -- just no dll to be found anyhere, nor the command building it is in the verbose logs.(https://gist.github.com/selvanair/7145365eab2b38c2c961646efca692ea).","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"4420ae81640dcc119fc4115a0a72486d8ce3c600","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b01506a1_b28a103c","in_reply_to":"1d057b1c_f78aa0dc","updated":"2025-09-18 06:29:44.000000000","message":"Line #336 has something, the target binary is \"libopenvpnservmsg.dll\"\n\n```\n[336/348] : \u0026\u0026 cd /home/selva/openvpn/out/build/mingw/x64/src/openvpnserv \u0026\u0026 /snap/bin/pwsh -noprofile -executionpolicy Bypass -file /home/selva/vcpkg/scripts/buildsystems/msbuild/applocal.ps1 -targetBinary /home/selva/openvpn/out/build/mingw/x64/src/openvpnserv/Release/libopenvpnservmsg.dll -installedDir /home/selva/openvpn/out/build/mingw/x64/vcpkg_installed/x64-mingw-ovpn/bin -OutVariable out\n```\n\nI won\u0027t claim to understand what it\u0027s doing, though...","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"0cecd6437159f9d5ea893bc4d536830e112981da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10a8446f_3dec425b","in_reply_to":"59fb6596_ba4a6b20","updated":"2025-09-16 17:39:03.000000000","message":"Trying to find some time to build test it. autotools thing can wait (or be deprecated) as cmake build using mingw is probably supported.","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"e2a75ef0c77d616c0045025f168bf711e076a4bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6838f275_918c5f30","in_reply_to":"98393ff1_21025aac","updated":"2025-09-18 17:20:01.000000000","message":"Yep, we discovered as well.  It looked nice and calm and no errors, just didn\u0027t work ;-)\n\n#1197 has a patch that fixes this for good in our tests (cmake+msvc, cmake+mingw, autoconf+mingw).  It might not be fully correct autoconf style yet, but it works ;-)","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"b21b71d54a4f2cb27ef47c34922b74670e85c818","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98393ff1_21025aac","in_reply_to":"b01506a1_b28a103c","updated":"2025-09-18 15:17:20.000000000","message":"That\u0027s the POST_BUILD task running a powershell script. Apparently that script appears to just exit if neither source binary nor target binary is found. There is no linking steps for this dll in the verbose logs.","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"27ccd074d0313ecfd230a96f5d6ca046668bc4cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8164a40_9123c3e6","in_reply_to":"f1104dd5_f8f87fe2","updated":"2025-09-17 07:12:49.000000000","message":"I haven\u0027t tried mingw myself but GHA log says:\n\n [261/267] Linking RC shared library src/openvpnserv/Debug/libopenvpnservmsg.dll","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"2fefceb767a8a2bbcce5b1cebc57cfbd653f3ab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16ff4007_42b7e333","in_reply_to":"f8164a40_9123c3e6","updated":"2025-09-17 10:40:34.000000000","message":"FWIW, buildbot also has a mingw build and it shows it generates the file. @selva.nair@gmail.com do you have a build log from your cmake+mingw build?","commit_id":"7321718be906dc63ce32c52e953c10a3cce7f2a2"}],"src/openvpnserv/common.c":[{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"45a471b026f62e73870e3936e90db69dabbbe67a","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    error \u003d GetLastError();"},{"line_number":207,"context_line":"    len \u003d FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM"},{"line_number":208,"context_line":"                            | FORMAT_MESSAGE_IGNORE_INSERTS,"},{"line_number":209,"context_line":"                        NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR)\u0026tmp, 0, NULL);"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    if (!len || !tmp)"},{"line_number":212,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"c9d63194_9fa73d93","line":209,"updated":"2025-09-15 17:38:48.000000000","message":"Explict use of the unicode version \"FormatMessageW\" preferred.","commit_id":"1fd8ac2b81f0afa2b563dfbc2bd072d3a6a7e8cc"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"5d005d88119c7783b5c212976089f6a4fd3ea0ec","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    error \u003d GetLastError();"},{"line_number":207,"context_line":"    len \u003d FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM"},{"line_number":208,"context_line":"                            | FORMAT_MESSAGE_IGNORE_INSERTS,"},{"line_number":209,"context_line":"                        NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR)\u0026tmp, 0, NULL);"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    if (!len || !tmp)"},{"line_number":212,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"faf6c002_b6bdf61f","line":209,"in_reply_to":"c9d63194_9fa73d93","updated":"2025-09-16 07:10:24.000000000","message":"Acknowledged","commit_id":"1fd8ac2b81f0afa2b563dfbc2bd072d3a6a7e8cc"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"45a471b026f62e73870e3936e90db69dabbbe67a","unresolved":true,"context_lines":[{"line_number":225,"context_line":"    }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    swprintf(buf, _countof(buf), L\"%ls (0x%lx)\", tmp, error);"},{"line_number":228,"context_line":"    buf[_countof(buf) - 1] \u003d L\u0027\\0\u0027;"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    LocalFree(tmp);"},{"line_number":231,"context_line":"    return buf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"6b08b575_87668df4","line":228,"updated":"2025-09-15 17:38:48.000000000","message":"Previously we removed openvp_swprintf etc. assuming this explicit null-termination is no longer required. (commit 130548fe).","commit_id":"1fd8ac2b81f0afa2b563dfbc2bd072d3a6a7e8cc"},{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"5d005d88119c7783b5c212976089f6a4fd3ea0ec","unresolved":false,"context_lines":[{"line_number":225,"context_line":"    }"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    swprintf(buf, _countof(buf), L\"%ls (0x%lx)\", tmp, error);"},{"line_number":228,"context_line":"    buf[_countof(buf) - 1] \u003d L\u0027\\0\u0027;"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    LocalFree(tmp);"},{"line_number":231,"context_line":"    return buf;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"33eaf24d_50732a8f","line":228,"in_reply_to":"6b08b575_87668df4","updated":"2025-09-16 07:10:24.000000000","message":"JFTR: only MSFT version of swprintf guarantees NULL termination. Other versions won\u0027t write anything (and won\u0027t terminate) if the string doesn\u0027t fit. OTOH, we build releases with MSVC and in any case we nowadays use MSFT implementation (ucrtbase.dll) from OS.","commit_id":"1fd8ac2b81f0afa2b563dfbc2bd072d3a6a7e8cc"}]}