)]}'
{"id":"openvpn~1188","triplet_id":"openvpn~master~I423c9880def0eb479abb72bef2e8034a73cf5905","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-17 16:26:44.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-17 16:26:44.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-17 10:40:34.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}},"1000009":{"account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"last_update":"2025-09-16 15:43:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1000009\u003e replied on the change","reason_account":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-09-17 16:26:44.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I423c9880def0eb479abb72bef2e8034a73cf5905","subject":"openvpnserv: Fix writing messages to the event log","status":"MERGED","created":"2025-09-15 13:38:25.000000000","updated":"2025-09-18 17:20:01.000000000","submitted":"2025-09-17 16:26:44.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":15,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1188","meta_rev_id":"e2a75ef0c77d616c0045025f168bf711e076a4bd","_number":1188,"virtual_id_number":1188,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"CC":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-15 13:38:25.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-15 13:38:25.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-15 13:38:25.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-15 17:38:48.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"CC"},{"updated":"2025-09-16 15:43:48.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"REVIEWER"},{"updated":"2025-09-16 16:51:25.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"}],"messages":[{"id":"71a4302c0610bef526753b190e5607d8b1cdd755","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-15 13:38:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"45a471b026f62e73870e3936e90db69dabbbe67a","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-15 17:38:48.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"0a17015710f53f2761a368be518aeb8a54634873","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-16 07:00:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5d005d88119c7783b5c212976089f6a4fd3ea0ec","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-16 07:10:24.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"35e34990a0e43f7b592382788fdc115d468aafdc","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 15:43:48.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5092489afb618624b47f8371c2a119e89a0aaa9d","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 15:44:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cf4b4679f0e4442ec85b863899e8a035c45a98c4","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 15:45:39.000000000","message":"Removed Code-Review+2 by \u003cGERRIT_ACCOUNT_1000009\u003e\n","accounts_in_message":[{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"}],"_revision_number":2},{"id":"bc0896d0355c9faa7de6fecacd899dadcdb0d982","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-16 16:51:25.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0cecd6437159f9d5ea893bc4d536830e112981da","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 17:39:03.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3608246b13125bd4011577fce413adf263473841","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 17:42:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d9d3dfe4b0c06d38ba35464d629bcc9af856d88a","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-16 21:27:38.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"27ccd074d0313ecfd230a96f5d6ca046668bc4cc","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-17 07:12:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2fefceb767a8a2bbcce5b1cebc57cfbd653f3ab1","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-17 10:40:34.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"3dc2eaf4ef13744cef829e994360cee3fbc14003","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-17 16:26:44.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3},{"id":"9342ca215c1967a9b9c96ad04fa944799e579b06","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-17 23:39:32.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4420ae81640dcc119fc4115a0a72486d8ce3c600","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 06:29:44.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"b21b71d54a4f2cb27ef47c34922b74670e85c818","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-18 15:17:20.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"e2a75ef0c77d616c0045025f168bf711e076a4bd","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 17:20:01.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"06919a60ae61d6d88546b23b52092f742599a8ae","revisions":{"1fd8ac2b81f0afa2b563dfbc2bd072d3a6a7e8cc":{"kind":"REWORK","_number":1,"created":"2025-09-15 13:38:25.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/88/1188/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1188/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1 \u0026\u0026 git checkout -b change-1188 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5759a838ee630409b44206a60a599041a23c1190","subject":"manage: Change command_line_* API to use size_t for lengths"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-15 13:27:47.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-15 13:35:24.000000000","tz":180},"subject":"openvpnserv: Fix writing messages to the event log","message":"openvpnserv: Fix writing messages to the event log\n\nThere are two problems with the current implementation:\n\n - due to the code bug, we never display actual error message\ncorresponding to the Windows error code. We use\nFORMAT_MESSAGE_ALLOCATE_BUFFER, in which case we must pass\na pointer to the LPTSTR, not the LPTSTR itself.\n\n - The error is not displayed in the \"General\" tab, which is very confusing.\nOne needs to go to the \"Details\" tab to see what is wrong.\n\nThis commit solves both problems. We now display a proper error\nmessage in addition to the text provided by the service (\"what went wrong\").\nWhile on it, remove trailing symbols ín a safer way.\n\nTo display the message in \"General\" tab, we create a registered message file\n(openvpnservmsg.dll), which contains message template. Note that this requires\nchanges to the installer - we need to install the new DLL and\nadd a registry entry.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/842\n\nChange-Id: I423c9880def0eb479abb72bef2e8034a73cf5905\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"7321718be906dc63ce32c52e953c10a3cce7f2a2":{"kind":"REWORK","_number":2,"created":"2025-09-16 07:00:31.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/88/1188/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1188/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2 \u0026\u0026 git checkout -b change-1188 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5759a838ee630409b44206a60a599041a23c1190","subject":"manage: Change command_line_* API to use size_t for lengths"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-15 13:27:47.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-16 06:59:30.000000000","tz":180},"subject":"openvpnserv: Fix writing messages to the event log","message":"openvpnserv: Fix writing messages to the event log\n\nThere are two problems with the current implementation:\n\n - due to the code bug, we never display actual error message\ncorresponding to the Windows error code. We use\nFORMAT_MESSAGE_ALLOCATE_BUFFER, in which case we must pass\na pointer to the LPTSTR, not the LPTSTR itself.\n\n - The error is not displayed in the \"General\" tab, which is very confusing.\nOne needs to go to the \"Details\" tab to see what is wrong.\n\nThis commit solves both problems. We now display a proper error\nmessage in addition to the text provided by the service (\"what went wrong\").\nWhile on it, remove trailing symbols ín a safer way.\n\nTo display the message in \"General\" tab, we create a registered message file\n(openvpnservmsg.dll), which contains message template. Note that this requires\nchanges to the installer - we need to install the new DLL and\nadd a registry entry.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/842\n\nChange-Id: I423c9880def0eb479abb72bef2e8034a73cf5905\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/master"},"06919a60ae61d6d88546b23b52092f742599a8ae":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-09-17 16:26:44.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/88/1188/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/88/1188/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3 \u0026\u0026 git checkout -b change-1188 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/88/1188/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"168792766dedc2dab41347fa394fc244c73247e8","subject":"dev-tools/gerrit-send-mail.py: include Gerrit URL into the commit message"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-17 09:05:48.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-17 16:16:54.000000000","tz":120},"subject":"openvpnserv: Fix writing messages to the event log","message":"openvpnserv: Fix writing messages to the event log\n\nThere are two problems with the current implementation:\n\n - due to the code bug, we never display actual error message\ncorresponding to the Windows error code. We use\nFORMAT_MESSAGE_ALLOCATE_BUFFER, in which case we must pass\na pointer to the LPTSTR, not the LPTSTR itself.\n\n - The error is not displayed in the \"General\" tab, which is very confusing.\nOne needs to go to the \"Details\" tab to see what is wrong.\n\nThis commit solves both problems. We now display a proper error\nmessage in addition to the text provided by the service (\"what went wrong\").\nWhile on it, remove trailing symbols ín a safer way.\n\nTo display the message in \"General\" tab, we create a registered message file\n(openvpnservmsg.dll), which contains message template. Note that this requires\nchanges to the installer - we need to install the new DLL and\nadd a registry entry.\n\nGitHub: https://github.com/OpenVPN/openvpn/issues/842\n\nChange-Id: I423c9880def0eb479abb72bef2e8034a73cf5905\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Selva Nair \u003cselva.nair@gmail.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1188\nMessage-Id: \u003c20250917090557.25414-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59234559/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}