)]}'
{"src/openvpn/networking_freebsd.c":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"caeae85603fe29f0ad29e0b0378c20e25e03f3b8","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _dst \u003d ntohl(*dst);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    /* if gw is 0 (\u003d0.0.0.0), which is not a valid gateway,"},{"line_number":24,"context_line":"     * we are installing a route with the interface as target instead */"},{"line_number":25,"context_line":"    if (gw)"},{"line_number":26,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"ca46df8e_422ac899","line":23,"updated":"2025-09-27 20:27:42.000000000","message":"are you passing in NULL or \"a pointer to 0.0.0.0\"?  The code says \"NULL\" and the comment says \"gw is 0.0.0.0\" which would technically be \"a pointer to 0.0.0.0\"...\n\nMaybe just word it the same as in IPv6... `if we have no gateway (gw is NULL), we are installing a route with the interface as target instead` or so.\n\nBut the logic is still confusing, the comment says \"if we have no gateway\" and the condition does \"if(gateway)\" and the \"interface route\" is down in the else branch...","commit_id":"77b17958fb614ae012df25a622e4d263f4e0c4cb"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"46367c3b4d84f6b481edec2592bb7bab587d35c7","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _dst \u003d ntohl(*dst);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    /* if gw is 0 (\u003d0.0.0.0), which is not a valid gateway,"},{"line_number":24,"context_line":"     * we are installing a route with the interface as target instead */"},{"line_number":25,"context_line":"    if (gw)"},{"line_number":26,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"5c8a40a2_8ceda728","line":23,"in_reply_to":"ca46df8e_422ac899","updated":"2025-09-28 11:24:04.000000000","message":"```\n/* if we have a gateway (GW !\u003d NULL) install route to gateway IP\n * if not, install \"connected\" route to interface (required for ifconfig-push IPs)\n */\n```\nsomething like this?  I think this would help understanding the code and be in line with the `if(gw)...`","commit_id":"77b17958fb614ae012df25a622e4d263f4e0c4cb"}]}