)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"c9478eb899779e20882d2d43693fbdb83e1782ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bbec05b4_e12f1416","updated":"2025-09-18 13:15:19.000000000","message":"CMake changes look good - I checked with GHA that the DLL is generated for mingw and msvc - I downloaded the artifacts (there is a separate patch to include more files into mingw job artifacts) and checked that the file is indeed there.\n\nautotools is a black magic for me so I leave it to Frank.","commit_id":"d2899d0d95700fa58fc75f9b9aa7c180b92f7f97"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f7f824da940f208b4a1b20f5b3e4ce6cd88ae877","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ae0c4c1b_8a94b41a","updated":"2025-09-18 17:45:45.000000000","message":"Very nice.. cmake-mingw also works now.\nThe dlls built using autotools also work on Windows event viewer.","commit_id":"d2899d0d95700fa58fc75f9b9aa7c180b92f7f97"}],"src/openvpnserv/CMakeLists.txt":[{"author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"change_message_id":"8f1c38b60c929ce6d8ba46f4a167c101ad51543f","unresolved":true,"context_lines":[{"line_number":61,"context_line":"add_dependencies(openvpnservmsg msg_mc_gen)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"if (MSVC)"},{"line_number":64,"context_line":"    set_target_properties(openvpnservmsg PRIVATE \"/NOENTRY\")"},{"line_number":65,"context_line":"else()"},{"line_number":66,"context_line":"    set_target_properties(openvpnservmsg PROPERTIES LINKER_LANGUAGE C OUTPUT_NAME \"openvpnservmsg\")"},{"line_number":67,"context_line":"    target_link_options(openvpnservmsg PRIVATE"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"f97cb62c_55af1224","line":64,"updated":"2025-09-18 12:58:11.000000000","message":"My bad, this should be set_target_properties(openvpnservmsg PROPERTIES LINK_FLAGS \"/NOENTRY\") - basically same as before","commit_id":"c66d086a2748d7dd61824ee490637dfcf2e2e139"},{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"8fc54722f667b66a45681b277cda581b033a81b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"add_dependencies(openvpnservmsg msg_mc_gen)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"if (MSVC)"},{"line_number":64,"context_line":"    set_target_properties(openvpnservmsg PRIVATE \"/NOENTRY\")"},{"line_number":65,"context_line":"else()"},{"line_number":66,"context_line":"    set_target_properties(openvpnservmsg PROPERTIES LINKER_LANGUAGE C OUTPUT_NAME \"openvpnservmsg\")"},{"line_number":67,"context_line":"    target_link_options(openvpnservmsg PRIVATE"}],"source_content_type":"text/x-cmake","patch_set":3,"id":"873ee4aa_9d95209e","line":64,"in_reply_to":"f97cb62c_55af1224","updated":"2025-09-18 17:21:20.000000000","message":"Done","commit_id":"c66d086a2748d7dd61824ee490637dfcf2e2e139"}],"src/openvpnserv/Makefile.am":[{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a2b696d3355938be71c55550ee654109dd6c2c96","unresolved":true,"context_lines":[{"line_number":29,"context_line":"\t-ladvapi32 -luserenv -liphlpapi -lfwpuclnt -lrpcrt4 \\"},{"line_number":30,"context_line":"\t-lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32"},{"line_number":31,"context_line":"noinst_DATA \u003d \\"},{"line_number":32,"context_line":"\tMSG00409.bin eventmsg.h eventmsg.rc openvpnservmsg.dll"},{"line_number":33,"context_line":"BUILT_SOURCES \u003d \\"},{"line_number":34,"context_line":"\teventmsg.h"},{"line_number":35,"context_line":"endif"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"504cb947_ee947437","line":32,"updated":"2025-09-18 09:59:06.000000000","message":"Is it intentional that `openvpnservmsg.dll` is in `noinst`? Shouldn\u0027t it be installed?","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45157198bcd8ad8659cec586fa4e7cbb7d5221ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\t-ladvapi32 -luserenv -liphlpapi -lfwpuclnt -lrpcrt4 \\"},{"line_number":30,"context_line":"\t-lshlwapi -lnetapi32 -lws2_32 -lntdll -lole32"},{"line_number":31,"context_line":"noinst_DATA \u003d \\"},{"line_number":32,"context_line":"\tMSG00409.bin eventmsg.h eventmsg.rc openvpnservmsg.dll"},{"line_number":33,"context_line":"BUILT_SOURCES \u003d \\"},{"line_number":34,"context_line":"\teventmsg.h"},{"line_number":35,"context_line":"endif"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"b366bbb6_39e946fa","line":32,"in_reply_to":"504cb947_ee947437","updated":"2025-09-18 13:55:45.000000000","message":"Acknowledged","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a2b696d3355938be71c55550ee654109dd6c2c96","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\topenvpnserv_resources.rc"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"openvpnservmsg.dll: eventmsg.o"},{"line_number":46,"context_line":"\t$(CC) -shared -Wl,--entry\u003d0 -nostdlib -nostartfiles -o openvpnservmsg.dll eventmsg.o"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"eventmsg.o: eventmsg.rc"},{"line_number":49,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"51bca724_b7505ca0","line":46,"updated":"2025-09-18 09:59:06.000000000","message":"This looks like it might fail with out-of-tree builds. Can you please verify that it works.\nAs a nitpick I would also recommend using `$@` and `$\u003c`","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45157198bcd8ad8659cec586fa4e7cbb7d5221ae","unresolved":false,"context_lines":[{"line_number":43,"context_line":"\topenvpnserv_resources.rc"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"openvpnservmsg.dll: eventmsg.o"},{"line_number":46,"context_line":"\t$(CC) -shared -Wl,--entry\u003d0 -nostdlib -nostartfiles -o openvpnservmsg.dll eventmsg.o"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"eventmsg.o: eventmsg.rc"},{"line_number":49,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9357acc2_b468f24e","line":46,"in_reply_to":"51bca724_b7505ca0","updated":"2025-09-18 13:55:45.000000000","message":"Done","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"a2b696d3355938be71c55550ee654109dd6c2c96","unresolved":true,"context_lines":[{"line_number":48,"context_line":"eventmsg.o: eventmsg.rc"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"eventmsg.h: eventmsg.mc"},{"line_number":51,"context_line":"\t$(WINDMC) -U eventmsg.mc"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"8d382386_4d9818d6","line":51,"updated":"2025-09-18 09:59:06.000000000","message":"same concerns here","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"45157198bcd8ad8659cec586fa4e7cbb7d5221ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"eventmsg.o: eventmsg.rc"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"eventmsg.h: eventmsg.mc"},{"line_number":51,"context_line":"\t$(WINDMC) -U eventmsg.mc"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"0472f96c_f7c0a629","line":51,"in_reply_to":"8d382386_4d9818d6","updated":"2025-09-18 13:55:45.000000000","message":"Done","commit_id":"f875e0b03d6e4e24f961fc4730ed85e791b55e03"},{"author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"change_message_id":"f7f824da940f208b4a1b20f5b3e4ce6cd88ae877","unresolved":true,"context_lines":[{"line_number":43,"context_line":"\topenvpnserv_resources.rc"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"openvpnservmsg.dll: eventmsg.o"},{"line_number":46,"context_line":"\t$(CC) -shared -Wl,--entry\u003d0 -nostdlib -nostartfiles -o $@ $\u003c"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"eventmsg.o: eventmsg.rc"},{"line_number":49,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fe997674_e9daf92f","line":46,"updated":"2025-09-18 17:45:45.000000000","message":"Adhoc build of this dll is fine, but fwiw, here is my try to use libtool instead: https://github.com/selvanair/openvpn/commit/bc94c62ac66a377df49044842515351aa256adcd\n\nThe resulting dll is larger, but could be stripped as we do with other binaries.","commit_id":"d2899d0d95700fa58fc75f9b9aa7c180b92f7f97"}]}