)]}'
{"id":"openvpn~1197","triplet_id":"openvpn~master~I071e8190dac28f429257b8af1c6f9e68f8896bc0","project":"openvpn","branch":"master","attention_set":{"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-09-18 17:21:20.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}}},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-19 12:33:20.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-19 12:33:20.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-18 13:55:45.000000000","reason":"\u003cGERRIT_ACCOUNT_1000001\u003e replied on the change","reason_account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}}},"hashtags":[],"change_id":"I071e8190dac28f429257b8af1c6f9e68f8896bc0","subject":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds","status":"MERGED","created":"2025-09-18 07:01:13.000000000","updated":"2025-09-19 12:33:20.000000000","submitted":"2025-09-19 12:33:20.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":11,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"1197","meta_rev_id":"e2bf21190b7c162aaa246a3d07c8a54b70bf2f4e","_number":1197,"virtual_id_number":1197,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"value":0,"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"}],"CC":[{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-18 07:01:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-18 07:01:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-18 07:01:14.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-18 12:58:11.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"state":"REVIEWER"},{"updated":"2025-09-18 17:45:45.000000000","updated_by":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"reviewer":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"state":"CC"}],"messages":[{"id":"c20fc448116d535902969d64626c6d3743cf115f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 07:01:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1a21ccffd691a994c3b7cbd213036b15d56c2a52","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 07:27:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a2b696d3355938be71c55550ee654109dd6c2c96","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-18 09:59:06.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d1183ff0390477e99796b97dafe8d7824109e865","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 12:49:29.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN\")\n","accounts_in_message":[],"_revision_number":3},{"id":"8f1c38b60c929ce6d8ba46f4a167c101ad51543f","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-18 12:58:11.000000000","message":"Patch Set 3: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"95cba518e31f8f5144713fd6a8d848f7b18681b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 13:07:46.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"c9478eb899779e20882d2d43693fbdb83e1782ac","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-18 13:15:19.000000000","message":"Patch Set 4: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"45157198bcd8ad8659cec586fa4e7cbb7d5221ae","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-18 13:55:45.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"8fc54722f667b66a45681b277cda581b033a81b9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 17:21:20.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"f7f824da940f208b4a1b20f5b3e4ce6cd88ae877","author":{"_account_id":1000009,"name":"selvanair","display_name":"Selva Nair","email":"selva.nair@gmail.com","username":"selvanair"},"date":"2025-09-18 17:45:45.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"c5e60bd6f5547e2162f8b1bb266acef9b1d7134b","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-19 10:29:01.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"e2bf21190b7c162aaa246a3d07c8a54b70bf2f4e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-19 12:33:20.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"744a2bd556833cf5e65d737e1bcffd2cb89a6d2f","revisions":{"4836d6b887561732d851e46933a99eecd3cb3497":{"kind":"REWORK","_number":1,"created":"2025-09-18 07:01:13.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1197/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1197/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1 \u0026\u0026 git checkout -b change-1197 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06919a60ae61d6d88546b23b52092f742599a8ae","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-17 17:41:27.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-18 06:36:17.000000000","tz":120},"subject":"add building of openvpnsrvmsg.dll from eventmsg.mc to autoconf/mingw builds","message":"add building of openvpnsrvmsg.dll from eventmsg.mc to autoconf/mingw builds\n\ncommit 06919a60ae61 introduces .mc files that need to be compiled to\n.h and .bin by the windows \"mc.exe\" tool, and from there into a new\n.dll\n\nAdd logic to configure.ac to find the \"windmc\" binary in the linux or\nmingw variants, add rules to src/openvpnserv/Makefile.am so make knows\nwhat to do.\n\nLibtool is getting in the way when \"openvpnsrvmsg.dll\" is created as\nanything listed in ...BIN or ...LIB, so decare it as \"DATA\" and make\nthe necessary rules explicit.\n\nSee also:\nhttps://learn.microsoft.com/en-us/cpp/build/creating-a-resource-only-dll?view\u003dmsvc-170\n\nChange-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"f875e0b03d6e4e24f961fc4730ed85e791b55e03":{"kind":"REWORK","_number":2,"created":"2025-09-18 07:27:23.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1197/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1197/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2 \u0026\u0026 git checkout -b change-1197 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06919a60ae61d6d88546b23b52092f742599a8ae","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-17 17:41:27.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-18 07:03:38.000000000","tz":120},"subject":"add building of openvpnsrvmsg.dll from eventmsg.mc to autoconf/mingw builds","message":"add building of openvpnsrvmsg.dll from eventmsg.mc to autoconf/mingw builds\n\ncommit 06919a60ae61 introduces .mc files that need to be compiled to\n.h and .bin by the windows \"mc.exe\" tool, and from there into a new\n.dll\n\nAdd logic to configure.ac to find the \"windmc\" binary in the linux or\nmingw variants, add rules to src/openvpnserv/Makefile.am so make knows\nwhat to do.\n\nLibtool is getting in the way when \"openvpnsrvmsg.dll\" is created as\nanything listed in ...BIN or ...LIB, so decare it as \"DATA\" and make\nthe necessary rules explicit.\n\nSee also:\nhttps://learn.microsoft.com/en-us/cpp/build/creating-a-resource-only-dll?view\u003dmsvc-170\n\nChange-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"c66d086a2748d7dd61824ee490637dfcf2e2e139":{"kind":"REWORK","_number":3,"created":"2025-09-18 12:49:29.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1197/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1197/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3 \u0026\u0026 git checkout -b change-1197 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06919a60ae61d6d88546b23b52092f742599a8ae","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-17 17:41:27.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-18 12:44:21.000000000","tz":120},"subject":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds","message":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds\n\ncommit 06919a60ae61 introduces .mc files that need to be compiled to\n.h and .bin by the windows \"mc.exe\" tool, and from there into a new\n.dll.  This worked for MSVC builds, did nothing for cmake/mingw builds,\nand broke compilation on autoconf/mingw builds.\n\nThis patch consists of two parts:\n\n1. add building of openvpnsrvmsg.dll to autoconf/mingw builds\n\n   Add logic to configure.ac to find the \"windmc\" binary in the linux or\n   mingw variants, add rules to src/openvpnserv/Makefile.am so make knows\n   what to do.\n\n   Libtool is getting in the way when \"openvpnsrvmsg.dll\" is created as\n   anything listed in ...BIN or ...LIB, so decare it as \"DATA\" and make\n   the necessary rules explicit.\n\n2. fix building of openvpnsrvmsg.dll on cmake/mingw builds\n\n   Fix \"find_program()\" invocation to avoid using \"midnight commander\"\n   binary (mc) on Linux (called \"windmc\" there).\n\n   Change from \"-Wl,--noentry\" to linker invocation that works.\n\nSee also:\nhttps://learn.microsoft.com/en-us/cpp/build/creating-a-resource-only-dll?view\u003dmsvc-170\n\nChange-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"d2899d0d95700fa58fc75f9b9aa7c180b92f7f97":{"kind":"REWORK","_number":4,"created":"2025-09-18 13:07:46.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1197/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1197/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4 \u0026\u0026 git checkout -b change-1197 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06919a60ae61d6d88546b23b52092f742599a8ae","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-17 17:41:27.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-18 13:07:35.000000000","tz":120},"subject":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds","message":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds\n\ncommit 06919a60ae61 introduces .mc files that need to be compiled to\n.h and .bin by the windows \"mc.exe\" tool, and from there into a new\n.dll.  This worked for MSVC builds, did nothing for cmake/mingw builds,\nand broke compilation on autoconf/mingw builds.\n\nThis patch consists of two parts:\n\n1. add building of openvpnsrvmsg.dll to autoconf/mingw builds\n\n   Add logic to configure.ac to find the \"windmc\" binary in the linux or\n   mingw variants, add rules to src/openvpnserv/Makefile.am so make knows\n   what to do.\n\n   Libtool is getting in the way when \"openvpnsrvmsg.dll\" is created as\n   anything listed in ...BIN or ...LIB, so decare it as \"DATA\" and make\n   the necessary rules explicit.\n\n2. fix building of openvpnsrvmsg.dll on cmake/mingw builds\n\n   Fix \"find_program()\" invocation to avoid using \"midnight commander\"\n   binary (mc) on Linux (called \"windmc\" there).\n\n   Change from \"-Wl,--noentry\" to linker invocation that works.\n\nSee also:\nhttps://learn.microsoft.com/en-us/cpp/build/creating-a-resource-only-dll?view\u003dmsvc-170\n\nChange-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"744a2bd556833cf5e65d737e1bcffd2cb89a6d2f":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2025-09-19 12:33:20.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/97/1197/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/97/1197/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5 \u0026\u0026 git checkout -b change-1197 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/97/1197/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"06919a60ae61d6d88546b23b52092f742599a8ae","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-19 11:24:19.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-19 11:51:42.000000000","tz":120},"subject":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds","message":"fix building of openvpnsrvmsg.dll from eventmsg.mc in mingw builds\n\ncommit 06919a60ae61 introduces .mc files that need to be compiled to\n.h and .bin by the windows \"mc.exe\" tool, and from there into a new\n.dll.  This worked for MSVC builds, did nothing for cmake/mingw builds,\nand broke compilation on autoconf/mingw builds.\n\nThis patch consists of two parts:\n\n1. add building of openvpnsrvmsg.dll to autoconf/mingw builds\n\n   Add logic to configure.ac to find the \"windmc\" binary in the linux or\n   mingw variants, add rules to src/openvpnserv/Makefile.am so make knows\n   what to do.\n\n   Libtool is getting in the way when \"openvpnsrvmsg.dll\" is created as\n   anything listed in ...BIN or ...LIB, so decare it as \"DATA\" and make\n   the necessary rules explicit.\n\n2. fix building of openvpnsrvmsg.dll on cmake/mingw builds\n\n   Fix \"find_program()\" invocation to avoid using \"midnight commander\"\n   binary (mc) on Linux (called \"windmc\" there).\n\n   Change from \"-Wl,--noentry\" to linker invocation that works.\n\nSee also:\nhttps://learn.microsoft.com/en-us/cpp/build/creating-a-resource-only-dll?view\u003dmsvc-170\n\nChange-Id: I071e8190dac28f429257b8af1c6f9e68f8896bc0\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1197\nMessage-Id: \u003c20250919112424.24728-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33083.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}