)]}'
{"id":"openvpn~1198","triplet_id":"openvpn~release%2F2.6~I7a57d7b4e84aa2b9c9e71e30520ed468b0e3c278","project":"openvpn","branch":"release/2.6","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-19 07:41:04.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-19 07:41:04.000000000","reason":"Change was submitted"},"1000008":{"account":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"last_update":"2025-09-19 07:41:04.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I7a57d7b4e84aa2b9c9e71e30520ed468b0e3c278","subject":"Validate DNS domain name before powershell invocation","status":"MERGED","created":"2025-09-18 09:55:45.000000000","updated":"2025-09-19 07:41:04.000000000","submitted":"2025-09-19 07:41:04.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1198","meta_rev_id":"83f420ab3546517261831259128728ceef93e737","_number":1198,"virtual_id_number":1198,"owner":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-18 09:55:45.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-18 09:55:45.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-18 09:55:45.000000000","updated_by":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-18 17:34:23.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"f27f5ba810f37ac468633b1553e2b11309a84603","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"date":"2025-09-18 09:55:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4333f194ff9748ce1dc7d4548dac76adf0b0933f","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-18 17:34:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"83f420ab3546517261831259128728ceef93e737","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-19 07:41:04.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6c3afe508b15764eea4e5bdcbaed37c02c281d9a","revisions":{"a4d4d6bd3781c3fb43b6f55419cf31a3861775c4":{"kind":"REWORK","_number":1,"created":"2025-09-18 09:55:45.000000000","uploader":{"_account_id":1000008,"name":"stipa","display_name":"Lev Stipakov","email":"lstipakov@gmail.com","username":"stipa"},"ref":"refs/changes/98/1198/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/1198/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1 \u0026\u0026 git checkout -b change-1198 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cabbf49ba267477c3015c3da9ee4bd45b1207211","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-18 09:10:05.000000000","tz":180},"committer":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-18 09:55:16.000000000","tz":180},"subject":"Validate DNS domain name before powershell invocation","message":"Validate DNS domain name before powershell invocation\n\nStarting from commit\n\n  d383d6e (\"win: replace wmic invocation with powershell\")\n\nwe pass --dhcp-option DOMAIN value to a powershell command\nto set DNS domain. Without validation this opens the door\nto a command injection atack.\n\nThis only allows domain names with chartacters:\n\n  [A-Za-z0-9.-_\\x80-\\0xff]\n\nChange-Id: I7a57d7b4e84aa2b9c9e71e30520ed468b0e3c278\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\n"},"branch":"refs/heads/release/2.6"},"6c3afe508b15764eea4e5bdcbaed37c02c281d9a":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-09-19 07:41:04.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/98/1198/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/98/1198/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2 \u0026\u0026 git checkout -b change-1198 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/98/1198/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cabbf49ba267477c3015c3da9ee4bd45b1207211","subject":"openvpnserv: Fix writing messages to the event log"}],"author":{"name":"Lev Stipakov","email":"lev@openvpn.net","date":"2025-09-18 17:34:40.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-18 17:49:03.000000000","tz":120},"subject":"Validate DNS domain name before powershell invocation","message":"Validate DNS domain name before powershell invocation\n\nStarting from commit\n\n  d383d6e (\"win: replace wmic invocation with powershell\")\n\nwe pass --dhcp-option DOMAIN value to a powershell command\nto set DNS domain. Without validation this opens the door\nto a command injection atack.\n\nThis only allows domain names with characters:\n\n  [A-Za-z0-9.-_\\x80-\\0xff]\n\nChange-Id: I7a57d7b4e84aa2b9c9e71e30520ed468b0e3c278\nSigned-off-by: Lev Stipakov \u003clev@openvpn.net\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1198\nMessage-Id: \u003c20250918173447.32466-1-gert@greenie.muc.de\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33071.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/release/2.6"}},"requirements":[],"submit_records":[],"submit_requirements":[]}