)]}'
{"id":"openvpn~1202","triplet_id":"openvpn~master~I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-23 14:35:24.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-23 14:35:24.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1","subject":"Enable a subset of -Wextra","status":"MERGED","created":"2025-09-19 11:41:00.000000000","updated":"2025-09-23 14:35:24.000000000","submitted":"2025-09-23 14:35:24.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1202-wextra","meta_rev_id":"32c0b3a71b5781eea99888b398e36994e55ad379","_number":1202,"virtual_id_number":1202,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-19 11:41:01.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-19 11:41:01.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-23 14:08:40.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"124968ad4bc74189f355eb03eb4eb1fb8a91e8ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-19 11:41:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ff9d73f1779b9a5aaebc7a58b12c574401531ea3","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-19 11:42:08.000000000","message":"Topic wextra,wip\u003dtrue removed","accounts_in_message":[],"_revision_number":1},{"id":"5b13691d92ed2bf10fbfcb70a5d66ee0c4ab1f0f","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-19 11:42:15.000000000","message":"Topic set to wextra","accounts_in_message":[],"_revision_number":1},{"id":"ea7a5a72fd326343944a94dffbd4a61a7e52c2c2","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-19 11:42:19.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"78f8c628a2e07e921aa27dc24a5f32acfae505c9","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-22 12:27:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"98208da52fdb7a55fd4db742da65c3a9f4afdebf","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-22 14:51:15.000000000","message":"Patch Set 2:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"01c72cbb8ed0c403778468408619e921284cc6c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-22 15:57:34.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0feb472df452aa70c0807514c9d001958a3bcf62","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-23 14:08:40.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"32c0b3a71b5781eea99888b398e36994e55ad379","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-23 14:35:24.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"45eb7e1807060a927ff805b0d01fbb8cfbb772c8","revisions":{"16cf44ae77101077b2542c1f5f78269f8717fcfa":{"kind":"REWORK","_number":1,"created":"2025-09-19 11:41:00.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1202/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1202/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1 \u0026\u0026 git checkout -b change-1202 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f5ccc997f5c5d51d5f184eb3f3952d2dc5fbac25","subject":"Enable -Wconversion -Wno-sign-conversion by default"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-19 11:09:33.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-19 11:39:37.000000000","tz":120},"subject":"Enable a subset of -Wextra","message":"Enable a subset of -Wextra\n\n- Includes fixes for\n  - -Wimplicit-fallthrough\u003d2\n    (\u003d3 is default but requires replacing all\n     fallthrough comments)\n  - -Wmissing-field-initializers\n  - -Wold-style-declaration\n- All other warnings that would need fixes are\n  disabled for now.\n\nChange-Id: I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"43720708bb6d7c1f0802b13c1d27e0d4fd30709b":{"kind":"REWORK","_number":2,"created":"2025-09-22 12:27:12.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1202/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1202/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2 \u0026\u0026 git checkout -b change-1202 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f5ccc997f5c5d51d5f184eb3f3952d2dc5fbac25","subject":"Enable -Wconversion -Wno-sign-conversion by default"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-19 11:09:33.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 12:25:34.000000000","tz":120},"subject":"Enable a subset of -Wextra","message":"Enable a subset of -Wextra\n\n- Includes fixes for\n  - -Wimplicit-fallthrough\u003d2\n    (\u003d3 is default but requires replacing all\n     fallthrough comments)\n  - -Wmissing-field-initializers\n  - -Wold-style-declaration\n- All other warnings that would need fixes are\n  disabled for now.\n\nChange-Id: I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"4c3ad1008c6566f91a03a9d371577c4086fde9a7":{"kind":"REWORK","_number":3,"created":"2025-09-22 15:57:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/02/1202/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1202/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3 \u0026\u0026 git checkout -b change-1202 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"2bb658c826b19cba830328fd8ed8580838e51d5f","subject":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-19 11:09:33.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 15:57:23.000000000","tz":120},"subject":"Enable a subset of -Wextra","message":"Enable a subset of -Wextra\n\n- Includes fixes for\n  - -Wimplicit-fallthrough\u003d2\n    (\u003d3 is default but requires replacing all\n     fallthrough comments)\n  - -Wmissing-field-initializers\n  - -Wold-style-declaration\n- All other warnings that would need fixes are\n  disabled for now.\n\nChange-Id: I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"45eb7e1807060a927ff805b0d01fbb8cfbb772c8":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2025-09-23 14:35:24.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/02/1202/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/02/1202/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4 \u0026\u0026 git checkout -b change-1202 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/02/1202/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9bfd4d246c50743c8ff9cdb72afc8741eab91f03","subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-23 14:08:48.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-23 14:11:45.000000000","tz":120},"subject":"Enable a subset of -Wextra","message":"Enable a subset of -Wextra\n\n- Includes fixes for\n  - -Wimplicit-fallthrough\u003d2\n    (\u003d3 is default but requires replacing all\n     fallthrough comments)\n  - -Wmissing-field-initializers\n  - -Wold-style-declaration\n- All other warnings that would need fixes are\n  disabled for now.\n\nChange-Id: I9ce664d073a4e6a6d433e9e6f986a5086dae8aa1\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1202\nMessage-Id: \u003c20250923140854.21766-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59237558/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}