)]}'
{"id":"openvpn~1203","triplet_id":"openvpn~master~I5fea6ca1ccadb434b5c4f4b49881524a079a9d15","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-22 08:50:20.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-09-22 08:50:20.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-22 08:50:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I5fea6ca1ccadb434b5c4f4b49881524a079a9d15","subject":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change","status":"MERGED","created":"2025-09-22 07:01:10.000000000","updated":"2025-09-22 08:50:20.000000000","submitted":"2025-09-22 08:50:20.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1203","meta_rev_id":"7fff78e211639c082bd45c52f67c5d258513c7db","_number":1203,"virtual_id_number":1203,"owner":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-22 07:01:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-22 07:01:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-22 07:01:11.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-22 07:41:27.000000000","updated_by":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"reviewer":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"state":"REVIEWER"}],"messages":[{"id":"e43f09ca775ade2cee77052d9eb0c7f0138b1ed1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-22 07:01:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a0bb02b6443beb5913eb8f7aec46b3bbdfef319d","author":{"_account_id":1000007,"name":"ordex","display_name":"Antonio Quartulli","email":"antonio@mandelbit.com","username":"ordex"},"date":"2025-09-22 07:41:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7fff78e211639c082bd45c52f67c5d258513c7db","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-22 08:50:20.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2bb658c826b19cba830328fd8ed8580838e51d5f","revisions":{"b6a9fd007fe62fc1bab35b1cc0977d248fd1c662":{"kind":"REWORK","_number":1,"created":"2025-09-22 07:01:10.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/03/1203/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1203/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1 \u0026\u0026 git checkout -b change-1203 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0df0edc49ce4acb96c8e16bdf0fcee1eedfd91f0","subject":"Bugfix: Set broadcast address on interface."}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-22 06:53:43.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-22 06:53:43.000000000","tz":120},"subject":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change","message":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change\n\nCommit 0df0edc49c re-introduced explicit setting of broadcast addresses\nfor Linux IPv4 interfaces.  t_net.sh verifies that the built-in netlink\ncode (sitnl) achieves the same result as \"equivalent\" iproute2 statements\n- and we missed adjusting of these iproute2 statements (printed by\nnetworking_testdriver).  Done.\n\nChange-Id: I5fea6ca1ccadb434b5c4f4b49881524a079a9d15\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"},"2bb658c826b19cba830328fd8ed8580838e51d5f":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2025-09-22 08:50:20.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/03/1203/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/03/1203/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2 \u0026\u0026 git checkout -b change-1203 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/03/1203/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0df0edc49ce4acb96c8e16bdf0fcee1eedfd91f0","subject":"Bugfix: Set broadcast address on interface."}],"author":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-22 08:02:59.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-22 08:42:27.000000000","tz":120},"subject":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change","message":"Fix t_net.sh / networking_testdriver after \u0027broadcast\u0027 change\n\nCommit 0df0edc49c re-introduced explicit setting of broadcast addresses\nfor Linux IPv4 interfaces.  t_net.sh verifies that the built-in netlink\ncode (sitnl) achieves the same result as \"equivalent\" iproute2 statements\n- and we missed adjusting of these iproute2 statements (printed by\nnetworking_testdriver).  Done.\n\nChange-Id: I5fea6ca1ccadb434b5c4f4b49881524a079a9d15\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nAcked-by: Antonio Quartulli \u003cantonio@mandelbit.com\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1203\nMessage-Id: \u003c20250922080305.18477-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59236810/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
