)]}'
{"id":"openvpn~1204","triplet_id":"openvpn~master~I1ce408d4473874d88a348308503527ef7eb8c1ff","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-09-23 12:57:07.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-09-23 12:57:07.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1ce408d4473874d88a348308503527ef7eb8c1ff","subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend","status":"MERGED","created":"2025-09-22 12:27:12.000000000","updated":"2025-09-23 12:57:07.000000000","submitted":"2025-09-23 12:57:07.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1204-wextra","meta_rev_id":"1265440dfa996c5cd8c672a99ed299afee4956f2","_number":1204,"virtual_id_number":1204,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-22 12:27:13.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-22 12:27:13.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-23 12:19:51.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"2f9eb7164163b213efd9efe93e6909ac8d4253b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-22 12:27:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"962b8215c31e11c053a37ebb8569d139a3fab725","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-22 15:57:34.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"670788b1e16b660a8876706dce2d059c0ba1b7d4","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-23 12:19:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1265440dfa996c5cd8c672a99ed299afee4956f2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-23 12:57:07.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9bfd4d246c50743c8ff9cdb72afc8741eab91f03","revisions":{"c798d5a67124b5c00bd8fb4730cade08b9c888ab":{"kind":"REWORK","_number":1,"created":"2025-09-22 12:27:12.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1204/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1204/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1 \u0026\u0026 git checkout -b change-1204 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"43720708bb6d7c1f0802b13c1d27e0d4fd30709b","subject":"Enable a subset of -Wextra"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 12:25:49.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 12:25:49.000000000","tz":120},"subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend","message":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend\n\nThe prepend behavior is surprising. If there is a difference\nin behavior at least make it easy to understand what happens\nwhy.\n\nChange-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"494029a7f3bd30b2cc5ee8d156f2063e626b4344":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-09-22 15:57:34.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/04/1204/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1204/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2 \u0026\u0026 git checkout -b change-1204 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"4c3ad1008c6566f91a03a9d371577c4086fde9a7","subject":"Enable a subset of -Wextra"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 12:25:49.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-22 15:57:25.000000000","tz":120},"subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend","message":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend\n\nThe prepend behavior is surprising. If there is a difference\nin behavior at least make it easy to understand what happens\nwhy.\n\nChange-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"9bfd4d246c50743c8ff9cdb72afc8741eab91f03":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-09-23 12:57:07.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/04/1204/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/04/1204/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3 \u0026\u0026 git checkout -b change-1204 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/04/1204/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f32844b25c3b3b352bad0b250fd8721656ae9bc0","subject":"Clean up conversion warnings related to base64_{en, de}code"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-23 12:20:00.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-09-23 12:46:05.000000000","tz":120},"subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend","message":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend\n\nThe prepend behavior is surprising. If there is a difference\nin behavior at least make it easy to understand what happens\nwhy.\n\nChange-Id: I1ce408d4473874d88a348308503527ef7eb8c1ff\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1204\nMessage-Id: \u003c20250923122006.12212-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59237450/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}