)]}'
{"id":"openvpn~1206","triplet_id":"openvpn~master~Ie6b4c41d13544d5ba71d441cc794c7abd12408f3","project":"openvpn","branch":"master","topic":"wextra","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-05 20:42:00.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-05 20:42:00.000000000","reason":"Change was submitted"},"1000030":{"account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"last_update":"2025-09-26 16:16:40.000000000","reason":"\u003cGERRIT_ACCOUNT_1000030\u003e replied on the change","reason_account":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}}},"hashtags":["mailsubmitted"],"change_id":"Ie6b4c41d13544d5ba71d441cc794c7abd12408f3","subject":"platform: Do not assume uid_t/gid_t are signed","status":"MERGED","created":"2025-09-23 11:34:00.000000000","updated":"2025-10-05 20:42:00.000000000","submitted":"2025-10-05 20:42:00.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1206-wextra","meta_rev_id":"16ed8382eabf91b899a071f5ecb68975a2f771dd","_number":1206,"virtual_id_number":1206,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"value":0,"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}],"REVIEWER":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-23 11:34:01.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-23 11:34:01.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-24 16:33:31.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"CC"},{"updated":"2025-09-26 16:16:40.000000000","updated_by":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"reviewer":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"state":"REVIEWER"}],"messages":[{"id":"a5b6f0d79fcec80a08813b3a64ab55d65b636396","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-23 11:34:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fca8c6e5547380034afcb0b005f6ad6c36d6aaa5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 13:17:55.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"6bf6c44f76ae12d2c9397c98b71b1f0e5ecfa16f","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-09-24 16:33:31.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"e9fd5ae1e8b7a1ffaf68b00af655641412fb55d8","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 16:38:22.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"fd188dcc70f926fdab4a7bc8275d451788f2c178","author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"date":"2025-09-26 16:16:40.000000000","message":"Patch Set 2: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"075b6acf802fb2a122502f93a046ad4f6f93446a","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-03 10:06:21.000000000","message":"Hashtag added: mailsubmitted","accounts_in_message":[],"_revision_number":2},{"id":"16ed8382eabf91b899a071f5ecb68975a2f771dd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-05 20:42:00.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"eadae51341dbf80c83e827bb4011e80dfcbc6927","revisions":{"fff8b00192bf1432339859239a0bb797163931a1":{"kind":"REWORK","_number":1,"created":"2025-09-23 11:34:00.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/06/1206/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1206/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1 \u0026\u0026 git checkout -b change-1206 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"494029a7f3bd30b2cc5ee8d156f2063e626b4344","subject":"configure.ac: Make ACL_CHECK_ADD_COMPILE_FLAGS append instead of prepend"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-23 11:27:47.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-23 11:27:47.000000000","tz":120},"subject":"platform: Do not assume uid_t/gid_t are signed","message":"platform: Do not assume uid_t/gid_t are signed\n\nuid_t/gid_t are int on many platform but unsigned\non at least Linux. So rewrite the code in a way that\ndoes not make any assumptions about the types. Mainly\nthis means storing the information whether the value\nis valid in a separate bool and not in the value\nitself.\n\nNote that this changes the return behavior of\nplatform_{user,group}_get but a review of the\ncallers determined that this makes no actual\ndifference.\n\nChange-Id: Ie6b4c41d13544d5ba71d441cc794c7abd12408f3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ad0eb9957b50fd378ece5d2cb66f76dc3e307c95":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-09-24 13:17:55.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/06/1206/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1206/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2 \u0026\u0026 git checkout -b change-1206 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ac840942b54b7159d993c86842efa16a9abbd98","subject":"Enable -Wconversion -Wno-sign-conversion by default"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-23 11:27:47.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 13:12:39.000000000","tz":120},"subject":"platform: Do not assume uid_t/gid_t are signed","message":"platform: Do not assume uid_t/gid_t are signed\n\nuid_t/gid_t are int on many platform but unsigned\non at least Linux. So rewrite the code in a way that\ndoes not make any assumptions about the types. Mainly\nthis means storing the information whether the value\nis valid in a separate bool and not in the value\nitself.\n\nNote that this changes the return behavior of\nplatform_{user,group}_get but a review of the\ncallers determined that this makes no actual\ndifference.\n\nChange-Id: Ie6b4c41d13544d5ba71d441cc794c7abd12408f3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"eadae51341dbf80c83e827bb4011e80dfcbc6927":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2025-10-05 20:42:00.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/06/1206/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/06/1206/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3 \u0026\u0026 git checkout -b change-1206 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/06/1206/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9243ea88913fc1bed26c25ba7d7b18bb2f16fa4c","subject":"route: Fix a unused-but-set-variable warning on OpenBSD"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-03 10:06:02.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-05 16:41:00.000000000","tz":120},"subject":"platform: Do not assume uid_t/gid_t are signed","message":"platform: Do not assume uid_t/gid_t are signed\n\nuid_t/gid_t are int on many platform but unsigned\non at least Linux. So rewrite the code in a way that\ndoes not make any assumptions about the types. Mainly\nthis means storing the information whether the value\nis valid in a separate bool and not in the value\nitself.\n\nNote that this changes the return behavior of\nplatform_{user,group}_get but a review of the\ncallers determined that this makes no actual\ndifference.\n\nChange-Id: Ie6b4c41d13544d5ba71d441cc794c7abd12408f3\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: MaxF \u003cmax@max-fillinger.net\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1206\nMessage-Id: \u003c20251003100602.375062-1-frank@lichtenheld.com\u003e\nURL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33266.html\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}