)]}'
{"src/openvpn/init.c":[{"author":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"change_message_id":"18b65f4929b2d6487b376d3aef89f41b34b25ee2","unresolved":true,"context_lines":[{"line_number":2729,"context_line":"    /* Ensure that for epoch data format is only enabled if also data v2"},{"line_number":2730,"context_line":"     * is enabled */"},{"line_number":2731,"context_line":"    bool epoch_data \u003d (c-\u003eoptions.imported_protocol_flags \u0026 CO_EPOCH_DATA_KEY_FORMAT);"},{"line_number":2732,"context_line":"    bool datav2_enabled \u003d c-\u003eoptions.peer_id \u003c MAX_PEER_ID;"},{"line_number":2733,"context_line":""},{"line_number":2734,"context_line":"    if (epoch_data \u0026\u0026 !datav2_enabled)"},{"line_number":2735,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"c01e41e9_729132bc","line":2732,"updated":"2025-10-14 09:47:00.000000000","message":"Yes that is correct from the standpoint of no sign compare but the check should be fixed to actually do what it says. Replace the first part with c-\u003eoptions.use_peer_id","commit_id":"d604b0930850e26dc4b1dc53be26582af6c1e31e"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"8df9ac1196c769e183d43b05402b77d9dc1d890f","unresolved":false,"context_lines":[{"line_number":2729,"context_line":"    /* Ensure that for epoch data format is only enabled if also data v2"},{"line_number":2730,"context_line":"     * is enabled */"},{"line_number":2731,"context_line":"    bool epoch_data \u003d (c-\u003eoptions.imported_protocol_flags \u0026 CO_EPOCH_DATA_KEY_FORMAT);"},{"line_number":2732,"context_line":"    bool datav2_enabled \u003d c-\u003eoptions.peer_id \u003c MAX_PEER_ID;"},{"line_number":2733,"context_line":""},{"line_number":2734,"context_line":"    if (epoch_data \u0026\u0026 !datav2_enabled)"},{"line_number":2735,"context_line":"    {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2c9249b3_2d7cd62b","line":2732,"in_reply_to":"c01e41e9_729132bc","updated":"2025-10-14 11:35:32.000000000","message":"https://gerrit.openvpn.net/c/openvpn/+/1273","commit_id":"d604b0930850e26dc4b1dc53be26582af6c1e31e"}]}
