)]}'
{"id":"openvpn~1210","triplet_id":"openvpn~master~Ib3458a9ed2eb38e00184c4a92659b83b97fe476c","project":"openvpn","branch":"master","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-11 11:49:08.000000000","reason":"Change was submitted"},"1000002":{"account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"last_update":"2025-10-11 11:12:31.000000000","reason":"\u003cGERRIT_ACCOUNT_1000002\u003e replied on the change","reason_account":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-11 11:49:08.000000000","reason":"Change was submitted"},"1000040":{"account":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"last_update":"2025-10-11 11:49:08.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ib3458a9ed2eb38e00184c4a92659b83b97fe476c","subject":"redirect-gateway: only redirect traffic through TUN if address families match","status":"MERGED","created":"2025-09-24 09:30:18.000000000","updated":"2025-10-11 11:49:08.000000000","submitted":"2025-10-11 11:49:08.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1210","meta_rev_id":"97b81865ea07c259b56a051cad5e1d20318ffdd4","_number":1210,"virtual_id_number":1210,"owner":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-24 09:30:18.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-24 09:30:18.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"state":"REVIEWER"},{"updated":"2025-09-24 09:30:18.000000000","updated_by":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-09-24 09:55:56.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"CC"},{"updated":"2025-10-06 09:15:29.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"921bbb259d10656394ef1d5ba48fcd54184a5663","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-09-24 09:30:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9399e69ea847ab3ed2e49e9d7058c2a996b54fcb","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-24 09:55:56.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c2079e5623bde539bbaf8fd387ab3f11d880c432","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-09-24 10:10:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8f101364d782b1b7afbf085e9f2cca1b9e94abf1","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-09-24 10:11:40.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d95f058c3a69fc7276733b8319a2f3893f048094","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-09-25 13:07:24.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e7a94a504e12b778f8785044d05a601ae0c0a646","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-05 18:59:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"30be7c355465afac670b79cb78aa8479dba51391","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-06 09:10:53.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"0739cce6392ea863734d4c0a2be9dca06e268c4d","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-06 09:15:29.000000000","message":"Patch Set 3: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"270f0e3113714b89fe05820bc34b2a7b816f95ca","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-06 09:17:47.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"612d5a2eb903b7d8821d363d419a7caf91639c24","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 15:44:13.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review-2 (copy condition: \"changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR **is:MIN**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"af16a2fc3b9b065fc221f01a110291e974e76efc","author":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"date":"2025-10-10 15:50:09.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"c4f0d5744e387bdb3580da19481cacac1dfdd4d9","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-11 11:12:31.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"97b81865ea07c259b56a051cad5e1d20318ffdd4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-11 11:49:08.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"0f9ad850d4202f0efe42976b00156226df7dfa17","revisions":{"ffcd21b620b82fce60eed0be52076970fc613ec4":{"kind":"REWORK","_number":1,"created":"2025-09-24 09:30:18.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/10/1210/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1210/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1 \u0026\u0026 git checkout -b change-1210 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"945db23ef49c3e8c36c6bef8857058544caa77f6","subject":"multi_io_init: simplify"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-20 15:23:53.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-09-24 09:18:10.000000000","tz":120},"subject":"redirect-gateway: Only redirect traffic through TUN if address families match","message":"redirect-gateway: Only redirect traffic through TUN if address families match\n\nFixes an ifconfig push-reply bug where, if the remote is switched and the new\nTUN has a different address family, the previous ifconfig options remain\nassigned to the new TUN.\n\nAdds a check in do_init_route_ipv6_list() to add default routes toward the TUN\nonly if the TUN has IPv6 addresses.\n\nChange-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c\n"},"branch":"refs/heads/master"},"c24d511994f10d54cb4a4807dd27b6e975b50016":{"kind":"REWORK","_number":2,"created":"2025-10-05 18:59:40.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/10/1210/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1210/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2 \u0026\u0026 git checkout -b change-1210 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9243ea88913fc1bed26c25ba7d7b18bb2f16fa4c","subject":"route: Fix a unused-but-set-variable warning on OpenBSD"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-20 15:23:53.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-05 18:53:42.000000000","tz":120},"subject":"redirect-gateway: Only redirect traffic through TUN if address families match","message":"redirect-gateway: Only redirect traffic through TUN if address families match\n\nFixes an ifconfig push-reply bug where, if the remote is switched and the new\nTUN has a different address family, the previous ifconfig options remain\nassigned to the new TUN.\n\nAdds a check in do_init_route_ipv6_list() to add default routes toward the TUN\nonly if the TUN has IPv6 addresses.\n\nChange-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c\n"},"branch":"refs/heads/master"},"4201fe86354c478c4fd623961ead50133a1eefb1":{"kind":"REWORK","_number":3,"created":"2025-10-06 09:10:53.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/10/1210/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1210/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3 \u0026\u0026 git checkout -b change-1210 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9243ea88913fc1bed26c25ba7d7b18bb2f16fa4c","subject":"route: Fix a unused-but-set-variable warning on OpenBSD"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-20 15:23:53.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-06 09:06:28.000000000","tz":120},"subject":"redirect-gateway: only redirect traffic through TUN if address families match","message":"redirect-gateway: only redirect traffic through TUN if address families match\n\nFixes an ifconfig push-reply bug where, if the remote is switched and the new\nTUN has a different address family, the previous ifconfig options remain\nassigned to the new TUN.\n\nAdds a check in do_init_route_ipv6_list() to add default routes toward the TUN\nonly if the TUN has IPv6 addresses.\n\nIt also resets the ifconfig and ifconfig-ipv6 options on every PUSH_REPLY and\nwhenever a valid ifconfig or ifconfig-ipv6 option is found in a PUSH_UPDATE\nmessage to avoid stale data conflicts. This may be necessary when the new\naddress has a different address family than the old one.\n\nChange-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c\n"},"branch":"refs/heads/master"},"ab351859532371fd3da5328307f6cf1e5b9e897a":{"kind":"REWORK","_number":4,"created":"2025-10-10 15:44:13.000000000","uploader":{"_account_id":1000040,"name":"mrbff","email":"marco@mandelbit.com","username":"mrbff"},"ref":"refs/changes/10/1210/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1210/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4 \u0026\u0026 git checkout -b change-1210 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"855094893e8cd808ddc74d2e6d392cf04bd06a65","subject":"PUSH_UPDATE server: check IV_PROTO before sending the message to the client"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-02-20 15:23:53.000000000","tz":60},"committer":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-10 15:17:46.000000000","tz":120},"subject":"redirect-gateway: only redirect traffic through TUN if address families match","message":"redirect-gateway: only redirect traffic through TUN if address families match\n\nAdds a check in do_init_route_ipv6_list() to add default routes toward the TUN\nonly if the TUN has IPv6 addresses.\n\nGithub: fixes OpenVPN/openvpn#850\ngithub.com/OpenVPN/openvpn/issues/850\n\nChange-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c\n"},"branch":"refs/heads/master"},"0f9ad850d4202f0efe42976b00156226df7dfa17":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":5,"created":"2025-10-11 11:49:08.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/10/1210/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/10/1210/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5 \u0026\u0026 git checkout -b change-1210 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/10/1210/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"e7fdde7cb8d39a51a4a38b0d16f23a18d086cfe2","subject":"test_user_pass: Check fatal errors for empty username/password"}],"author":{"name":"Marco Baffo","email":"marco@mandelbit.com","date":"2025-10-11 11:14:11.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-11 11:44:54.000000000","tz":120},"subject":"redirect-gateway: only redirect traffic through TUN if address families match","message":"redirect-gateway: only redirect traffic through TUN if address families match\n\nAdds a check in do_init_route_ipv6_list() to add default routes toward the TUN\nonly if the TUN has IPv6 addresses.\n\nGithub: fixes OpenVPN/openvpn#850\nGithub: see also OpenVPN/openvpn#863\n\nChange-Id: Ib3458a9ed2eb38e00184c4a92659b83b97fe476c\nSigned-off-by: mrbff \u003cmarco@mandelbit.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1210\nMessage-Id: \u003c20251011111417.11802-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59245295/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}