)]}'
{"id":"openvpn~1216","triplet_id":"openvpn~master~I04542e678f81d5d4a853b4370d9b8adc4dac1212","project":"openvpn","branch":"master","topic":"wconversion","attention_set":{},"removed_from_attention_set":{"1000003":{"account":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"last_update":"2025-10-10 09:56:21.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"last_update":"2025-10-10 09:56:21.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I04542e678f81d5d4a853b4370d9b8adc4dac1212","subject":"console: Simplify query_user_add interface","status":"MERGED","created":"2025-09-24 16:36:25.000000000","updated":"2025-10-10 09:56:21.000000000","submitted":"2025-10-10 09:56:21.000000000","submitter":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1216-wconversion","meta_rev_id":"cc6fae79d12e8e60d1eaf7f5e6a84325a66ecacd","_number":1216,"virtual_id_number":1216,"owner":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"}],"values":{"-2":"This shall not be submitted","-1":"I would prefer this is not submitted as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0}},"removable_reviewers":[{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"}],"CC":[{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-24 16:36:26.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000026,"name":"openvpn-devel","email":"openvpn-devel@lists.sourceforge.net","username":"openvpn-devel"},"state":"CC"},{"updated":"2025-09-24 16:36:26.000000000","updated_by":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"reviewer":{"_account_id":1000003,"name":"plaisthos","display_name":"Arne Schwabe","email":"arne-openvpn@rfc2549.org","username":"plaisthos"},"state":"REVIEWER"},{"updated":"2025-10-10 09:47:23.000000000","updated_by":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"reviewer":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"state":"REVIEWER"}],"messages":[{"id":"3351decec050fb61223e1edaabcf33cf91725445","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-24 16:36:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c8c1d8f8ce76ca20ca804aa1b46b7eadf5d3b624","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-09-30 11:03:19.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a1050c1bb4be270d736271a5a93949816fa5c97e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-06 16:06:59.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"2961e53d5a6a168f3f14928e6ec9d12b9808c26b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-07 11:15:05.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"77783938e00add8e51b567a3ede1164c96092bc3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"date":"2025-10-08 16:11:57.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"a2d3fa5eebbf511e02b7f0ab8ffb5ce876d8983e","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 09:47:23.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"cc6fae79d12e8e60d1eaf7f5e6a84325a66ecacd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"date":"2025-10-10 09:56:21.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"aea7727f2de8c4f34d71a8c14756bdf395cb5f2f","revisions":{"c553f7e8e6bde777666f0350b56652787e7aff99":{"kind":"REWORK","_number":1,"created":"2025-09-24 16:36:25.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/16/1216/1","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/1","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"a59672b5f32d84e3945928be84843733d68bceec","subject":"comp-lz4: Fix types in call to LZ4_decompress_safe"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"0ba139eb7eea7acf98a0fe25e429c52813a8b805":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2025-09-30 11:03:19.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/16/1216/2","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/2","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3ae17f69bfee8150343f8bd4ad0b90e42be8e230","subject":"vlan: Limit -Wconversion override to GCC 10 and older"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-30 10:55:54.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"d8e69143c38ad7ecf704143852452b174ab6c76c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2025-10-06 16:06:59.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/16/1216/3","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/3","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"ba9a2cdf56dde24d88fb53c4444a05b179f9ba74","subject":"vlan: Limit -Wconversion override to GCC 10 and older"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-06 16:06:15.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"15de3ab9e4e0db36678c1d4a1f50de0a844c0e59":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2025-10-07 11:15:05.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/16/1216/4","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/4","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"44c2d8e55d9821d5dec4bfec219679c70ef34561","subject":"vlan: Remove -Wconversion override"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-07 10:45:18.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"ed49893788cf8d3a966264404c4ad2b45f6be6c2":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2025-10-08 16:11:57.000000000","uploader":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"ref":"refs/changes/16/1216/5","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/5","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"5b8e0563f950aa5d246f32785afffd8824d9f9ab","subject":"test_options_parse: Do not use uintmax_t instead of LargestIntegralType"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-09-24 16:12:55.000000000","tz":120},"committer":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-08 15:29:56.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\n"},"branch":"refs/heads/master"},"aea7727f2de8c4f34d71a8c14756bdf395cb5f2f":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":6,"created":"2025-10-10 09:56:21.000000000","uploader":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"ref":"refs/changes/16/1216/6","fetch":{"anonymous http":{"url":"http://gerrit.openvpn.net/openvpn","ref":"refs/changes/16/1216/6","commands":{"Branch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6 \u0026\u0026 git checkout -b change-1216 FETCH_HEAD","Checkout":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6","Reset To":"git fetch http://gerrit.openvpn.net/openvpn refs/changes/16/1216/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"7579749fee05ee8a06dd6169396fb60f7558925a","subject":"options: Review use of positive_atoi vs atoi_constrained"}],"author":{"name":"Frank Lichtenheld","email":"frank@lichtenheld.com","date":"2025-10-10 09:47:44.000000000","tz":120},"committer":{"name":"Gert Doering","email":"gert@greenie.muc.de","date":"2025-10-10 09:51:38.000000000","tz":120},"subject":"console: Simplify query_user_add interface","message":"console: Simplify query_user_add interface\n\n- Removes unused field prompt_len\n- Change field reponse_len to int since that\n  is what the code actually expects. Most callers\n  user a constant either way.\n\nChange-Id: I04542e678f81d5d4a853b4370d9b8adc4dac1212\nSigned-off-by: Frank Lichtenheld \u003cfrank@lichtenheld.com\u003e\nAcked-by: Gert Doering \u003cgert@greenie.muc.de\u003e\nGerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1216\nMessage-Id: \u003c20251010094753.2825-1-gert@greenie.muc.de\u003e\nURL: https://sourceforge.net/p/openvpn/mailman/message/59244794/\nSigned-off-by: Gert Doering \u003cgert@greenie.muc.de\u003e\n"},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}