)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"cron2","display_name":"Gert Doering","email":"gert@greenie.muc.de","username":"cron2"},"change_message_id":"a5c217d95839f8a82a6eb453f9afa26b6d36486e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c368141_22cc512c","updated":"2025-10-06 19:36:22.000000000","message":"While this is still being worked on (\"looking into length limits\"), wouldn\u0027t it make sense to squash #1252 into this?","commit_id":"087d745579bee559513f94741626649de01e54d0"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"554346050d62765ed77b5a96d3a23c719fa9de0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e946b819_fa51e56c","in_reply_to":"2c368141_22cc512c","updated":"2025-10-07 11:16:46.000000000","message":"Done","commit_id":"087d745579bee559513f94741626649de01e54d0"}],"src/openvpn/crypto.c":[{"author":{"_account_id":1000030,"name":"MaxF","email":"max@max-fillinger.net","username":"MaxF"},"change_message_id":"5804d928a247cb5b4614c2fee4e8bf0af363c83d","unresolved":true,"context_lines":[{"line_number":1373,"context_line":"     */"},{"line_number":1374,"context_line":"    if (flags \u0026 RKF_INLINE) /* \u0027file\u0027 is a string containing ascii representation of key */"},{"line_number":1375,"context_line":"    {"},{"line_number":1376,"context_line":"        size \u003d (int)(strlen(file) + 1);"},{"line_number":1377,"context_line":"        buf_set_read(\u0026in, (const uint8_t *)file, size);"},{"line_number":1378,"context_line":"    }"},{"line_number":1379,"context_line":"    else /* \u0027file\u0027 is a filename which refers to a file containing the ascii key */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"8d9d8626_7fe8921d","line":1376,"updated":"2025-09-26 15:57:27.000000000","message":"You say that there are limits imposed so that this is safe, but I can\u0027t find where that happens. I\u0027ve looked at options.c and I don\u0027t see any limits on the length of tls_crypt_file for example.","commit_id":"ead9944e6d500c83ef4e5629f9122ffdec0a49a2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"c8a2bc8492d0769a8705bf4ee98017127929d853","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"     */"},{"line_number":1374,"context_line":"    if (flags \u0026 RKF_INLINE) /* \u0027file\u0027 is a string containing ascii representation of key */"},{"line_number":1375,"context_line":"    {"},{"line_number":1376,"context_line":"        size \u003d (int)(strlen(file) + 1);"},{"line_number":1377,"context_line":"        buf_set_read(\u0026in, (const uint8_t *)file, size);"},{"line_number":1378,"context_line":"    }"},{"line_number":1379,"context_line":"    else /* \u0027file\u0027 is a filename which refers to a file containing the ascii key */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4dca562e_6825716a","line":1376,"in_reply_to":"04d4bd3a_735a3dad","updated":"2025-10-07 11:16:32.000000000","message":"Done","commit_id":"ead9944e6d500c83ef4e5629f9122ffdec0a49a2"},{"author":{"_account_id":1000001,"name":"flichtenheld","display_name":"Frank Lichtenheld","email":"frank@lichtenheld.com","username":"flichtenheld","status":"OpenVPN Inc."},"change_message_id":"587f21f48590e4199a1ef585eae17ef15f03051b","unresolved":true,"context_lines":[{"line_number":1373,"context_line":"     */"},{"line_number":1374,"context_line":"    if (flags \u0026 RKF_INLINE) /* \u0027file\u0027 is a string containing ascii representation of key */"},{"line_number":1375,"context_line":"    {"},{"line_number":1376,"context_line":"        size \u003d (int)(strlen(file) + 1);"},{"line_number":1377,"context_line":"        buf_set_read(\u0026in, (const uint8_t *)file, size);"},{"line_number":1378,"context_line":"    }"},{"line_number":1379,"context_line":"    else /* \u0027file\u0027 is a filename which refers to a file containing the ascii key */"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"04d4bd3a_735a3dad","line":1376,"in_reply_to":"8d9d8626_7fe8921d","updated":"2025-09-30 13:51:17.000000000","message":"This is actually good question. Normal parameters are limited to 256 characters, but after checking it seems inline parameters have no such limit. I will look further into this.","commit_id":"ead9944e6d500c83ef4e5629f9122ffdec0a49a2"}]}
